Project

General

Profile

Feature #9877

Feature #5330: Test suite: identify and document race conditions

Unused @gksu@ step in test suite

Added by kytv almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
08/02/2015
Due date:
% Done:

100%

Feature Branch:
kytv:test/9877-remove-unused-step
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

While investigating #5330 I found this step which doesn't appear to be used anymore.

diff --git a/features/step_definitions/common_steps.rb b/features/step_definitions/common_steps.rb
index 08f66e2..fad9cd3 100644
--- a/features/step_definitions/common_steps.rb
+++ b/features/step_definitions/common_steps.rb
@@ -454,15 +454,6 @@ Then /^all Internet traffic has only flowed through Tor$/ do
   leaks.assert_no_leaks
 end

-Given /^I enter the sudo password in the gksu prompt$/ do
-  next if @skip_steps_while_restoring_background
-  @screen.wait('GksuAuthPrompt.png', 60)
-  sleep 1 # wait for weird fade-in to unblock the "Ok" button
-  @screen.type(@sudo_password)
-  @screen.type(Sikuli::Key.ENTER)
-  @screen.waitVanish('GksuAuthPrompt.png', 10)
-end
-
 Given /^I enter the sudo password in the pkexec prompt$/ do
   next if @skip_steps_while_restoring_background
   step "I enter the \"#{@sudo_password}\" password in the pkexec prompt" 

Perhaps it should be removed.

Associated revisions

Revision 8f3de945 (diff)
Added by kytv almost 4 years ago

Remove unused 'gksu' step

This causes a false-positive to be found for #5330.

Will-fix: #9877

Revision 0182f302
Added by anonym almost 4 years ago

Merge remote-tracking branch 'kytv/test/9877-remove-unused-step' into stable

Fix-committed: #9877

History

#1 Updated by kytv almost 4 years ago

Note: Added as a subtask of #5330 due to this comment in that ticket's description:

Just run git grep sleep features/step_definitions/*.rb for an up-to-date list of these "violations".

...which showed this gksu step.

#2 Updated by kytv almost 4 years ago

  • Status changed from New to In Progress
  • Assignee changed from kytv to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/9877-remove-unused-step

With this commit there's one less result for the command git grep sleep features/step_definitions/*.rb specified in #5330.

#3 Updated by intrigeri almost 4 years ago

  • Assignee changed from intrigeri to anonym
  • Target version changed from Tails_1.5 to Tails_1.6

#4 Updated by kytv almost 4 years ago

#5 Updated by anonym almost 4 years ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

#6 Updated by anonym almost 4 years ago

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#7 Updated by bertagaz almost 4 years ago

  • Status changed from Fix committed to Resolved
  • QA Check deleted (Pass)

Also available in: Atom PDF