Project

General

Profile

Bug #9791

Feature #7563: Update the automated test suite for Jessie ISO images

Update torified_gnupg feature for Jessie

Added by kytv almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
Test suite
Target version:
Start date:
07/22/2015
Due date:
01/15/2016
% Done:

100%

Feature Branch:
kytv/test/9791-seahorse-jessie
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

This feature fails due to SeahorseEdit.png being a broken symlink to GeditEdit.png


Related issues

Related to Tails - Bug #9970: Seahorse may segfault during key synchronization Rejected 08/11/2015
Related to Tails - Bug #9046: Update the encryption test for Jessie Resolved 03/11/2015
Blocked by Tails - Bug #9792: Syncing keys in Seahorse does not work in Jessie Resolved 07/22/2015

Associated revisions

Revision 0ee1f3c1
Added by intrigeri over 3 years ago

Merge remote-tracking branch 'kytv/test/9791-seahorse-jessie' into feature/jessie

Fix-committed: #9791

History

#1 Updated by kytv almost 4 years ago

  • Assignee set to kytv

#2 Updated by intrigeri almost 4 years ago

  • Due date set to 01/15/2016
  • Target version changed from 246 to Tails_1.8
  • Parent task set to #7563

#4 Updated by intrigeri almost 4 years ago

  • Priority changed from Normal to High

#5 Updated by intrigeri almost 4 years ago

  • Blocked by Bug #9792: Syncing keys in Seahorse does not work in Jessie added

#6 Updated by kytv almost 4 years ago

It also parses syslog which of course isn't available in Tails/Jessie to look for segfaults, so the feature will have to be updated to look in the journal.

#7 Updated by intrigeri almost 4 years ago

It also parses syslog which of course isn't available in Tails/Jessie to look for segfaults, so the feature will have to be updated to look in the journal.

Indeed. I could not find the ticket that tracks the actual segfaults, though. Any pointer?

#8 Updated by kytv almost 4 years ago

  • Related to Bug #9970: Seahorse may segfault during key synchronization added

#9 Updated by kytv almost 4 years ago

Just created #9970 for that.

#11 Updated by intrigeri over 3 years ago

I've fixed #9792 so this one isn't blocked by anything anymore, I think. Kill Your TV, is it realistic and a good idea that you complete this one by November 17, or should I instead ask anonym to deal with it as part of his #7563 sprint?

#12 Updated by kytv over 3 years ago

intrigeri wrote:

I've fixed #9792 so this one isn't blocked by anything anymore, I think. Kill Your TV, is it realistic and a good idea that you complete this one by November 17, or should I instead ask anonym to deal with it as part of his #7563 sprint?

IIRC this should be a quick fix/change. I'll look at it tonight and confirm whether it is a quick task (and just do it if I'm not mistaken).

#13 Updated by intrigeri over 3 years ago

I'll look at it tonight and confirm whether it is a quick task (and just do it if I'm not mistaken).

Great, thanks.

#14 Updated by kytv over 3 years ago

intrigeri wrote:

I'll look at it tonight and confirm whether it is a quick task (and just do it if I'm not mistaken).

Great, thanks.

I've not been able to get the network working in feature/jessie with an iso built from a3b86ad. I'm booting the iso in a libvirt-managed KVM session. Neither ifconfig -a nor ip link show anything other than the device lo.

The virtual ethernet adapter is visible in the lspci output.

(I'm not 100% sure that it's not my problem. Maybe 99.9% sure.)

#15 Updated by kytv over 3 years ago

kytv wrote:

(I'm not 100% sure that it's not my problem. Maybe 99.9% sure.)

I created #10522 for this.

#16 Updated by kytv over 3 years ago

This has mostly been ported to Jessie, other than the failure modes. (I forgot that much of this was done back in July).

#17 Updated by kytv over 3 years ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from kytv to anonym
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to kytv/test/9791-seahorse-jessie

Most of this work was originally done under feature/jessie and then backported to stable for #9095. After that it was merged here.

As I wrote there (#9095) this has been incredibly robust1 without any failures after running it in a while loop with --pause-on-fail.

1 On my hardware…

#18 Updated by intrigeri over 3 years ago

  • Assignee changed from anonym to kytv
  • QA Check changed from Ready for QA to Dev Needed

I had a very quick initial look, here are a few comments (mostly about coding style and naming):

  • please make keyid's name clearer (it was good enough in a local context, but with a broader scope it's not)
  • Does GnomeCloseButton.png really imply that the error we've seen was communication with the keyserver? It's troubling that we're using that specific an exception class here, while the function's name (check_for_seahorse_error) is much more generic.
  • Please pass the argument to start_or_restart_seahorse by name.
  • typo in "mesasge"
  • The act_on_change_of_seahorse_status name seems surprising to me, given what the function actually does.

#19 Updated by kytv over 3 years ago

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

The applicable changes were made in #9095 then merged here.

intrigeri wrote:

I had a very quick initial look, here are a few comments (mostly about coding style and naming):

  • please make keyid's name clearer (it was good enough in a local context, but with a broader scope it's not)

Attempt at addressing this in c3b1ded142f018bfc803921ce814a4b9a087dd7b

  • Does GnomeCloseButton.png really imply that the error we've seen was communication with the keyserver? It's troubling that we're using that specific an exception class here, while the function's name (check_for_seahorse_error) is much more generic.

Yes, I can't foresee any error being generated by Seahorse during these steps which isn't a network error.

  • Please pass the argument to start_or_restart_seahorse by name.

623da18bd289e9c792c7e0978761c16d92adf94f

  • typo in "mesasge"

4a1058bfb44f3d0a4343fd6f43998c5fcc1573a8

  • The act_on_change_of_seahorse_status name seems surprising to me, given what the function actually does.

Made a bit more generic in 1b3576e07b7e89917c474fac606424d6de814988 (In an early version of this changeset the function only monitored seahorse but I obviously neglected to change the function name when that behaviour changed as well).

#20 Updated by intrigeri over 3 years ago

  • Related to Bug #9046: Update the encryption test for Jessie added

#22 Updated by intrigeri over 3 years ago

  • Assignee changed from anonym to intrigeri

#23 Updated by intrigeri over 3 years ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

#24 Updated by intrigeri over 3 years ago

  • Status changed from Fix committed to Resolved
  • Assignee deleted (intrigeri)
  • Target version changed from Tails_1.8 to Tails_2.0
  • QA Check changed from Ready for QA to Pass

Also available in: Atom PDF