Project

General

Profile

Feature #9717

Bug #7552: Firefox extension to automatically verify the ISO checksum

Feature #8566: Web prototype of "download and verify" page

Extension: Clarify what happens if download is interrupted

Added by sajolida almost 4 years ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Installation
Target version:
Start date:
07/09/2015
Due date:
% Done:

100%

QA Check:
Feature Branch:
Type of work:
User interface design
Blueprint:
Starter:
Affected tool:
ISO Verification Extension

Description

In the latest wireframe, the idea now is to force people to download the ISO image through the extension, so the extension should enforce finishing the download before starting the verification. See https://labs.riseup.net/code/attachments/download/764/extension-20150505.fodg.

But we didn't clarify what happens from a user point of view if the download gets interrupted (lost connection).

extension-20150828-resume.png View (9.01 KB) sajolida, 08/28/2015 08:49 AM

History

#1 Updated by sajolida over 3 years ago

  • File extension-20150828-resume.pdf added
  • Assignee changed from sajolida to ma1
  • QA Check set to Ready for QA

Here is a mockup for this screen. That would be page 12 of the full wireframe on https://labs.riseup.net/code/attachments/download/921/extension-20150828.fodg.

Tchou and Maone, do you think that would work?

For the sake of simplicity, the idea here is to only allow people to resume the download if the download is interrupted while the tab is open. If you close the browser or shutdown the computer, then you have to start again from the beginning. Maybe we can internally force using a different mirror when resuming.

#2 Updated by sajolida over 3 years ago

  • File deleted (extension-20150828-resume.pdf)

#4 Updated by ma1 over 3 years ago

sajolida wrote:

Here is a mockup for this screen. That would be page 12 of the full wireframe on https://labs.riseup.net/code/attachments/download/921/extension-20150828.fodg.

Tchou and Maone, do you think that would work?

It looks good to me.

#5 Updated by sajolida over 3 years ago

  • Assignee changed from ma1 to tchou
  • Target version set to Tails_1.7
  • QA Check changed from Ready for QA to Dev Needed

Tchou: you'll be working on that code soon, can you check whether we need to adjust the HTML to this?

#6 Updated by tchou over 3 years ago

  • Assignee changed from tchou to sajolida

I updated the code in web/9385-download-and-verify-css

#7 Updated by sajolida over 3 years ago

  • QA Check changed from Dev Needed to Ready for QA

#8 Updated by sajolida over 3 years ago

  • Priority changed from Normal to Elevated
  • Target version changed from Tails_1.7 to Tails_1.8

#9 Updated by sajolida over 3 years ago

  • Priority changed from Elevated to Normal

#10 Updated by sajolida over 3 years ago

  • Assignee changed from sajolida to tchou
  • QA Check changed from Ready for QA to Dev Needed

#11 Updated by tchou over 3 years ago

  • Assignee changed from tchou to ma1

It's not working, some issues:

TEST
1 - I download
2 - I lose connection (manualy with network manager)
3 - a few second the the progress bar stops
4 - I have a "retry" and a "The download of the ISO image failed! Please check your network connection and try to resume" message
5 - I click on "retry" and go to blank page (I don't have connection)
6 - I enable the connection and reload the page
7 - I am on the "use ff extension" step
8 - I click on "use"
9 - I click on the "download button" (the extension does not remember the state)
10 - nothing happend (it' like the "save" had no consequences)
11 - a few second later: the verification has been done

If I enable the network after the "retry" message appears, I go back on the "retry" state and nothing happend, if I clic on "retry" and go back to the same state again and again.

SUGGESTIONS
- I think that the "retry" should prevent to reload the page if there is no connectivity (or reload something in ajax).
- We should find the same state than before reloading the page ("retry" and the message)
- Retry sould resume the download (but maybe I don't get the difference between retry and resume). Maybe we sould have the resume button ?

#12 Updated by sajolida over 3 years ago

  • Target version changed from Tails_1.8 to Tails_2.0

#13 Updated by ma1 over 3 years ago

  • Assignee changed from ma1 to tchou
  • QA Check changed from Dev Needed to Ready for QA

tchou wrote:

SUGGESTIONS
- I think that the "retry" should prevent to reload the page if there is no connectivity (or reload something in ajax).

Retry does not reload the page anymore, it just restarts the download process.

- We should find the same state than before reloading the page ("retry" and the message)

We do at this moment, as far as I can tell, even across add-on updates/installations

- Retry sould resume the download (but maybe I don't get the difference between retry and resume). Maybe we sould have the resume button ?

Retry starts from scratch, while resume resumes. You've got one or the other depending whether the download is actually resumable or not (at this moment there's a Firefox bug preventing it from being resumable in Tails upon network disconnections, but I might have found a work-around -- stay tuned).

#14 Updated by tchou over 3 years ago

  • Assignee changed from tchou to ma1
  • QA Check changed from Ready for QA to Info Needed

ma1 wrote:

tchou wrote:

SUGGESTIONS
- I think that the "retry" should prevent to reload the page if there is no connectivity (or reload something in ajax).

Retry does not reload the page anymore, it just restarts the download process.

ok.

- Retry sould resume the download (but maybe I don't get the difference between retry and resume). Maybe we sould have the resume button ?

Retry starts from scratch, while resume resumes. You've got one or the other depending whether the download is actually resumable or not (at this moment there's a Firefox bug preventing it from being resumable in Tails upon network disconnections, but I might have found a work-around -- stay tuned).

Ok. I got it. So you agree that it's possible that the download goes in a "paused/resume" mode without a user action (we where wondering to keep or not the .download-message-paused div).

#15 Updated by tchou over 3 years ago

I have a bug but it's not happegin everytime:
- it's downloading
- I click pause
- I reload the page
- I come back to "use firefox addon" and click "use"
- When I click after on "download", it's not downloading the button stay in its state "download Tail 1.8 ..."
- When it happend, I must disable/enable the addon to download again.

But sometimes the download is starting...

#16 Updated by ma1 over 3 years ago

tchou wrote:

- it's downloading
- I click pause
- I reload the page
- I come back to "use firefox addon" and click "use"
- When I click after on "download", it's not downloading the button stay in its state "download Tail 1.8 ..."
- When it happend, I must disable/enable the addon to download again.

But sometimes the download is starting...

Which browser / OS? unfortunately some of these bugs are very specific to Tor Browser/Tails, so it's important to know.
Regarding making the Tor disconnection-reconnection cause the download to be paused, rather than broken, that's exactly what I'm trying to do with my work-around which patches Firefox's download manager on the fly, and which I hope to push later today.

#17 Updated by ma1 over 3 years ago

tchou wrote:

I have a bug but it's not happegin everytime:
- it's downloading
- I click pause
- I reload the page
- I come back to "use firefox addon" and click "use"
- When I click after on "download", it's not downloading the button stay in its state "download Tail 1.8 ..."
- When it happend, I must disable/enable the addon to download again.

But sometimes the download is starting...

This should be fixed in current, 0.2.7rc32 on AMO and in git.
IIRC you filed a separate issue about it, but I cannot find it :(
Thanks!

#18 Updated by tchou over 3 years ago

  • QA Check changed from Info Needed to Dev Needed

It's not (on https://maone.net/dev/tails/download.html, FF38.5.2, DAVE 0.2.7rc32 ):
- it's downloading
- I click pause
- I reload the page
- All the DAVE things are gone
To find it again, I have to disable/enable DAVE.

#19 Updated by tchou over 3 years ago

IIRC you filed a separate issue about it, but I cannot find it :(

I think it's this one: #10902
I tried to find a way to solv it myself, but I think I can't.

#20 Updated by ma1 over 3 years ago

  • Status changed from Confirmed to Fix committed
  • QA Check changed from Dev Needed to Ready for QA

Should be fixed in 0.2.7rc37

#21 Updated by ma1 over 3 years ago

  • % Done changed from 0 to 100

#22 Updated by sajolida over 3 years ago

  • Assignee changed from ma1 to tchou

Assigning to tchou for review then.

#23 Updated by tchou over 3 years ago

  • Status changed from Fix committed to Resolved
  • Assignee deleted (tchou)

Seems OK :)

#24 Updated by intrigeri about 1 year ago

  • QA Check deleted (Ready for QA)

Also available in: Atom PDF