Project

General

Profile

Feature #9684

Feature #6196: Build all active branches

Feature #6090: Automated builds

Bug #9682: Upstream our changes in puppet-jenkins

Upstream our changes to the puppet-archive module

Added by bertagaz almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Continuous Integration
Target version:
Start date:
07/04/2015
Due date:
% Done:

100%

QA Check:
Feature Branch:
puppet-jenkins:features/9618-stronger_plugin_verification
Type of work:
Sysadmin
Blueprint:
Starter:
No
Affected tool:

Description

In order to have our feature/stronger_plugin_verification branch of the puppet-Jenkins module proposed upstream, we first need to upstream our features/file_owner_and_mode_support branch of the puppet-archive module that it depends on.

A similar patch has already been proposed to the upstream

Once merged, we'll have to update our puppet-archive module to the latest upstream and then adapt our puppet-jenkins branch if needed.


Related issues

Duplicated by Tails - Feature #9619: Upstream our changes to the puppet-archive module. Duplicate

History

#1 Updated by bertagaz almost 4 years ago

  • Parent task set to #9682

#2 Updated by bertagaz almost 4 years ago

This ticket is replacing the unusable #9619 ticket.

#3 Updated by intrigeri almost 4 years ago

This ticket is replacing the unusable #9619 ticket.

... but #9619 is still open.

#4 Updated by bertagaz almost 4 years ago

Same answer as for #9683 :)

#5 Updated by bertagaz almost 4 years ago

  • Assignee changed from bertagaz to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to puppet-jenkins:features/9618-stronger_plugin_verification

I've updated our puppet-archive module to the latest 0.8.0 tag which contains the $user parameter support.

I've adapted the related puppet-jenkins branch to use this new puppet-archive module.

I've installed several Jenkins plugins since then and it works fine. I think this branch is ready to ask for a merge upstream.

Beware that I had to rewrite our puppet-jenkins module history quite a bit since last week, as well as the Lizard manifest. The live deployment was not that easy in the end.

#6 Updated by bertagaz almost 4 years ago

  • % Done changed from 0 to 50

#8 Updated by intrigeri almost 4 years ago

  • Duplicated by Feature #9619: Upstream our changes to the puppet-archive module. added

#9 Updated by intrigeri almost 4 years ago

  • Assignee changed from intrigeri to bertagaz

I've updated our puppet-archive module to the latest 0.8.0 tag which contains the $user parameter support.
I've adapted the related puppet-jenkins branch to use this new puppet-archive module.
I've installed several Jenkins plugins since then and it works fine.

Yay! So this ticket can be closed since we don't need any change upstream in the archive module anymore, right? If my understanding is correct, then just mark it as resolved :)

I think this branch is ready to ask for a merge upstream.

Cool. Assuming "this branch" is puppet-jenkins:features/9618-stronger_plugin_verification, then that should be tracked in another subtask of #9682, since it's not about upstreaming changes to the archive plugin, right?

#10 Updated by bertagaz almost 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (bertagaz)
  • % Done changed from 50 to 100
  • QA Check deleted (Ready for QA)

intrigeri wrote:

I've updated our puppet-archive module to the latest 0.8.0 tag which contains the $user parameter support.
I've adapted the related puppet-jenkins branch to use this new puppet-archive module.
I've installed several Jenkins plugins since then and it works fine.

Yay! So this ticket can be closed since we don't need any change upstream in the archive module anymore, right? If my understanding is correct, then just mark it as resolved :)

Done.

I think this branch is ready to ask for a merge upstream.

Cool. Assuming "this branch" is puppet-jenkins:features/9618-stronger_plugin_verification, then that should be tracked in another subtask of #9682, since it's not about upstreaming changes to the archive plugin, right?

Yes, but to be honest I thought this task/branch could as well be tracked with #9682 itself. Or would that be too messy for you?

#11 Updated by intrigeri almost 4 years ago

I think this branch is ready to ask for a merge upstream.

Cool. Assuming "this branch" is
puppet-jenkins:features/9618-stronger_plugin_verification, then that should be
tracked in another subtask of #9682, since it's not about upstreaming changes to
the archive plugin, right?

Yes, but to be honest I thought this task/branch could as well be tracked with #9682 itself. Or would that be too messy for you?

Works for me, as long as it's clear on #9682 what's the next thing to do :)

#12 Updated by intrigeri almost 4 years ago

  • Subject changed from Upstream our changes to the puppet-archive module. to Upstream our changes to the puppet-archive module

Also available in: Atom PDF