Project

General

Profile

Bug #9258

Feature #5330: Test suite: identify and document race conditions

Accessing systray icons in the test suite is fragile

Added by kytv over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
04/18/2015
Due date:
% Done:

100%

Feature Branch:
kytv:bugfix/9258-systray-is-ready
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description


Related issues

Related to Tails - Feature #5632: Test suite: more robust encryption feature Resolved
Blocks Tails - Bug #9095: Seahorse tests lack robustness Resolved 05/05/2015

Associated revisions

Revision 8aaaab82 (diff)
Added by kytv over 4 years ago

Wait for systray icons to finish loading

When restoring snapshots in the test suite we'll wait for the for the
Florence icon to be displayed in the system tray to ensure that the
icons won't shift positions because another application icon was added
to the system tray.

Once the icon for Florence Virtual Keyboard has loaded, the only icon
left to load is Vidalia. Vidalia's loading will not cause the other
systray icons to shift positions.

Will-fix: #9258

Revision 4a77aed2
Added by anonym over 4 years ago

Merge remote-tracking branch 'kytv/bugfix/9258-systray-is-ready' into testing

Conflicts:
features/step_definitions/common_steps.rb

Fix-committed: #9258

History

#1 Updated by kytv over 4 years ago

  • Blocks Bug #9095: Seahorse tests lack robustness added

#2 Updated by kytv over 4 years ago

  • Status changed from New to In Progress

#3 Updated by kytv over 4 years ago

We want to wait until all of the systray icons have loaded before trying to interact with any of the icons in the systray. Otherwise, Sikuli may try clicking gpgApplet, for example, but if the systray is still being filled it could end up clicking something else entirely such as the notification icon or the volume control.

#4 Updated by kytv over 4 years ago

  • Parent task set to #5330

#5 Updated by kytv over 4 years ago

  • Subject changed from Accessing the gpgApplet in the test suite is fragile to Accessing systray icons in the test suite is fragile

Even though we currently only access gpgApplet all systray icon handling would be fragile.

#6 Updated by kytv over 4 years ago

  • Related to Feature #5632: Test suite: more robust encryption feature added

#7 Updated by kytv over 4 years ago

  • Assignee changed from kytv to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:bugfix/9258-systray-is-ready

#8 Updated by anonym over 4 years ago

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 20
  • QA Check changed from Ready for QA to Dev Needed

IMHO the correct place to put the code isn't restore_background(). It's conceivable that systray interaction is done before saving/restoring the background snapshot, and scenarios without any snapshot at all are already existing.

I think we should replace the GNOME has started step with with the Tails desktop is ready step, which does what GNOME has started does and what you added to restore_background(). And more things, later on, as we come up with them. So I wouldn't mind a sed -i 's,GNOME has started,the Tails desktop is ready,g' $(git grep -l "GNOME has started").

#9 Updated by kytv over 4 years ago

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

Suggestions done, rewritten, and force pushed.

#10 Updated by kytv over 4 years ago

#11 Updated by anonym over 4 years ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 20 to 100

#12 Updated by anonym over 4 years ago

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#13 Updated by intrigeri over 4 years ago

Blocks: #8538

(Let's see if that's been fixed by some Redmine upgrade.)

#15 Updated by BitingBird over 4 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF