Project

General

Profile

Feature #9171

Refactor tails-custom-apt-sources and tails-diff-suite duplicated code

Added by intrigeri over 4 years ago. Updated over 4 years ago.

Status:
Confirmed
Priority:
Normal
Assignee:
-
Category:
Build system
Target version:
-
Start date:
04/07/2015
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

After #8654, we'll have two implementations of e.g. branch_name_to_suite in two places. The logic of "what APT suite is used at build time for a given branch" is kinda duplicated too. Ideally, we should a single implementation, that both programs would use. It's not trivial since they're run in very different contexts. I see two main options:

  1. Have tails-diff-suites to load and run that shared code from the Git repository it's using to find out the base branch etc. -- it's ugly but doable, and then the question is: from which branch?
  2. Put the shared implementation elsewhere. We could e.g. put it into our upcoming pythonlib or the existing perl5lib, but in both cases this adds a dependency to the ISO build system. Something like #7036 could help manage such build-dependencies, by the way.

Both seem a bit too heavy to integrate into the already pretty radical #8654, so I'm saving it for later.


Related issues

Related to Tails - Feature #7036: Move custom software to main git repo In Progress

History

#1 Updated by intrigeri over 4 years ago

  • Related to Feature #7036: Move custom software to main git repo added

#2 Updated by intrigeri over 4 years ago

  • Description updated (diff)

Also available in: Atom PDF