Project

General

Profile

Bug #8830

Buggy passed-through argument quoting in connect-socks, totem, wget and whois wrappers

Added by intrigeri almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
02/02/2015
Due date:
% Done:

100%

Feature Branch:
bugfix/quote-wrappers-arguments
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Some of those are regressions in the devel branch, hence the Elevated priority.


Related issues

Blocks Tails - Bug #8603: Unexpected redirection while sending Host header with wget Resolved 01/07/2015

Associated revisions

Revision e0c57b18 (diff)
Added by Tails developers almost 5 years ago

Always pass arguments through wrappers with "$@".

$* doesn't handle arguments with e.g. embedded spaces correctly. The only safe
way to do so is "$@". We know that, but for some reason we've been cargo-culting
and copy-pasting an old buggy wrapper for years, apparently.

Will-Fix: #8603, #8830

Revision f53aec8e
Added by Tails developers almost 5 years ago

Merge branch 'bugfix/quote-wrappers-arguments' into devel

Fix-committed: #8603, #8830

History

#1 Updated by intrigeri almost 5 years ago

  • Blocks Bug #8603: Unexpected redirection while sending Host header with wget added

#2 Updated by Tails almost 5 years ago

Applied in changeset commit:009a35821f512ae161b972d2344d7c811722edd1.

#3 Updated by intrigeri almost 5 years ago

  • Assignee changed from intrigeri to bertagaz
  • % Done changed from 20 to 50
  • QA Check set to Ready for QA

#4 Updated by Tails almost 5 years ago

  • Status changed from In Progress to 11
  • % Done changed from 50 to 100

Applied in changeset commit:c73d1df140c6840ea04c4e992c150b034351c2b5.

#5 Updated by bertagaz almost 5 years ago

  • Assignee deleted (bertagaz)
  • QA Check changed from Ready for QA to Pass

#6 Updated by BitingBird almost 5 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF