Project

General

Profile

Bug #8752

I2P Browser includes Torbutton

Added by sajolida about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
01/20/2015
Due date:
% Done:

100%

Feature Branch:
kytv:bugfix/8752-remove-torbutton-button-from-i2pbrowser
Type of work:
Code
Blueprint:
Starter:
Affected tool:
I2P

Description

I2P Browser includes and displays in its toolbar the Torbutton extension. I bet that this could be confusing...


Related issues

Related to Tails - Bug #8893: I2P Browser configuration includes Torbutton settings Resolved 02/12/2015

Associated revisions

Revision f4d1fdd5
Added by Tails developers almost 5 years ago

Merge remote-tracking branch 'kytv/bugfix/8752-remove-torbutton-button-from-i2pbrowser' into devel

Fix-committed: #8752

History

#1 Updated by intrigeri about 5 years ago

  • Assignee set to kytv

#2 Updated by kytv about 5 years ago

  • Assignee changed from kytv to intrigeri
  • QA Check set to Info Needed

TorButton added by anonym's suggestion (see https://mailman.boum.org/pipermail/tails-dev/2014-September/007052.html).

commit d264cc9 Switch I2P-Browser from Iceweasel to Tor-Browser

Why not installing Torbutton too, and configuring it to use I2P instead?
I imagine the protections it adds also make sense for I2P? If so, this
is a regression (in terms of "security") from the FoxyProxy-way of doing
this.

How should this ticket be resolved?

1. remove the TorButton addon
2. remove the TorButton button from the toolbar
3. leave things as they currently are
4. $some_other_option

#3 Updated by intrigeri about 5 years ago

TorButton added by anonym's suggestion (see https://mailman.boum.org/pipermail/tails-dev/2014-September/007052.html).

Ah, indeed.

How should this ticket be resolved?

1. remove the TorButton addon
2. remove the TorButton button from the toolbar
3. leave things as they currently are
4. $some_other_option

Assuming we still want Torbutton as "the protections it adds also make sense for I2P", the solution 2 seems to be the best.

#4 Updated by BitingBird about 5 years ago

  • Assignee changed from intrigeri to kytv
  • QA Check deleted (Info Needed)

#5 Updated by kytv almost 5 years ago

  • Assignee deleted (kytv)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:bugfix/8752-remove-torbutton-button-from-i2pbrowser

intrigeri wrote:

TorButton added by anonym's suggestion (see https://mailman.boum.org/pipermail/tails-dev/2014-September/007052.html).

Ah, indeed.

How should this ticket be resolved?

1. remove the TorButton addon
2. remove the TorButton button from the toolbar
3. leave things as they currently are
4. $some_other_option

Assuming we still want Torbutton as "the protections it adds also make sense for I2P", the solution 2 seems to be the best.

The simple change in this commit will hide the button from the toolbar.

#6 Updated by anonym almost 5 years ago

  • Assignee set to anonym
  • Target version set to Tails_1.3

#7 Updated by Tails almost 5 years ago

  • Status changed from Confirmed to 11
  • % Done changed from 50 to 100

Applied in changeset commit:fc4762a9b8fe0db34f8742f33d462461cd434b65.

#8 Updated by anonym almost 5 years ago

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#9 Updated by intrigeri almost 5 years ago

  • Related to Bug #8893: I2P Browser configuration includes Torbutton settings added

#10 Updated by BitingBird almost 5 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF