Unable to clone Git repositories over HTTPS
The tests created for #8669 (not yet publicly available) do not pass in the devel branch. They pass in stable. The command
git clone https://github.com/tails-developers/testing-dummy fails with a "cannot connect to host" error.
Torify Git with tsocks, instead of setting GIT_PROXY_COMMAND (Will-Fix: #8680).
GIT_PROXY_COMMAND is taken into account for git:// and Git over SSH, but not for
Git over HTTPS. The latter use to work when we were shipping Polipo, probably
thanks to the HTTP_PROXY environment variable and friends. Now it's broken.
Here, we're dropping usage of GIT_PROXY_COMMAND, and replacing it with a tsocks
Note: it would be nicer to use torsocks in this wrapper, which would work for
git:// and HTTPS, but it would break Git over SSH, since in Tails SSH has its
own ProxyCommand set to connect-socks, and then torsocks would block connections
initiated by connect-socks to the Tor SOCKS proxy, on the ground that they're
aimed at localhost and thus might be DNS requests.
#8 Updated by intrigeri almost 5 years ago
We should test Git://, SSH and HTTP both on the open Internet, and hidden services.
Right. (Note that as far as this ticket is concerned, we should only look for regressions compared to 1.2.3: any other problem will be for another ticket, and should not block merging this one.)
#10 Updated by bertagaz almost 5 years ago
- Assignee changed from bertagaz to intrigeri
- QA Check changed from Ready for QA to Dev Needed
#11 Updated by intrigeri almost 5 years ago
It looks good, except I think we're doing the same mistake that lead to #8603 and
#8830, regarding using `$*` rather than `$@` to pass arguments in the git wrapper
You probably mean:
rather that "$@"
... and then indeed, you're fully right. Fixed in the branch. I didn't bother testing as it seems trivial enough and you'll have to do a whole bunch of tests on it anyway.