Project

General

Profile

Bug #8680

Unable to clone Git repositories over HTTPS

Added by kytv about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
01/12/2015
Due date:
% Done:

100%

Feature Branch:
bugfix/8680-git-without-polipo
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

The tests created for #8669 (not yet publicly available) do not pass in the devel branch. They do pass in stable. The command git clone https://github.com/tails-developers/testing-dummy fails with a "cannot connect to host" error.

Associated revisions

Revision 3922b0b2 (diff)
Added by Tails developers about 5 years ago

Torify Git with tsocks, instead of setting GIT_PROXY_COMMAND (Will-Fix: #8680).

GIT_PROXY_COMMAND is taken into account for git:// and Git over SSH, but not for
Git over HTTPS. The latter use to work when we were shipping Polipo, probably
thanks to the HTTP_PROXY environment variable and friends. Now it's broken.

Here, we're dropping usage of GIT_PROXY_COMMAND, and replacing it with a tsocks
wrapper.

Note: it would be nicer to use torsocks in this wrapper, which would work for
git:// and HTTPS, but it would break Git over SSH, since in Tails SSH has its
own ProxyCommand set to connect-socks, and then torsocks would block connections
initiated by connect-socks to the Tor SOCKS proxy, on the ground that they're
aimed at localhost and thus might be DNS requests.

Revision f6473a17
Added by Tails developers almost 5 years ago

Merge branch 'bugfix/8680-git-without-polipo' into devel

Fix-committed: #8680

History

#1 Updated by intrigeri about 5 years ago

  • Subject changed from Unable to clone git repositories over HTTPS to Unable to clone Git repositories over HTTPS

#2 Updated by intrigeri about 5 years ago

So apparently, GIT_PROXY_COMMAND is taken into account for git:// and SSH connections, but not for HTTPS. Interesting. Looking into that further.

#3 Updated by Tails about 5 years ago

  • Status changed from Confirmed to In Progress

Applied in changeset commit:f736306c004e8bc5bbb1b29e599845da6555e35d.

#4 Updated by intrigeri about 5 years ago

  • Feature Branch set to bugfix/8680-git-without-polipo

#5 Updated by Tails about 5 years ago

Applied in changeset commit:c81d8d683844520c8e476cc9bc24418bd497391b.

#6 Updated by intrigeri about 5 years ago

  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

#7 Updated by anonym almost 5 years ago

We should test Git://, SSH and HTTP both on the open Internet, and hidden services.

#8 Updated by intrigeri almost 5 years ago

We should test Git://, SSH and HTTP both on the open Internet, and hidden services.

Right. (Note that as far as this ticket is concerned, we should only look for regressions compared to 1.2.3: any other problem will be for another ticket, and should not block merging this one.)

#9 Updated by bertagaz almost 5 years ago

  • Assignee set to bertagaz

#10 Updated by bertagaz almost 5 years ago

  • Assignee changed from bertagaz to intrigeri
  • QA Check changed from Ready for QA to Dev Needed

It looks good, except I think we're doing the same mistake that lead to #8603 and #8830, regarding using `$*` rather than `$@` to pass arguments in the git wrapper (config/chroot_local-includes/usr/local/bin/git).

#11 Updated by intrigeri almost 5 years ago

It looks good, except I think we're doing the same mistake that lead to #8603 and
#8830, regarding using `$*` rather than `$@` to pass arguments in the git wrapper
(config/chroot_local-includes/usr/local/bin/git).

You probably mean:

rather that "$@" 

... and then indeed, you're fully right. Fixed in the branch. I didn't bother testing as it seems trivial enough and you'll have to do a whole bunch of tests on it anyway.

#12 Updated by intrigeri almost 5 years ago

  • Assignee changed from intrigeri to bertagaz
  • QA Check changed from Dev Needed to Ready for QA

#13 Updated by Tails almost 5 years ago

  • Status changed from In Progress to 11
  • % Done changed from 50 to 100

Applied in changeset commit:1e240fbd5ed13d47b14a665f978df71eaa8b976a.

#14 Updated by bertagaz almost 5 years ago

  • Assignee deleted (bertagaz)
  • QA Check changed from Ready for QA to Pass

Tested with last changes on devel (merge of #8603 and #8830), was able to clone with git,ssh,http andd htpps.

#15 Updated by BitingBird almost 5 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF