Project

General

Profile

Bug #8454

Bug #8274: liveusb-creator's gdisk scripts returns error in Jessie

Test gdisk minimal fix for Jessie

Added by intrigeri almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
Installation
Target version:
Start date:
12/18/2014
Due date:
03/05/2015
% Done:

100%

Feature Branch:
Type of work:
Test
Blueprint:
Starter:
Affected tool:

Description

#8274-note-4

gdisk.debdiff (4.35 KB) u, 03/04/2015 04:49 PM


Related issues

Blocks Tails - Bug #8455: Have gdisk fixed in Jessie Resolved 12/18/2014

History

#1 Updated by intrigeri almost 5 years ago

  • Blocks Bug #8455: Have gdisk fixed in Jessie added

#2 Updated by anonym almost 5 years ago

The "minimal fix" can be found in #8274#note-4.

#3 Updated by u almost 5 years ago

  • Assignee changed from anonym to u

#4 Updated by u over 4 years ago

  • % Done changed from 0 to 10

I've patched the source and am testing it.

#5 Updated by BitingBird over 4 years ago

  • Status changed from Confirmed to In Progress

#6 Updated by u over 4 years ago

Waiting for a working Jessie ISO image, I'll be on it again in about 2 days.

#7 Updated by intrigeri over 4 years ago

  • Target version changed from Tails_2.0 to Tails_1.3.2

This needs to be fixed in Jessie soon, otherwise we'll have to workaround it in nasty ways in our Installer.

#8 Updated by intrigeri over 4 years ago

  • Due date set to 03/05/2015

#9 Updated by u over 4 years ago

Ok, here is what I did. I hope that's enough testing:

I ran this deletion of the MBR before each test:

gdisk /dev/sdb
GPT fdisk (gdisk) version 0.8.10

Partition table scan:
  MBR: protective
  BSD: not present
  APM: not present
  GPT: present

Found valid GPT with protective MBR; using GPT.

Command (? for help): x
Expert command (? for help): z

About to wipe out GPT on /dev/sdb. Proceed? (Y/N): y
GPT data structures destroyed! You may now partition the disk using fdisk or
other utilities.
Blank out MBR? (Y/N): y

then with Jessie's gdisk, 0.8.10-1, writing a new GPT MBR:

gdisk /dev/sdb
GPT fdisk (gdisk) version 0.8.10

Partition table scan:
  MBR: not present
  BSD: not present
  APM: not present
  GPT: not present

Creating new GPT entries.

Command (? for help): o
This option deletes all partitions and creates a new protective MBR.
Proceed? (Y/N): y
Command (? for help): w
Do you want to proceed? (Y/N): y
OK; writing new GUID partition table (GPT) to /dev/sdb.
The operation has completed successfully.

Exit code:
# echo $?
1

now using a package I built with the patches from the relevant commit i get:

gdisk /dev/sdb

GPT fdisk (gdisk) version 0.8.10

Partition table scan:
  MBR: not present
  BSD: not present
  APM: not present
  GPT: not present

Creating new GPT entries.

Command (? for help): o
This option deletes all partitions and creates a new protective MBR.
Proceed? (Y/N): y
Command (? for help): w
Final checks complete. About to write GPT data. THIS WILL OVERWRITE EXISTING
PARTITIONS!!
Do you want to proceed? (Y/N): y
OK; writing new GUID partition table (GPT) to /dev/sdb.
The operation has completed successfully.

Exit code:
# echo $?       
0

#10 Updated by u over 4 years ago

here is the debdiff, feel free to do whatever needs to be done with it.

#11 Updated by u over 4 years ago

  • QA Check set to Ready for QA

#12 Updated by intrigeri over 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 10 to 100
  • QA Check deleted (Ready for QA)

Thanks. I've built on top of that and written a reproducer script, that I've run on Wheezy, Jessie, and Jessie + the fix. You'll see the details on the Debian bug report that I've just sent.

Notes about the debdiff:

  • you imported in support.diff unrelated changes that we didn't mean to see tested, nor to even try to include in Jessie (hence the minimal in the ticket title, and the details are made clearer on #8274); thankfully that doesn't invalidate your results :)
  • a debdiff should generally not include any local quilt artifacts (the .pc directory), but instead be built using debdiff run against the old and new .dsc (although these days, git format-patch against the Vcs-Git is often preferred)

Cheers!

#13 Updated by BitingBird over 4 years ago

  • Target version changed from Tails_1.3.2 to Tails_1.3.1

Also available in: Atom PDF