Tails

At the moment all tests using Tor bridges (tor_bridges.feature and the latter half of times_syncting.feauter) are broken because this branch makes us use the Tor Launcher bundled in the Tor Browser tarball. As of Tor Browser 4.0.6 (which is what Tails use since 1.3.2) that's Tor Launcher 0.2.7.0.2 but we use Tor Launcher 0.2.7.2 since Tails 1.3.2, which changes the order of the pages in the wizard, hence the problems with the tests.

There are two ways to fix this so this branch can be merged:

• Temporarily reverting d899831 but then we'd have to revert that revert later, and live with a downgraded Tor Launcher.

• We split out 3710b2c and fc6667a (into a feature/WXYZ-use-tor-browsers-bundled-tor-launcher branch) and restore the in-tree Tor Launcher 0.2.7.2 until the Tor Browser bundles it (or a higher version) and then we merge those commits back. For instance, once we merge feature/9031-tor-browser-4.5 this won't be a problem since it installs Tor Launcher 0.2.7.3.

anonym wrote:

As of Tor Browser 4.0.6 (which is what Tails use since 1.3.2) that's Tor Launcher 0.2.7.0.2 but we use Tor Launcher 0.2.7.2 since Tails 1.3.2, which changes the order of the pages in the wizard, hence the problems with the tests.

I'm confused. Introducing the new Tor Launcher was precisely meant to fix discrepancies between Tails and Tor Browser, in that wizard (#8964), and as a result we have other discrepancies, so it feels like we've made a mistake along the way. Anyway, no big deal :)

There are two ways to fix this so this branch can be merged:

• Temporarily reverting d899831 but then we'd have to revert that revert later, and live with a downgraded Tor Launcher.

Kinda ugly, but acceptable.

• We split out 3710b2c and fc6667a (into a feature/WXYZ-use-tor-browsers-bundled-tor-launcher branch) and restore the in-tree Tor Launcher 0.2.7.2 until the Tor Browser bundles it (or a higher version) and then we merge those commits back. For instance, once we merge feature/9031-tor-browser-4.5 this won't be a problem since it installs Tor Launcher 0.2.7.3.

If we go this way, we could move these two commits to feature/9031-tor-browser-4.5, then mark #9031 as blocked by #7934, then merge feature/8925-tor-0.2.6, then merge devel into feature/9031-tor-browser-4.5, right? Given we're almost ready to move to Tor 0.2.6, I think I prefer this solution.