Project

General

Profile

Feature #7752

Add keyringer

Added by sajolida over 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
08/06/2014
Due date:
% Done:

100%

Feature Branch:
feature/7752-keyringer
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Being able to work on Tails from Tails is a supported user case. As more and more of our internal infrastructure uses keyringer, it should be added to Tails.

Note it is currently available for Jessie but not for Wheezy. Time to backport it?

Associated revisions

Revision 65a27f2a (diff)
Added by Tails developers almost 5 years ago

Add keyringer (Will-fix: #7752)

Revision cacc60a4 (diff)
Added by Tails developers almost 5 years ago

Document keyringer (Will-fix: #7752)

Revision e66e5858
Added by Tails developers almost 5 years ago

Merge branch 'feature/7752-keyringer' into devel

Fix-committed: #7752

History

#1 Updated by intrigeri over 5 years ago

our internal infrastructure uses keyringer, it should be added to Tails.

ACK.

Time to backport it?

I suspect the package from testing will work just fine on Wheezy.
If that's the case, then no backport is necessary.

#2 Updated by sajolida over 5 years ago

Yes, the versions from Jessie and sid works in Tails 1.1.

#3 Updated by sajolida over 5 years ago

  • Assignee set to sajolida
  • Target version set to Tails_1.3

#4 Updated by bertagaz about 5 years ago

Just tried to install keyringer on Tails 1.2.2, and it works fine.

So the patch is quite tiny, it's just a matter of adding the right line in the package list, unless I'm missing a subtility of this ticket.

#5 Updated by intrigeri about 5 years ago

So the patch is quite tiny, it's just a matter of adding the right line in the package list, unless I'm missing a subtility of this ticket.

+ update the features page, maybe mention it in the user doc, and maybe have Kill Your TV write automated tests for it.

#6 Updated by Tails almost 5 years ago

  • Status changed from Confirmed to In Progress

Applied in changeset commit:ad84dbc520d1acf0d7b57f9d6f1e6bd7b571411a.

#7 Updated by sajolida almost 5 years ago

  • Feature Branch set to feature/7752-keyringer

The code is working now, but I still have to write the documentation.

Unless the .keyringer folder is stored in persistence, you'd have to do keyringer $keyringer init $path each time Tails is started. A workaround would be to recommended using Dotfiles to store each of the configuration files from keyringer.

People using keyringer are comfortable with the command line so that sounds like a reasonable expectation for them.

#8 Updated by bertagaz almost 5 years ago

Agree, this feature is mostly targeted to power users and devs, so documenting to use the dotfile persistence setup sounds fine and enough to me.

Left to be discussed is having tests for this feature. I think this could be a new ticket with low priority, and not a blocker for this to be released.

#9 Updated by Tails almost 5 years ago

Applied in changeset commit:0a0828bd5dd6f8a94709035d3a7058e7c2099dde.

#10 Updated by sajolida almost 5 years ago

  • Assignee deleted (sajolida)
  • % Done changed from 0 to 70
  • QA Check set to Ready for QA

#11 Updated by bertagaz almost 5 years ago

  • Assignee set to bertagaz

#12 Updated by bertagaz almost 5 years ago

  • Assignee changed from bertagaz to sajolida
  • QA Check changed from Ready for QA to Info Needed

I've updated the branch to devel, and changed a bit of wording + add a precision about the keyringer git repo themselves to the doc in 9b2470b. Does these doc changes sound ok to you?

#13 Updated by intrigeri almost 5 years ago

Well, with these changes, there's more work needed again:

  • These changes introduce the "persitent directory" typo.
  • The "and share" change feels wrong, as keyringer open does not share anything by itself.
  • The s/across separate working sessions/accross sessions/ introduce an inconstency with how we phrase this elsewhere in our documentation. If you feel it's better, then please propose to change it everywhere instead.

#14 Updated by bertagaz almost 5 years ago

  • Assignee changed from sajolida to bertagaz
  • QA Check changed from Info Needed to Ready for QA

#15 Updated by bertagaz almost 5 years ago

will revert this changes then if they introduce mistakes. Not sure what the "separate working" precision brings though.

#16 Updated by intrigeri almost 5 years ago

will revert this changes then if they introduce mistakes. Not sure what the "separate working" precision brings though.

I think the concept of "session" is super vague => IMO the "working" word is needed to clarify it a bit. No opinion on "separate", though. Anyway, that's off-topic here, so I'll shut up :)

#17 Updated by bertagaz almost 5 years ago

  • Assignee changed from bertagaz to sajolida
  • QA Check changed from Ready for QA to Info Needed

Appart from the changes mentionned above by intrigeri, there is a last addition at the end of the documentation:

"You also need to check that your keyringer git repos (top-secret.git
in this case) are stored in a persitent directory."

I thought that the fact that users also need to take care of putting their keyringer git repos in a persistent directory was maybe worth mentioning, rather than being implicit. Shall I keep this change and drop the others?

#18 Updated by sajolida almost 5 years ago

  • Assignee deleted (sajolida)
  • % Done changed from 70 to 80
  • QA Check changed from Info Needed to Ready for QA

Ok, thanks for the additions. As intrigeri already explained I reverted to the usual formulation "separate working sessions". I agree that this is a bit verbose and could be improved but then let's apply this every where and be consistent. "Session" is to vague and I hoped that "separate" makes it clear that a reboot appears between the two.

Regarding "sharing", similarily keyringer doesn't "edit" documents but merely launches text editors. Still I think it make sense to describe to higher level feature, so I kept bertagaz's proposal.

Regarding the last sentence, I removed it. Let's assume that people knowing Git and ready to use the Dotfiles persistence feature already understood that Tails is amnesiac by default. Storing their repo in a persistent folder is not specific to keyringer (unlike the rest of that section).

So marking this as Ready for QA again.

#19 Updated by bertagaz almost 5 years ago

  • Assignee set to bertagaz

#20 Updated by Tails almost 5 years ago

  • Status changed from In Progress to 11
  • % Done changed from 80 to 100

Applied in changeset commit:bdaa1c387784159f414e4846ae44a57fa2605f66.

#21 Updated by bertagaz almost 5 years ago

  • Assignee deleted (bertagaz)
  • QA Check changed from Ready for QA to Pass

#22 Updated by BitingBird almost 5 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF