Project

General

Profile

Bug #7647

Hide Torbutton "Open Network Settings" menu entry when the Tor Launcher is not enabled

Added by dct over 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
07/23/2014
Due date:
% Done:

100%

Feature Branch:
feature/9031-tor-browser-4.5
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:
Browser

Description

Using latest Iceweasel (24.7.0). Not sure if this is for Tails or for upstream, but nothing happens when clicking "Open Network Settings" in the Torbutton menu item.


Related issues

Blocked by Tails - Feature #9031: Upgrade to Tor Browser 4.5 Resolved 03/26/2015

Associated revisions

Revision bcfece3f (diff)
Added by anonym over 4 years ago

Hide Torbutton's "Tor Network Settings..." context menu entry.

Will-fix: #7647

Revision 80b90665
Added by intrigeri over 4 years ago

Merge remote-tracking branch 'origin/feature/9031-tor-browser-4.5' into devel

Fix-committed: #9031, #8696, #8092, #7647

Conflicts:
config/chroot_local-hooks/10-tbb

History

#1 Updated by intrigeri over 5 years ago

  • Subject changed from Torbutton "Open Network Settings" to Hide Torbutton "Open Network Settings" menu entry
  • Status changed from New to Confirmed
  • Target version deleted (Tails_1.1.1)

I can reproduce this on 1.1 (+ some other branches, but should not be significant). I doubt that's a regression, so dropping the 1.1.1 target version. It works fine with the TBB 3.6.3, most likely by calling some Tor Launcher function.

The features that are offered there won't make any sense for Tails anyway, as our own Tor browser doesn't control Tor: only our Tor Launcher can do that, and we don't ship it as an extension in Tor browser, but run it as a dedicated user. And, we don't really support reconfiguring Tor once the Launcher has exited.

So, IMO, the only fix I can think of is to hide this menu entry. Ideally, we would upstream an option to hide it, or (better!) have Torbutton detect if the function that this menu entry starts is available, and only display it if that's the case. Retitling this ticket accordingly.

dct: you assigned this ticket to you. Does it mean you want to work on it? If so, then I think the first thing to do is to report a wishlist bug in the Tor browser's Trac, requesting the (second, better) solution described above. Providing a patch would help, I guess ;)

#2 Updated by dct over 5 years ago

I mistakenly assigned it to myself, apologies. I don't know how to provide the patch. I will try figure out how to report it in Tor browser's Trac....

#3 Updated by intrigeri over 5 years ago

  • Subject changed from Hide Torbutton "Open Network Settings" menu entry to Hide Torbutton "Open Network Settings" menu entry when the Tor Launcher is not enabled
  • Assignee deleted (dct)

#4 Updated by intrigeri about 5 years ago

  • Type of work changed from Upstream to Code

#5 Updated by intrigeri almost 5 years ago

  • Target version set to Tails_1.4

We can now hide this menu entry with an environment variable, so flagging for 1.4.

#6 Updated by anonym over 4 years ago

  • Assignee set to anonym

#7 Updated by anonym over 4 years ago

  • Status changed from Confirmed to In Progress

#8 Updated by anonym over 4 years ago

  • % Done changed from 0 to 40
  • Feature Branch set to feature/9031-tor-browser-4.5

anonym wrote:

Applied in changeset bcfece3f71a5ab6fb61a5b7dee93efa1919f30ba.

This was made in the feature/9031-tor-browser-4.5 branch.

#9 Updated by anonym over 4 years ago

#10 Updated by anonym over 4 years ago

  • Assignee deleted (anonym)
  • % Done changed from 40 to 50
  • QA Check set to Ready for QA

#11 Updated by intrigeri over 4 years ago

  • Status changed from In Progress to 11
  • % Done changed from 50 to 100

#12 Updated by BitingBird over 4 years ago

  • QA Check changed from Ready for QA to Pass

#13 Updated by BitingBird over 4 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF