Project

General

Profile

Bug #7450

Tails OpenPGP Applet is too easy to exit

Added by sajolida over 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
06/22/2014
Due date:
% Done:

100%

Feature Branch:
feature/7450-openpgp-applet-exit
Type of work:
Code
Blueprint:
Starter:
Yes
Affected tool:
OpenPGP Applet

Description

Doing a double right-click on the applet closes it. This is a bit too easy to exit and quite harder to restore.


Related issues

Related to Tails - Feature #7433: Turn Tails OpenPGP Applet into a standalone application Duplicate 06/22/2014
Related to Tails - Bug #8319: OpenPGP Applet: Add a confirmation dialog on exit Resolved 11/26/2014
Duplicated by Tails - Feature #8293: Add gpgApplet to the Applications menu Duplicate 11/23/2014

Associated revisions

Revision efa54ac8 (diff)
Added by nodens about 5 years ago

Invert Exit and About in gpgApplet context menu

This is a short-term workaround that will-fix: #7450 - Tails OpenPGP Applet is
too easy to exit. A double right-click doesn't exit the applet anymore.

Revision c284ad1f
Added by Tails developers almost 5 years ago

Merge branch 'feature/7450-openpgp-applet-exit' into devel

fix-committed: #7450

History

#1 Updated by intrigeri over 5 years ago

  • Related to Feature #7433: Turn Tails OpenPGP Applet into a standalone application added

#2 Updated by intrigeri over 5 years ago

  • Status changed from New to Confirmed
  • Type of work changed from User interface design to Code
  • Starter changed from No to Yes

Agreed. Turning this into a "Code" ticket, as just removing the "Exit" menu entry should be enough.

The code lives in config/chroot_local-includes/usr/local/bin/gpgApplet in the main Tails Git repository. It's written in Perl, but the fix is likely to be easy, even without prior knowledge of Perl.

#3 Updated by nodens over 5 years ago

How about just moving the Exit down (invert Exit & About) ? One might want to close the applet.

#4 Updated by nodens over 5 years ago

  • Assignee set to intrigeri
  • QA Check set to Info Needed

Note : I'll do it in the openpgp-applet repository, whether we choose to remove the exit menu or just move it.

#5 Updated by intrigeri over 5 years ago

One might want to close the applet.

In the context of Tails, I thought we should just remove the Exit menu entry (it's always possible to kill the process anyway). But, now that we have serious plans to upload this to Debian, I agree with you.

How about just moving the Exit down (invert Exit & About) ?

That would be a good short-term improvement, I think, but probably not a real solution. I suggest adding a confirmation dialog.

#6 Updated by intrigeri over 5 years ago

  • Assignee deleted (intrigeri)
  • QA Check deleted (Info Needed)

#7 Updated by sajolida over 5 years ago

How about just moving the Exit down (invert Exit & About) ? One might want to close the applet.

Yeap, I think that would work!

#8 Updated by intrigeri about 5 years ago

  • Duplicated by Feature #8293: Add gpgApplet to the Applications menu added

#9 Updated by nodens about 5 years ago

  • Assignee set to nodens

#10 Updated by nodens about 5 years ago

  • Status changed from Confirmed to In Progress
  • Assignee deleted (nodens)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

The short-term workaround is available in the bugfix/7450-too_easy_to_exit branch of nodens/openpgp-applet git repository, and should apply cleanly on current Tails' version.

https://git-tails.immerda.ch/nodens/openpgp-applet/commit/?h=bugfix/7450-too_easy_to_exit&id=a3aa1b67fce5ce25b726beeb4c2b7b7e87736c59

The longer-term solution (confirmation dialog) is quite easy to implement, but I'm unsure how to proceed, as current Tails' version and the one in the nodens/openpgp-applet repository are starting to diverge (especially everywhere translated text is available).

How about using this workaround until the debian package (#6507) is done and used in Tails ?
If that's OK I'll create a new bug for that (e.g Tails OpenPGP Applet : Add a confirmation dialog on exit).

Of course I could provide a patch for both versions but I'd rather spend time on other issues.

Cheers,

#11 Updated by intrigeri about 5 years ago

  • Target version set to Tails_1.3

nodens wrote:

The short-term workaround is available in the bugfix/7450-too_easy_to_exit branch of nodens/openpgp-applet git repository, and should apply cleanly on current Tails' version.

Yay :)

The longer-term solution (confirmation dialog) is quite easy to implement, but I'm unsure how to proceed, as current Tails' version and the one in the nodens/openpgp-applet repository are starting to diverge (especially everywhere translated text is available).

How about using this workaround until the debian package (#6507) is done and used in Tails ?

Agreed.

If that's OK I'll create a new bug for that (e.g Tails OpenPGP Applet : Add a confirmation dialog on exit).

Yes, please.

#12 Updated by nodens about 5 years ago

Done : #8319

#13 Updated by intrigeri about 5 years ago

  • Related to Bug #8319: OpenPGP Applet: Add a confirmation dialog on exit added

#14 Updated by nodens about 5 years ago

Note : the branch has been merged in the openpgp-applet repository to avoid future conflicts, but I won't delete it until the fix is commited in main repository.

#15 Updated by nodens about 5 years ago

Applied in changeset commit:e511fc0cd00586a25dea8cfa58b506ed460504e3.

#16 Updated by alant about 5 years ago

  • Feature Branch set to feature/7450-openpgp-applet-exit

Local test shows the patch works. I imported the commit to your repo and merged the feature branch in experimental so that we can actually test it in place.

#17 Updated by BitingBird about 5 years ago

  • Affected tool set to OpenPGP Applet

#18 Updated by alant about 5 years ago

  • Assignee set to alant

#19 Updated by Tails almost 5 years ago

  • Status changed from In Progress to 11
  • % Done changed from 50 to 100

Applied in changeset commit:59e32414e1816d98b2f5e73b3b072e19cc900d06.

#20 Updated by alant almost 5 years ago

  • Assignee deleted (alant)
  • QA Check changed from Ready for QA to Pass

Merged, thanks!

#21 Updated by BitingBird almost 5 years ago

  • Status changed from 11 to Resolved

#22 Updated by tchou over 4 years ago

  • Subject changed from Tails OpenPGP Applet is too easy to exit to Tails OpenPGP Applet is too easy to exit.

#23 Updated by tchou over 4 years ago

  • Subject changed from Tails OpenPGP Applet is too easy to exit. to Tails OpenPGP Applet is too easy to exit

Also available in: Atom PDF