Project

General

Profile

Bug #7285

Feature #7409: Browse the offline documentation using Yelp

Yelp crashes when clicking a link to an anchor

Added by anonym about 5 years ago. Updated about 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
05/26/2014
Due date:
% Done:

50%

Feature Branch:
bugfix/7285-yelp-crashes-on-anchor
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:

Description

Sometimes I get errors like:

Document Not Found
The URI ‘#index4h1’ does not point to a valid page.

Other times yelp simply crashes.

We fixed this in commit 64de544 for squeeze, and it seems we may have to something similar for wheezy.


Related issues

Related to Tails - Feature #7391: Browse offline documentation with Tor Browser instead of Yelp Resolved 06/10/2014
Related to Tails - Bug #7390: In Yelp, clicking a link to an anchor opens Nautilus Rejected 05/26/2014

Associated revisions

Revision 9081b2ee (diff)
Added by Tails developers about 5 years ago

Revert "Open local documentation with Yelp." (Closes: #7390, #7285)

This reverts commit 08800bc029050175907bd6f8d0fcb219b3fc63c9.

Yelp in Wheezy has quite some issues in our usecase, and the browser
issue that made us move to Yelp has vanished.

History

#1 Updated by intrigeri about 5 years ago

We fixed this in commit 64de544 for squeeze, and it seems we may have to something similar for wheezy.

Oh, crap. That's the kind of technical debt we get for our old half-baked quick hacks.

[... removed useless rant ...]

FTR, I've had a look, and our reasons for switching to Yelp are still valid. And internal links also behave quite wrongly on current sid (even if I could not crash Yelp there).

#2 Updated by intrigeri about 5 years ago

  • Subject changed from Anchor links are broken in yelp in Wheezy to Anchor links are broken in Yelp
  • Status changed from New to Confirmed

#3 Updated by intrigeri about 5 years ago

  • Assignee set to intrigeri

I'll at least bring it into a non-crashing (but maybe not so good) state.

#4 Updated by intrigeri about 5 years ago

  • Status changed from Confirmed to In Progress

#5 Updated by intrigeri about 5 years ago

  • % Done changed from 0 to 10

https://bugs.debian.org/751170 says it all: we reported it upstream in 2012 (https://bugzilla.gnome.org/show_bug.cgi?id=686095), provided a fix, that was merged and released in Yelp 3.8.0. But we failed to have the bug fixed in Wheezy.

With this patch applied, Yelp doesn't crash anymore, so I'll at least upload a package that includes it to a topic branch. Still, things are not very good either (in non-Tails Wheezy):

  • clicking an anchor link opens Nautilus in the parent directory of the currently viewed HTML file
  • double-clicking an anchor link works fine
  • right click -> open link works fine
  • "right click -> open link in new window" works fine

I'm starting to suspect a MIME association problem, and I think I should try and reproduce this on Fedora..

#6 Updated by intrigeri about 5 years ago

  • Feature Branch set to bugfix/7285-yelp-crashes-on-anchor

intrigeri wrote:

With this patch applied, Yelp doesn't crash anymore, so I'll at least upload a package that includes it to a topic branch.

Done.

#7 Updated by intrigeri about 5 years ago

  • Copied to Bug #7390: In Yelp, clicking a link to an anchor opens Nautilus added

#8 Updated by intrigeri about 5 years ago

  • Copied to deleted (Bug #7390: In Yelp, clicking a link to an anchor opens Nautilus)

#9 Updated by intrigeri about 5 years ago

  • Blocks Bug #7390: In Yelp, clicking a link to an anchor opens Nautilus added

#10 Updated by intrigeri about 5 years ago

  • Subject changed from Anchor links are broken in Yelp to Yelp crashes when clicking a link to an anchor
  • % Done changed from 10 to 50

intrigeri wrote:

With this patch applied, Yelp doesn't crash anymore, so I'll at least upload a package that includes it to a topic branch. Still, things are not very good either (in non-Tails Wheezy):

The non-crashing part of this bug is now known as #7390.

#11 Updated by intrigeri about 5 years ago

  • Blocked by Feature #7391: Browse offline documentation with Tor Browser instead of Yelp added

#12 Updated by intrigeri about 5 years ago

  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA

anonym, please close as rejected once the fix in #7391 is merged.

#13 Updated by intrigeri about 5 years ago

  • Assignee deleted (anonym)
  • Target version deleted (Tails_1.1)
  • QA Check deleted (Ready for QA)

#14 Updated by intrigeri about 5 years ago

  • Blocked by deleted (Feature #7391: Browse offline documentation with Tor Browser instead of Yelp)

#15 Updated by intrigeri about 5 years ago

  • Related to Feature #7391: Browse offline documentation with Tor Browser instead of Yelp added

#16 Updated by intrigeri about 5 years ago

  • Blocks deleted (Bug #7390: In Yelp, clicking a link to an anchor opens Nautilus)

#17 Updated by intrigeri about 5 years ago

  • Priority changed from Elevated to Normal
  • Parent task set to #7409

#18 Updated by intrigeri about 5 years ago

Current status: a package with the bugfix is in the corresponding APT suite.

#19 Updated by BitingBird over 4 years ago

  • Related to Bug #7390: In Yelp, clicking a link to an anchor opens Nautilus added

#20 Updated by intrigeri about 4 years ago

  • Status changed from In Progress to Rejected

Also available in: Atom PDF