Project

General

Profile

Feature #6904

Write test for "Report an error" launcher

Added by intrigeri over 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
03/11/2014
Due date:
06/01/2015
% Done:

100%

Feature Branch:
kytv:test/6904-report-an-error-launcher
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:

Description

We don't want #6892 to reappear, so a non-regression test would be welcome. Presumably this one would be fairly easy to write.


Related issues

Related to Tails - Feature #9143: Finish test for "Report an error" launcher Resolved 03/31/2015

History

#1 Updated by intrigeri over 5 years ago

  • Subject changed from Write test for "Report an error" button to Write test for "Report an error" launcher

#2 Updated by anonym almost 5 years ago

  • Assignee set to kytv
  • Target version set to Tails_1.3

#4 Updated by kytv almost 5 years ago

  • Status changed from Confirmed to In Progress

#5 Updated by kytv almost 5 years ago

  • Assignee changed from kytv to anonym
  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/6904-report-an-error-launcher

#6 Updated by anonym almost 5 years ago

  • Assignee changed from anonym to kytv
  • QA Check changed from Ready for QA to Dev Needed

Here's an initial review:

  • commit 4fdf47d

+ @screen.wait_and_double_click('DesktopReportAnError.png', 30)

and

+ @screen.wait('SupportDocumentation.png', 60)

These two images was not added to Git, and hopefully you haven't git clean:ed them away. Don't worry, this is far from the first time it has happened. :)

  • commit 0d530cb

Select icon before double-clicking to avoid losing a click.

I'm surprised this is necessary. Can you reproduce it manually?

def s.wait_and_double_click(pic, time)
+ self.click(self.wait(pic, time)) # a click can be lost on some systems without this
self.doubleClick(self.wait(pic, time))
end

This effectively turns wait_and_double_click() into wait_and_triple_click(). If this workaround indeed is necessary, add the extra click directly in the step where it's needed instead -- what you do there may break tests where we indeed expect exactly two clicks.

#7 Updated by kytv almost 5 years ago

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

anonym wrote:

  • commit 0d530cb

Select icon before double-clicking to avoid losing a click.

I'm surprised this is necessary. Can you reproduce it manually?

It turned out it wasn't. I must have misinterpreted something I saw.

Anyhow...fixed up, rebased against devel, and force pushed.

#8 Updated by intrigeri almost 5 years ago

Anyhow...fixed up, rebased against devel, and force pushed.

anonym may think differently, but in general, I personally dislike seeing the Git history rewritten for branches that were reviewed once already.

#9 Updated by anonym almost 5 years ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

intrigeri wrote:

Anyhow...fixed up, rebased against devel, and force pushed.

anonym may think differently, but in general, I personally dislike seeing the Git history rewritten for branches that were reviewed once already.

For a small branch like this it's ok, especially when this much time has passed so I have to read it from scratch any way.

#10 Updated by BitingBird over 4 years ago

  • Status changed from Fix committed to Resolved

#11 Updated by intrigeri over 4 years ago

  • Related to Feature #9143: Finish test for "Report an error" launcher added

#12 Updated by sajolida over 4 years ago

  • Due date set to 06/01/2015

Also available in: Atom PDF