Project

General

Profile

Feature #6841

Bug #8309: Remove the topIcons GNOME Shell extension

Replace Vidalia

Added by intrigeri over 5 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
03/03/2015
Due date:
% Done:

100%

Feature Branch:
feature/6841-replace-vidalia
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:

Description

Vidalia is unmaintained upstream. This is a parent ticket meant to track whatever blocks us from removing it.


Subtasks

Feature #9002: Replace Vidalia's green onion featureResolved

Feature #11128: Update documentation to match Vidalia removalResolved


Related issues

Related to Tails - Bug #5499: Make sure Vidalia always autostarts Rejected
Related to Tails - Bug #8856: After Tor restart, TorBrowser thinks it is not running and Vidalia also can't reconnect to it. Resolved 02/04/2015
Related to Tails - Bug #9013: Message log suggests to hit start button on vidalia which doesn't exist Rejected 03/04/2015
Related to Tails - Bug #10339: Are the security risks introduced by Vidalia-like tools worth it? Rejected 10/06/2015
Blocks Tails - Bug #9259: Stop installing libqt4-qt3support Resolved 04/18/2015
Blocks Tails - Bug #10807: Vidalia icon is sometimes not visible or hidden in the notification area Resolved 12/31/2015
Blocks Tails - Feature #8927: Replicate Vidalia's ability to close arbitrary circuits Confirmed 02/21/2015

Associated revisions

Revision 9e2c9c28 (diff)
Added by intrigeri over 3 years ago

Remove `set -x' from the tormonitor wrapper.

It's simple enough that likely this won't be needed in production.

refs: #6841

Revision c2167d20 (diff)
Added by intrigeri over 3 years ago

Add `set -u' to the tormonitor wrapper.

For consistency's sake: we're trying to use `set -u' in all our shell scripts,
as long as we're using shell.

refs: #6841

Revision 9a04c851 (diff)
Added by intrigeri over 3 years ago

Update automated test suite to match Vidalia being replaced.

refs: #6841

Revision 883c6d6f (diff)
Added by intrigeri over 3 years ago

Delete Vidalia -specific NM script.

refs: #6841

Revision 1cf45ea9 (diff)
Added by intrigeri over 3 years ago

Lock down a bit the sudoer credentials added for Onion Circuits.

refs: #6841

Revision c821e0ea (diff)
Added by intrigeri over 3 years ago

Tor Monitor was renamed to Onion Circuits.

refs: #6841

Revision fc0422fc (diff)
Added by intrigeri over 3 years ago

onioncircuits wrapper: drop X access control even if onioncircuits returns non-zero.

refs: #6841

Revision 227ead1d
Added by anonym over 3 years ago

Merge remote-tracking branch 'origin/feature/6841-replace-vidalia' into testing

Fix-committed: #6841, #11128

History

#1 Updated by sajolida over 5 years ago

  • Status changed from New to Confirmed

#2 Updated by intrigeri over 5 years ago

Status changed from New to Confirmed

FWIW, I was leaving this ticket in "New" state as we haven't decided to remove Vidalia yet.

#3 Updated by intrigeri over 5 years ago

  • Related to Bug #5499: Make sure Vidalia always autostarts added

#4 Updated by sajolida over 5 years ago

  • Status changed from Confirmed to New

#5 Updated by sajolida about 5 years ago

  • Subject changed from Remove Vidalia to Research how to Vidalia
  • Status changed from New to Confirmed

#6 Updated by sajolida about 5 years ago

  • Subject changed from Research how to Vidalia to Research how to replace Vidalia
  • Target version set to Sustainability_M1

#7 Updated by intrigeri almost 5 years ago

  • Parent task set to #8309

Another reason to drop Vidalia is that its applet hijacks the notification area, and thus needs workarounds to work in GNOME Shell.

#8 Updated by BitingBird over 4 years ago

  • Related to Bug #8856: After Tor restart, TorBrowser thinks it is not running and Vidalia also can't reconnect to it. added

#9 Updated by anonymous2 over 4 years ago

Without Vidalia it is not certain how to:

1. View status of Tor;
2. Trigger "Use new IP address";
3. Restart Tor.

TorBrowser's "New identity" button is too deep: it also closes all the tabs while sometimes only new IP address is needed.

I think if Vidalia goes away without any simialar replacement, there can be new menu items like "Applications -> Networking -> Tor control -> {View Tor status/logs/graphs, Use new identity, Restart Tor}". As a minimal stub those menu items can just open some help pages describing how to make this actions after Vidalia is no more.

#10 Updated by intrigeri over 4 years ago

Without Vidalia it is not certain how to:

1. View status of Tor;

Vidalia only reports duplicate info that we already provide with the "Tor is ready" notification. If you need other status info, please look into arm that is included in Tails too. We'll need to document that when we remove Vidalia.

2. Trigger "Use new IP address";

This can be triggered with arm and from Tor Browser. We'll need to document the former when we remove Vidalia.

3. Restart Tor.

This can be triggered with NetworkManager applet, by disconnecting from the network and reconnecting. Granted, this is non-obvious and could be documented.

#11 Updated by anonymous2 over 4 years ago

3. Restart Tor.

This can be triggered with NetworkManager applet, by disconnecting from the network and reconnecting. Granted, this is non-obvious and could be documented.

Maybe there can be a menu entry "Restart Tor" that does exaclty this (trigger NM disconnect, then connect again)?

#12 Updated by intrigeri over 4 years ago

  • Subject changed from Research how to replace Vidalia to Replace Vidalia

#13 Updated by BitingBird over 4 years ago

  • Related to Feature #9002: Replace Vidalia's green onion feature added

#14 Updated by intrigeri over 4 years ago

  • Related to deleted (Feature #9002: Replace Vidalia's green onion feature)

#15 Updated by BitingBird over 4 years ago

  • Related to Bug #9013: Message log suggests to hit start button on vidalia which doesn't exist added

#16 Updated by BitingBird over 4 years ago

  • Description updated (diff)

Removed the "we haven't' decided to remove it (yet)" sentence from the description.

#17 Updated by intrigeri over 4 years ago

  • Blocks Bug #9259: Stop installing libqt4-qt3support added

#18 Updated by alant about 4 years ago

  • Blocks deleted (Bug #9259: Stop installing libqt4-qt3support)

#19 Updated by alant about 4 years ago

  • Blocks Bug #9259: Stop installing libqt4-qt3support added

#20 Updated by sajolida about 4 years ago

  • Target version changed from Sustainability_M1 to 2016

#21 Updated by sajolida almost 4 years ago

  • Blocked by Bug #10339: Are the security risks introduced by Vidalia-like tools worth it? added

#22 Updated by intrigeri over 3 years ago

  • Blocks Bug #10807: Vidalia icon is sometimes not visible or hidden in the notification area added

#23 Updated by alant over 3 years ago

  • Feature Branch set to feature/6841-replace-vidalia

I made a branch that removes vidalia and replaces it by tor-monitor (#6842) and a custom shell extension(#9002). Please note that this branch won't build unless you drop a tor-monitor package in chroot_local-packages or the package gets uploaded (#9580).

The resulting iso works fine, has an onion in the top right corner and has a working tor-monitor application that can be opened from this icon od from the Applications - Interent menu.

#24 Updated by intrigeri over 3 years ago

  • Blocks Feature #8927: Replicate Vidalia's ability to close arbitrary circuits added

#25 Updated by intrigeri over 3 years ago

  • Status changed from Confirmed to In Progress

#26 Updated by intrigeri over 3 years ago

  • Blocked by deleted (Bug #10339: Are the security risks introduced by Vidalia-like tools worth it?)

#27 Updated by intrigeri over 3 years ago

  • Related to Bug #10339: Are the security risks introduced by Vidalia-like tools worth it? added

#28 Updated by intrigeri over 3 years ago

I'll upload Onion Circuits 0.3 to replace Tor Monitor, will ask anonym to merge in time for 2.2~rc1, and he's OK if I adjust the doc post-RC, in time for 2.2.

#29 Updated by intrigeri over 3 years ago

  • Assignee set to intrigeri
  • Target version changed from 2016 to Tails_2.2

#30 Updated by intrigeri over 3 years ago

  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA

Please review & merge for 2.2~rc1, I'll deal with #11128 in time for the final 2.2, and will get #11160 and #11161 started in the next few weeks as well.

#31 Updated by anonym over 3 years ago

Some initial thoughts, and non-blockers, after using torstatus and Onion Circuits:

  • I find the hard minimum width slightly troublesome. Onion Circuits sometimes expands the width of the Path column signifucantly, to the point where the window becomes quite unusable with a 800xY resolution, and barely passable with with 1024xY. It seems to occur when Tor does a directory fetch or tries to connect to a hidden service, since a very long <address:fingerprint> will appear in the circuit list. Pruning the fingerprint (which is pretty useless information in the list, and fits better in the "details" view to the right, if we really want to show it anywhere) should be enough to fix this instance of the width problem, but perhaps overly long relay names can trigger it too.
  • Perhaps we should consider disabling the torstatus extension when the user disables networking completely in Tails Greeter? The onion icon is of doubtful value in this configuration (well, it tells that Tor is not bootstrapped) and can perhaps make users worry that Tor is running...
  • ... because the two torstatus icon states are pretty hard to distinguish for someone with poor eye sight. Info leak: e.g. for someone like me currently. For me the "X" just melts into the shade of the onion on the right side, and I have to look quite carefully, and squint a bit, to be sure about what the stat is. IMHO we need something more distinct, like a larger "X" that extends well outside of the shade, or something completely different like the onion being split into two jagged (=> broken) pieces. I know that the current design with the "X", including its size, is consistent with the one used when the network connection is disabled, but frankly I have issues distinguising that one too. I don't think we should optimize for slick design and people with hawk vision. :)

I'll file tickets unless someone disregards them outright, before this ticket is closed. Code review will follow.

#32 Updated by anonym over 3 years ago

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Ready for QA to Dev Needed
  • Type of work changed from Research to Code

Looks great up to b0a0e20, which I've merged. I'm eagerly anticipating the doc updates! :) (And possibly some commentary for my remarks above.)

#33 Updated by intrigeri over 3 years ago

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Dev Needed to Ready for QA

(The remaining subtask is on anonym's plate now.)

#34 Updated by intrigeri over 3 years ago

  • I find the hard minimum width slightly troublesome.

Fully agreed ⇒ please report it to Alan as a bug. The workaround you're suggesting seems acceptable to me.

  • Perhaps we should consider disabling the torstatus extension when the user disables networking completely in Tails Greeter? The onion icon is of doubtful value in this configuration (well, it tells that Tor is not bootstrapped) and can perhaps make users worry that Tor is running...

I don't care much either way. But I'm scared of modifying the list of GNOME Shell extensions programmatically at login time: it's hard to do that in a robust way. So frankly, I doubt that the pros are worth the risk of breaking unrelated stuff. If anyone wants to work on this, fine with me, but they get to deal with the fallout if this causes subtle GNOME Shell breakage :D

  • ... because the two torstatus icon states are pretty hard to distinguish for someone with poor eye sight.

I would be surprised if this were the only part of Tails that by default is hard to see for someone with poor eye sight. I'm tempted to suggest you retry with the "Large Text" accessibility feature turned on, since it's here precisely to address this class of problems.

#35 Updated by anonym over 3 years ago

intrigeri wrote:

  • I find the hard minimum width slightly troublesome.

Fully agreed ⇒ please report it to Alan as a bug. The workaround you're suggesting seems acceptable to me.

#11192

  • Perhaps we should consider disabling the torstatus extension when the user disables networking completely in Tails Greeter? The onion icon is of doubtful value in this configuration (well, it tells that Tor is not bootstrapped) and can perhaps make users worry that Tor is running...

I don't care much either way. But I'm scared of modifying the list of GNOME Shell extensions programmatically at login time: it's hard to do that in a robust way. So frankly, I doubt that the pros are worth the risk of breaking unrelated stuff. If anyone wants to work on this, fine with me, but they get to deal with the fallout if this causes subtle GNOME Shell breakage :D

Alternatively, the extension could be visible iff networking is enabled. Whatever, this is not so important.

  • ... because the two torstatus icon states are pretty hard to distinguish for someone with poor eye sight.

I would be surprised if this were the only part of Tails that by default is hard to see for someone with poor eye sight.

IMHO, that is a poor implicit justification to introduce more such issues. For the record, nothing else in Tails (except perhaps the network icon) is unclear to me.

I'm tempted to suggest you retry with the "Large Text" accessibility feature turned on, since it's here precisely to address this class of problems.

Sure, then it is clearer, but I'm obviously not going to enable this myself because of this single issue I have.

BTW, I think a pretty easy solution would be to put the X a bit further to the right, so it's more separate from the shaded part of the onion.

#36 Updated by anonym over 3 years ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 75 to 100

#37 Updated by anonym over 3 years ago

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#38 Updated by anonym over 3 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF