Project

General

Profile

Feature #5770

Retry when tor fails

Added by Tails almost 6 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
-
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:

Description

Some scenarios uses the live Tor network, which is not entirely reliable, so we may get failing scenarios when in fact we just happened to pick a Tor circuit that's too slow, or even one that's broken but Tor fails to remedy the situation.

I've never experienced it yet, and I've run the test suite on pretty bad connections, so perhaps let's just wait a while and see if this problem happens in practice, and then retag this ticket todo/code? --intrigeri

For this reason we should tag such scenarios with <tt>uses_tor</tt>, and create an <tt>Around('@uses_tor')</tt> hook which re-tries those scenarios some number of times before actually failing it. That hook should retry only when it catches some custom exception (e.g. @TorFailed) that we make steps throw whenever something that uses Tor times out, but it should not retry for other exceptions.


Related issues

Related to Tails - Bug #9478: How to deal with transient network errors in the test suite? Resolved 05/27/2015

History

#1 Updated by intrigeri over 5 years ago

  • Status changed from Confirmed to Rejected
  • Type of work changed from Discuss to Code
  • Starter set to No

If the need arises in the wild, we'll reopen. In the meantime, let's focus on problems we can experience more widely :)

#2 Updated by sajolida over 5 years ago

  • Category set to Test suite

#3 Updated by sajolida over 5 years ago

  • Subject changed from test suite: retry when tor fails to Retry when tor fails

#4 Updated by anonym about 4 years ago

  • Related to Bug #9478: How to deal with transient network errors in the test suite? added

Also available in: Atom PDF