Project

General

Profile

Feature #5644

Test suite: always check for firewall leaks

Added by Tails over 6 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
test/7821-tor
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:

Description

Should we check for firewall leaks in every scenario, or at least, in every scenario that involves the Internet?

If we want to fully replace the manual leak check we've been doing until now, yes, we do want this. I don't see why we would not want this. Feel free to re-add a todo/discuss tag (and perhaps raise the discussion on tails-dev) if there's some good reason I've missed that makes it worth discussing this any further. --intrigeri

Actually, we don't want to do it for all features/scenarios involving the Internet (think about e.g. unsafe_browser.feature). Instead we could:

  1. add a tag <tt>@uses_tor</tt> (which is relevant for other things, like retrying when Tor fails (#5770)) to all features/scenarios that uses Tor.
  2. add a <tt>Before('@uses_tor')</tt> hook that starts the sniffer, and a <tt>After('@uses_tor')</tt> hook that check for leaks.

Looks good. --intrigeri

We'd still keep the current firewall leak checker steps for the features and scenarios that need more control, like the firewall_leaks.feature:s anti-tests.

Implemented in branch test/firewall-check-tag (note: it depends on branch test/reorg being merged first). Once merged, please remove the following test (and sub-tests) from the manual test suite:

  • Verify that all destinations reached from an intensive Tails session are tor routers or authorities ...

Related issues

Related to Tails - Feature #7821: Automatic tests for Tor Resolved 08/26/2014

Associated revisions

Revision 56ac03f6 (diff)
Added by Tails developers almost 5 years ago

Tag appropriate scenarios/features @check_tor_leaks (Will-fix: #5644).

Revision 5feef88f
Added by Tails developers almost 5 years ago

Merge branch 'test/7821-tor' into testing

Fix-committed: #7821, #5644

History

#1 Updated by intrigeri over 6 years ago

  • Type of work changed from Qa to Code

#2 Updated by intrigeri over 6 years ago

  • Assignee set to intrigeri
  • Feature Branch set to test/firewall-check-tag
  • Starter set to No

#3 Updated by intrigeri over 6 years ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to anonym
  • QA Check changed from Ready for QA to Dev Needed

Initial review emailed to tails-dev.

#4 Updated by anonym over 6 years ago

  • QA Check changed from Dev Needed to Ready for QA

Fixes pushed, also see thread on tails-dev.

#5 Updated by intrigeri over 6 years ago

  • % Done changed from 0 to 70
  • QA Check changed from Ready for QA to Dev Needed

Reviewed again (August 19). We're almost there!

#6 Updated by intrigeri about 6 years ago

Has been discussed in the "Please review'n'merge test/firewall-check-tag" thread on tails-dev.
According to last review (August 19), a function lacks documentation, and then some commits should be squashed.

#7 Updated by BitingBird over 5 years ago

  • Subject changed from test suite: always check for firewall leaks to Test suite: always check for firewall leaks

#8 Updated by BitingBird about 5 years ago

  • Category set to Test suite

#9 Updated by Tails almost 5 years ago

Applied in changeset commit:e143997e8e2c6783ceeee890b23e4d2c6ceb7c29.

#10 Updated by anonym almost 5 years ago

#11 Updated by anonym almost 5 years ago

  • Assignee changed from anonym to kytv
  • Target version set to Tails_1.3
  • % Done changed from 70 to 50
  • QA Check changed from Dev Needed to Ready for QA
  • Feature Branch changed from test/firewall-check-tag to test/7821-tor

For the review, see #7821#note-16.

#12 Updated by kytv almost 5 years ago

  • Assignee deleted (kytv)
  • QA Check changed from Ready for QA to Pass

#13 Updated by intrigeri almost 5 years ago

  • Assignee set to intrigeri

#14 Updated by intrigeri almost 5 years ago

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Pass to Dev Needed

Doesn't pass my review, see #7821.

#15 Updated by anonym almost 5 years ago

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

#16 Updated by Tails almost 5 years ago

  • Status changed from In Progress to 11
  • % Done changed from 50 to 100

Applied in changeset commit:40d4c1bf9fc5cc2f251e0f546afd82f79c91169f.

#17 Updated by intrigeri almost 5 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#18 Updated by anonym almost 5 years ago

#19 Updated by BitingBird almost 5 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF