Project

General

Profile

Bug #5465

Feature #5978: test suite: usb install feature

test suite: fix persistence is not enabled check

Added by Tails over 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
Due date:
% Done:

50%

Feature Branch:
test/fix-persistence-checks
Type of work:
Code
Blueprint:
Starter:
No
Affected tool:

Description

This check is incorrect:

data_part_dev = boot_device + "2" 
assert(!@vm.execute("grep -q '^#{data_part_dev} ' /proc/mounts").success?,
       "Partition '#{data_part_dev}' from the boot device is mounted")

I believe it will success even if persistence is enabled.


Related issues

Blocked by Tails - Feature #6399: Finish the Rjb migration Resolved 11/03/2013

History

#1 Updated by intrigeri about 6 years ago

  • Assignee set to intrigeri
  • QA Check set to Ready for QA
  • Starter set to No

#2 Updated by intrigeri about 6 years ago

  • Feature Branch set to test/fix-persistence-checks

#3 Updated by intrigeri about 6 years ago

  • Tracker changed from Feature to Bug

#4 Updated by intrigeri about 6 years ago

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Ready for QA to Dev Needed

First review emailed to tails-dev ("Please review'n'merge test/fix-persistence-checks" thread, July 27, 2013).

#5 Updated by intrigeri about 6 years ago

  • Category set to Test suite

#6 Updated by intrigeri almost 6 years ago

  • Parent task set to #5978

#7 Updated by intrigeri almost 6 years ago

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50

I'll bring this branch to a mergeable state.

#8 Updated by intrigeri almost 6 years ago

I've implemented the robustness improvements I was asking for in July, and the feature passes.

Left to do: revert the split of the "all persistent directories are mounted" step out of "persistence is enabled", to keep our features readable.

#9 Updated by intrigeri almost 6 years ago

  • Assignee changed from intrigeri to bertagaz
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:

Left to do: revert the split of the "all persistent directories are mounted" step out of "persistence is enabled", to keep our features readable.

Done, the feature still passes for me. Ready to review'n'merge.

#10 Updated by intrigeri over 5 years ago

  • Target version set to Tails_0.23

#11 Updated by intrigeri over 5 years ago

  • Assignee changed from bertagaz to anonym

Reassigning to the current RM.

#12 Updated by intrigeri over 5 years ago

  • Status changed from Confirmed to In Progress

#13 Updated by anonym over 5 years ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Merged!

#14 Updated by anonym over 5 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF