Project

General

Profile

Bug #17415

Fix IUK generation in release process

Added by intrigeri 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
doc/17415-fix-IUK-generation-in-release-process
Type of work:
Contributors documentation
Blueprint:
Starter:
Affected tool:

Description

(19:26:02) kibi: intrigeri: the loop is still buggy
(19:26:13) kibi: also, it happily ignores failures and continues
(19:26:21) kibi: chown: cannot access '"/home/kibi/work/clients/tails/release/isos/iuks/v2/Tails_amd64_4.0_to_4.2.1.iuk"': No such file or directory
(19:29:54) kibi: I don't plan on fixing shell quoting issues (meaning testing the bugfixes) on my own
(19:30:09) kibi: at least not right now; and I don't think I need you to do it instead, now.
(19:30:35) kibi: maybe file a ticket? I might take a little break while the IUKs are grinding.

Associated revisions

Revision 27295da9 (diff)
Added by intrigeri 2 months ago

Release process: simplify local IUKs generation (refs: #17415)

This code block was getting awfully complicated and did not work in my shell
configuration, so let's instead delegate the most complex logic and error
handling to the existing wrap_tails_create_iuks Python script (used by the
build_IUKs Jenkins job) and keep only very simple shell code in here.

Incidentally, this has an extra advantage: wrap_tails_create_iuks will download
any ISO that it can't find locally, which can be useful. Our doc asks the RM to
download such images at the beginning of their shift, but it's better not to
rely on this:

- We sometimes split the release process in 2+ pieces; whoever handles
this part might not be the one who did the earlier steps.
- Between the beginning of a release cycle and release time, the RM might have
deleted old images to save disk space locally.

Revision 6147805d
Added by anonym about 2 months ago

Merge remote-tracking branch 'origin/doc/17415-fix-IUK-generation-in-release-process' into stable

Fix-committed: #17415

History

#2 Updated by intrigeri 3 months ago

Plus, we should add a check to verify that we indeed have generated all the IUKs we want.

#3 Updated by intrigeri 3 months ago

kibi's fixes break the "Build the Incremental Upgrade Kits locally" code block in my shell environment. Workaround'ed by running it under /bin/sh. This code block is getting awfully complicated and as we can see, shell-config-dependent, so IMO it's a good candidate to migrate from inline shell snippet to a Python script.

#4 Updated by intrigeri 2 months ago

  • Status changed from Confirmed to In Progress
  • Feature Branch set to doc/17415-fix-IUK-generation-in-release-process

#5 Updated by intrigeri 2 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to anonym

OK, I have something.

anonym, please either review this ahead of the 4.3 release process, or just test it while you'll go through this step (the plan is still that I'll be around to help if anything goes wrong).

Note that https://tails.boum.org/contribute/working_together/roles/release_manager/ has new stuff ("The ISO images for […]") so you cannot skip the whole section under the "business as usual" assumption.

#6 Updated by intrigeri 2 months ago

I'll do #17412 on the same branch.

#7 Updated by intrigeri about 2 months ago

@anonym, note that this only lives on a topic branch, which you'll need to merge if you want to test this as part of the 4.3 release process :)

#8 Updated by anonym about 2 months ago

  • Status changed from Needs Validation to Resolved
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100

Code looks good to me! I've merged it, and will do the testing when preparing Tails 4.3. Worst case I revert the merge.

Also available in: Atom PDF