Project

General

Profile

Feature #17312

Prevent users from closing Tails Upgrader while an upgrade is being applied

Added by sajolida 4 months ago. Updated 26 days ago.

Status:
Confirmed
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Upgrader

Description

The current dialog when the upgrade is being applied has an "OK" button that, when clicked closes the dialog.

The upgrade is still being applied in the background: tails-upgrader is still running and the USB stick is flashing.

We should prevent people from closing this dialog until the upgrade is fully applied.

At this point, Tails is offline and we recommended people to close everything else. People click OK might wonder what should happen next and we won't display anything else before several minutes. I guess that a lot of people might restart in doubt of what's happening.

I guess that this is the root cause behind #14754.

Marking as Elevated as it might lead to a broken Tails.

upgrading.png View (11.6 KB) sajolida, 12/04/2019 12:17 PM


Related issues

Related to Tails - Feature #14544: Spend software developer time on smallish UX improvements In Progress 08/31/2018
Related to Tails - Bug #16603: Buggy and confusing UI in the "Upgrading the system" dialog Resolved 03/21/2019

History

#1 Updated by sajolida 4 months ago

  • Related to Feature #14544: Spend software developer time on smallish UX improvements added

#2 Updated by sajolida 4 months ago

See screenshot in attachment.

#3 Updated by intrigeri 4 months ago

The current dialog when the upgrade is being applied has an "OK" button that, when clicked closes the dialog.

This part is tracked on #16603. But #16603 does not cover the (much more ambitious) "Prevent users from closing Tails Upgrader" part so I'd rather keep them separate.

#4 Updated by intrigeri 4 months ago

  • Related to Bug #16603: Buggy and confusing UI in the "Upgrading the system" dialog added

#5 Updated by sajolida 4 months ago

Sorry for not seeing #16603 earlier. I listed all the open tickets affecting "Upgrader" but apparently went through them too fast.

#6 Updated by intrigeri 2 months ago

intrigeri wrote:

But #16603 does not cover the (much more ambitious) "Prevent users from closing Tails Upgrader" part

FTR, segfault's branch for #16603 hides the "OK" button, which is great. But one can still close the dialog by pressing "ESC" (and possibly via the task bar, I did not check this) so we're not there yet.

Once this change is applied, do you think priority = Elevated is still deserved?

#7 Updated by sajolida 26 days ago

Once this change is applied, do you think priority = Elevated is still deserved?

Good news! Probably not but I should check once it's fixed. I also want
to test again #17313 at some point.

#8 Updated by intrigeri 26 days ago

Once this change is applied, do you think priority = Elevated is still deserved?

Good news! Probably not but I should check once it's fixed.

To be clear, it's been fixed in 4.3 so you'll can test this while upgrading to 4.4 or newer :)

Also available in: Atom PDF