Project

General

Profile

Bug #17143

Re-enable Tor Browser's "Quantum bar"

Added by intrigeri about 1 month ago. Updated about 16 hours ago.

Status:
Fix committed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
bugfix/17143-17214-12023-remove-obsolete-tor-browser-customization+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

To workaround #17121 (aka. https://trac.torproject.org/projects/tor/ticket/32019) we had to disable Tor Browser's "Quantum bar": dfeaa6e96e767dcd96304cceeb5aaa39ef2b4469.

Sooner or later, Mozilla will remove support for the obsolete thing we've reverted to, so we need a real fix at some point.


Related issues

Related to Tails - Bug #17121: Tor Browser 9 sometimes won't load new URLs Resolved
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed
Blocks Tails - Bug #17214: Drop obsolete customization to hide the "Tor" section in preferences Fix committed
Blocks Tails - Bug #12023: htpdate: stop sending User-Agent that fakes Tor Browser Fix committed 12/08/2016

Associated revisions

Revision 86747ac3 (diff)
Added by intrigeri 6 days ago

Revert "Browsers: disable the Quantum Bar." (refs: #17143)

https://trac.torproject.org/projects/tor/ticket/32019 suggest that the
underlying bug was fixed in 9.0a8 and 9.0 final.

This reverts commit 8c37cc5c099d250492fe893f63304a245d51ad75.

Revision 102750ce
Added by intrigeri about 16 hours ago

Merge branch 'bugfix/17143-17214-12023-remove-obsolete-tor-browser-customization+force-all-tests' into stable (Fix-committed: #17143, #17214, #12023)

History

#1 Updated by intrigeri about 1 month ago

  • Related to Bug #17121: Tor Browser 9 sometimes won't load new URLs added

#2 Updated by intrigeri about 1 month ago

#3 Updated by intrigeri 25 days ago

  • Target version set to Tails_4.1

Recent updates on https://trac.torproject.org/projects/tor/ticket/32019 suggest that the underlying bug was fixed in 9.0a8 and 9.0 final.

#4 Updated by intrigeri 7 days ago

Possibly related: https://trac.torproject.org/projects/tor/ticket/31764 (fixed in Tor Browser 9.0.1).

#5 Updated by intrigeri 6 days ago

  • Status changed from Confirmed to In Progress

#6 Updated by intrigeri 6 days ago

  • Assignee set to intrigeri
  • Feature Branch set to bugfix/17143-17214-remove-obsolete-tor-browser-customization+force-all-tests

#7 Updated by intrigeri 6 days ago

  • Feature Branch changed from bugfix/17143-17214-remove-obsolete-tor-browser-customization+force-all-tests to bugfix/17143-17214-12023-remove-obsolete-tor-browser-customization+force-all-tests

#8 Updated by intrigeri 5 days ago

  • No trace of #17121 being back so far, but I'll want to run the test suite on our slower isotesters (lizard) a few more times to confirm.
  • I can save the current page as "index.html" to the persistent Tor Browser directory (fragile: #15336) failed on lizard
    • The video looks OK except the download down-arrow icon in the toolbar has an orange dot; I don't know what that means; note that the test suite opened the 2nd page, that we want to save, before the homepage was fully loaded
    • It may be a one-off robustness issue, let's see what the next few test suite runs say.

#9 Updated by intrigeri 5 days ago

  • Blocks Bug #17214: Drop obsolete customization to hide the "Tor" section in preferences added

#10 Updated by intrigeri 5 days ago

  • Blocks Bug #12023: htpdate: stop sending User-Agent that fakes Tor Browser added

#11 Updated by intrigeri 4 days ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (intrigeri)

No trace of #17121 in runs 2-5 on https://jenkins.tails.boum.org/job/test_Tails_ISO_bugfix-17143-17214-12023-remove-obsolete-tor-browser-customization-force-all-tests/, and the one-off failure I saw the other day did not come back, so I think we're good!

#12 Updated by segfault 2 days ago

  • Assignee set to segfault

LGTM. Won't merge because #12023 is still in progress.

#13 Updated by intrigeri about 16 hours ago

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Also available in: Atom PDF