Project

General

Profile

Bug #17087

Greeter applies setting when user clicks "Cancel" or "Back"

Added by segfault 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/39/commits
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Greeter

Description

To reproduce:

  1. In the Greeter, open the Additional Settings dialog (by clicking the "+" button)
  2. Choose any additional setting
  3. Choose one of the rows to change the setting
  4. Click "Cancel" or "Back" instead of "Add"

Result:
The setting is applied, even though the user action was "Cancel" or "Back".

In the case of MAC Address Spoofing and Network Connection, the setting is applied but not added to the list of "Additional Settings" in the Greeter window. In the case of the Administration Password, the setting is added to this list.


Related issues

Related to Tails - Feature #14544: Spend software developer time on smallish UX improvements In Progress 08/31/2018
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed
Blocked by Tails - Feature #16095: Curate the list of languages in Tails Greeter Resolved 11/04/2018

Associated revisions

Revision 2b6b2775 (diff)
Added by segfault 5 months ago

Fix admin password not applied in some cases (refs: #13447, #17087)

Revision 06e83a32 (diff)
Added by segfault 5 months ago

Fix MAC address spoofing applied when clicking "Cancel" (refs: #17087)

Revision 48f71298 (diff)
Added by segfault 5 months ago

Fix network setting applied when clicking "Cancel" (refs: #17087)

Revision 537d40ab (diff)
Added by segfault 5 months ago

Fix MAC address spoofing applied when clicking "Cancel" (refs: #17087)

Revision 075c36cd (diff)
Added by segfault 5 months ago

Fix network setting applied when clicking "Cancel" (refs: #17087)

Revision 53c6c19a
Added by intrigeri 5 months ago

Merge branch 'feature/17098-refactor-greeter' into devel (Closes: #17098, #17089, #16806, #13447, #17087, #17058, #17101, #6525, #16095, #16094, #16093)

History

#1 Updated by segfault 5 months ago

  • Description updated (diff)

#2 Updated by segfault 5 months ago

  • Subject changed from Greeter changes setting when user clicks "Cancel" or "Back" to Greeter applies setting when user clicks "Cancel" or "Back"

#3 Updated by segfault 5 months ago

  • Target version set to Tails_4.0

#4 Updated by sajolida 5 months ago

  • Related to Feature #14544: Spend software developer time on smallish UX improvements added

#5 Updated by segfault 5 months ago

#6 Updated by segfault 5 months ago

  • Status changed from Confirmed to In Progress

#7 Updated by segfault 5 months ago

  • Status changed from In Progress to Needs Validation
  • Feature Branch set to feature/16095-curate-languages-in-greeter

#8 Updated by segfault 5 months ago

  • Status changed from Needs Validation to In Progress

#9 Updated by segfault 5 months ago

  • Status changed from In Progress to Needs Validation

#10 Updated by intrigeri 5 months ago

  • Assignee set to intrigeri

#11 Updated by intrigeri 5 months ago

Code review passes, will now build & test.

#12 Updated by intrigeri 5 months ago

  • Blocked by Feature #16095: Curate the list of languages in Tails Greeter added

#13 Updated by intrigeri 5 months ago

  • Status changed from Needs Validation to In Progress
  • Assignee changed from intrigeri to segfault

It works! Please reassign to me once the branch is ready for merging.

#14 Updated by segfault 5 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)
  • Feature Branch changed from feature/16095-curate-languages-in-greeter to https://salsa.debian.org/tails-team/tails/merge_requests/39/commits

#15 Updated by intrigeri 5 months ago

  • Assignee set to intrigeri

#16 Updated by intrigeri 5 months ago

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF