Project

General

Profile

Bug #17030

Missing "Tor Browser" shortcut in the Places menu

Added by intrigeri 16 days ago. Updated 10 days ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/37#note_108671
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

Spotted while fixing #17029 (the test suite should have caught this but #17029 hid the bug): the Places menu has no "Tor Browser" entry in 4.0~beta2.
I did not check if it's a regression vs. 3.x yet, or if we introduced this earlier.


Related issues

Related to Tails - Bug #17029: Test suite: findfailed_hook makes Sikuli use fuzzy images even when fuzzy image matching is disabled Resolved
Related to Tails - Bug #16283: No more icons on desktop in buster Resolved 01/05/2019
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

Associated revisions

Revision a0ba13e1 (diff)
Added by intrigeri 15 days ago

Add GNOME bookmarks earlier in the session login process (refs: #17030)

commit 9efaffaf7d0814ec214dfdc5ffe56f343635e0c1 moved this unit to
desktop.target, which has an unfortunate side-effect: the places-menu GNOME
Shell extension has already loaded, and thus the bookmarks we're adding won't
appear in the Places menu.

So let's start this unit earlier, as part of gnome-early-initialization.target,
that is during X-GNOME-Autostart-Phase=EarlyInitialization.

Revision 7e3c1eed (diff)
Added by intrigeri 15 days ago

Test suite: update reference image.

We don't use fuzzy matches by default anymore, so some images need updating.
Fuzzy matching previously hid the fact that this bookmark was actually
missing (refs: #17030).

Revision e8895194
Added by segfault 10 days ago

Merge branch 'test/17029+17027+17028+16931+force-all-tests' into devel

Closes: #17029, #17027, #17028, #16931, #16617, #17030, #10708, #16465
Closes: #13469

History

#1 Updated by intrigeri 16 days ago

#2 Updated by intrigeri 16 days ago

  • Related to Bug #17029: Test suite: findfailed_hook makes Sikuli use fuzzy images even when fuzzy image matching is disabled added

#3 Updated by intrigeri 15 days ago

  • Assignee set to intrigeri

I'll take a first quick look to estimate how hard it would be to fix this, so we're better placed to evaluate cost/benefit.

This is a regression in 4.0~*: 3.16 is not affected.

The "Tor Browser" shortcut is correctly displayed in the Files (aka. Nautilus) sidebar, just not in the Places menu.

#4 Updated by intrigeri 15 days ago

  • Status changed from Confirmed to In Progress

I have a good lead: I think it's the fallout of our fix for #16283 — yay, Desktop icons :]

I did not verify but I'm pretty sure the "Persistent" shortcut is missing as well, for the same reason.

#5 Updated by intrigeri 15 days ago

  • Feature Branch set to test/17029+17027+17028+16931+force-all-tests

#6 Updated by intrigeri 15 days ago

  • Related to Bug #16283: No more icons on desktop in buster added

#7 Updated by intrigeri 14 days ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (intrigeri)
  • Feature Branch changed from test/17029+17027+17028+16931+force-all-tests to https://salsa.debian.org/tails-team/tails/merge_requests/37#note_108671

#8 Updated by segfault 10 days ago

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF