Project

General

Profile

Bug #17027

Test suite: lost click on "Start Tor Browser"

Added by intrigeri 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/37#note_108671
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

I've seen "And I start the Tor Browser in offline mode" fail because the click on "Start Tor Browser" was apparently lost:

04:58:52.065053713: [log]  TYPE "T" 
04:58:54.516898107: [log]  TYPE "or Browser" 
04:58:56.580096943: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1134 = dogtail.tree.root.application('zenity')
04:58:56.607834339: [log] ( Ctrl )  TYPE "#ENTER." 
04:58:58.457978255: execution complete
04:58:58.458331308: executing Python as amnesia: node1135 = node1134.dialog('Tor is not ready')
04:58:58.506081213: execution complete
04:58:58.506334979: executing Python as amnesia: node1136 = node1135.button('Start Tor Browser')
04:58:58.561561722: execution complete
04:58:58.561759847: executing Python as amnesia: node1136.grabFocus()
04:58:58.608357674: execution complete
04:58:58.608560393: executing Python as amnesia: node1136.click()
04:58:59.698056097: execution complete
04:58:59.698487564: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1137 = dogtail.tree.root.application('Firefox')
04:59:10.477134465: execution complete
04:59:11.477608075: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1138 = dogtail.tree.root.application('Firefox')
04:59:22.211539304: execution complete
04:59:23.211989771: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1139 = dogtail.tree.root.application('Firefox')
04:59:33.998101805: execution complete
04:59:34.998709632: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1140 = dogtail.tree.root.application('Firefox')
04:59:45.727279095: execution complete
04:59:46.727807251: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1141 = dogtail.tree.root.application('Firefox')
04:59:57.577689775: execution complete
04:59:58.578358027: executing Python as amnesia: 
    import dogtail.config
    import dogtail.tree
    import dogtail.predicate
    import dogtail.rawinput
    dogtail.config.logDebugToFile = False
    dogtail.config.logDebugToStdOut = False
    dogtail.config.blinkOnActions = True
    dogtail.config.searchShowingOnly = True
    node1142 = dogtail.tree.root.application('Firefox')
    And I start the Tor Browser in offline mode                                                                   # features/step_definitions/common_steps.rb:372
      try_for() timeout expired
      Last ignored exception was: RuntimeError: The Dogtail script raised: SearchError: child of [desktop frame | main]: "Firefox" application (Timeout::Error)
      ./features/support/helpers/misc_helpers.rb:89:in `rescue in try_for'
      ./features/support/helpers/misc_helpers.rb:36:in `/^the Tor Browser (?:has started|starts)( in offline mode)?$/'
      features/torified_browsing.feature:148:in `And I start the Tor Browser in offline mode'

This might be another instance of #12191. Adding showingOnly: true would not hurt.

05_00_02_Persistent_browser_bookmarks.mkv (1.16 MB) intrigeri, 09/06/2019 08:46 AM


Related issues

Related to Tails - Bug #12191: Dogtail's showingOnly option is not working sometimes Confirmed 01/30/2017
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

Associated revisions

Revision 7e079183 (diff)
Added by intrigeri 3 months ago

Test suite: make the "I start the Tor Browser in offline mode" step more robust (refs: #17027).

The click on "Start Tor Browser" is often apparently lost. This might be another
instance of #12191 so let's use the usual workaround.

Revision e8895194
Added by segfault 3 months ago

Merge branch 'test/17029+17027+17028+16931+force-all-tests' into devel

Closes: #17029, #17027, #17028, #16931, #16617, #17030, #10708, #16465
Closes: #13469

History

#1 Updated by intrigeri 3 months ago

  • Related to Bug #12191: Dogtail's showingOnly option is not working sometimes added

#2 Updated by intrigeri 3 months ago

This happened twice in the last 10 runs on Jenkins (devel) and should be easy to fix ⇒ good cost/benefit ⇒ FT.

#3 Updated by intrigeri 3 months ago

#4 Updated by intrigeri 3 months ago

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri
  • Feature Branch set to test/17029+17027

#5 Updated by intrigeri 3 months ago

  • Feature Branch changed from test/17029+17027 to test/17029+17027+force-all-tests

#6 Updated by intrigeri 3 months ago

  • Feature Branch changed from test/17029+17027+force-all-tests to test/17029+17027+17028+16931+force-all-tests

#7 Updated by intrigeri 3 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (intrigeri)
  • Feature Branch changed from test/17029+17027+17028+16931+force-all-tests to https://salsa.debian.org/tails-team/tails/merge_requests/37#note_108671

#8 Updated by intrigeri 3 months ago

  • Target version set to Tails_4.0

#9 Updated by segfault 3 months ago

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF