Project

General

Profile

Bug #16913

Hide Tor settings in OnionShare

Added by sajolida about 2 months ago. Updated 20 days ago.

Status:
Confirmed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
OnionShare

Description

In 4.0, OnionShare has a settings dialog. It features a bunch of Tor connectivity options, see attachment.

In the context of Tails, these options are, at best, not useful, probably confusing, and possibly harmful if changing them can lead to a broken OnionShare.

settings.png View (68.2 KB) sajolida, 07/28/2019 03:44 PM


Related issues

Related to Tails - Bug #16914: "More information" link in OnionShare settings doesn't open Resolved
Blocked by Tails - Bug #14649: Ship OnionShare 2.x in Tails Confirmed 09/13/2017

History

#1 Updated by intrigeri about 1 month ago

To get things started:

  • I have verified that these settings are not dangerous: our Onion Grater config would forbid OnionShare from reconfiguring Tor; so worst case, fiddling with these prefs would lead do a non-functional OnionShare.
  • I have filed a feature request upstream so they provide a way for us to hide these prefs: https://github.com/micahflee/onionshare/issues/1014

For the time being, our options seem to be:

  • Implement ourselves the feature requested upstream. I don't know how much work that would require. Once it's done and in Debian, there should be zero maintenance cost for us (until upstream breaks it, which might happen if they don't test it regularly). But I doubt we can get this done, merged upstream, released upstream, and uploaded Debian, in time for 4.0.
  • Crudely patch the code to hide these settings. At first glance, this should be quite easy. Maintenance cost should be very low as long as we ship OnionShare from Buster, but I know that u would like us to upgrade to something newer (#14649) soon, which implies we'll track buster-backports and have to deal with version churn, and then we'll have to refresh the patch for every new upstream release.
  • Accept this for now, as yet another smallish bug, not particularly more urgent/important than dozens of other bugs we've been living with for years. Wait and hope for upstream to implement our feature request. Come back to it in a few months and prioritize this problem with the big picture in mind.

I propose we go with the 3rd option for now, drop the 4.0 milestone, add it to the Foundations Team's plate, and come back to it in a few months. @sajolida, what do you think?

#2 Updated by sajolida about 1 month ago

  • Related to Bug #16914: "More information" link in OnionShare settings doesn't open added

#3 Updated by sajolida about 1 month ago

  • Target version deleted (Tails_4.0)

Yep.

#4 Updated by intrigeri 20 days ago

Upstream already implemented what I've requested :)

We're currently shipping 1.3.2 from Buster and upstream is already at 2.1, so I don't expect we can easily backport this change ⇒ will be solved via #14649.

#5 Updated by intrigeri 20 days ago

  • Blocked by Bug #14649: Ship OnionShare 2.x in Tails added

Also available in: Atom PDF