Project

General

Profile

Bug #16902

Tails ISO directory name has ".iso" in it, confusing some software

Added by vom 30 days ago. Updated 3 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
doc/16902-no-image-type-extension-in-torrent-directories
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

For example, Virtualbox errors out as it thinks that the subdirectory itself is an iso image. The Virtualbox folks could probably do a better job validating that the target is a file and not a directory, but perhaps renaming the directory to Tails-x.xx-iso (use dash instead of dot) would save folks a bit of frustration.

Workaround is to simply rename the subdirectory.

Associated revisions

Revision eebf75fe (diff)
Added by intrigeri 15 days ago

Release process: .iso→-iso and .img→-img in the directories downloaded over BitTorrent (refs: #16902)

As reported by @vom, "Virtualbox errors out as it thinks that the subdirectory
itself is an iso image".

History

#1 Updated by intrigeri 16 days ago

@vom, this is about the directory downloaded via BitTorrent, right?

#2 Updated by vom 15 days ago

intrigeri wrote:

@vom, this is about the directory downloaded via BitTorrent, right?

Yes that's correct.

#3 Updated by intrigeri 15 days ago

  • Status changed from New to In Progress

#4 Updated by intrigeri 15 days ago

  • Status changed from In Progress to Needs Validation
  • Assignee set to sajolida
  • Target version set to Tails_3.16
  • Feature Branch set to doc/16902-no-image-type-extension-in-torrent-directories

Hi @sajolida! I've done my best to check and it seems to me that nothing else in our doc/code relies on the name of the directory downloaded over BitTorrent to have the ".iso" or ".img" suffix. Can you please confirm?

My branch renames these directories so their names ends with "-iso" or "-img" instead. Good enough?

If you're fine with this, please reassign to anonym for the review of the branch.

Thanks in advance!

#5 Updated by sajolida 11 days ago

  • Assignee changed from sajolida to anonym

Ack. I don't think that anything on the website relies on the name of the folder inside the BitTorrent download.

#6 Updated by anonym 6 days ago

  • Status changed from Needs Validation to In Progress
  • Assignee changed from anonym to intrigeri

intrigeri wrote:

My branch renames these directories so their names ends with "-iso" or "-img" instead. Good enough?

Good enough, yes, but I wonder I think we could do even better by dropping the suffix completely. Is there a reason we are keeping it (i.e. use separate directories for .iso and .img)? To me it seems they were added to make the use of mktorrent more straightforward. Personally I'd prefer to just have a single folder, however.

I propose we just create one directory tails-amd64-x.y.z for both the .iso and .img. When generating the .torrent:s we create a temporary tails-amd64-x.y.z folder somewhere else, symlink in the files we want in there and run mktorrent (which dereferences). I'm happy to implement this, if you aren't.

#7 Updated by intrigeri 6 days ago

  • Assignee changed from intrigeri to anonym

anonym wrote:

I think we could do even better by dropping the suffix completely. Is there a reason we are keeping it (i.e. use separate directories for .iso and .img)?

Apart of "no ambiguity when downloading the two torrents", indeed, implementation simplicity was the sole reason for giving these two directories different names.

I propose we just create one directory tails-amd64-x.y.z for both the .iso and .img. When generating the .torrent:s we create a temporary tails-amd64-x.y.z folder somewhere else, symlink in the files we want in there and run mktorrent (which dereferences). I'm happy to implement this […]

If sajolida is happy with that, feel free to implement it.

(Personally I feel I/we've already spent enough time on what I see as a relatively minor issue. But I don't want to discourage you from improving it further.)

#8 Updated by anonym 5 days ago

intrigeri wrote:

If sajolida is happy with that, feel free to implement it.

@sajolida?

(Personally I feel I/we've already spent enough time on what I see as a relatively minor issue. But I don't want to discourage you from improving it further.)

Understood! More context: as an RM I have hated this, so for my sanity this issue is subjectively worse than "minor". :)

#9 Updated by sajolida 4 days ago

If this only impacts what people using BitTorrent will see in their
download folder, I'm fine with anything.

#10 Updated by intrigeri 3 days ago

If this only impacts what people using BitTorrent will see in their download folder, I'm fine with anything.

It only impacts the name of that download folder, not its content.

Also available in: Atom PDF