Project

General

Profile

Bug #16858

Branches based on devel FTBFS since webext-ublock-origin 1.19.0 reached sid

Added by intrigeri 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
bugfix/16858-ftbfs-ublock-1.19+force-all-tests, torbrowser-launcher:bugfix/16858-ftbfs-ublock-1.19
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Related issues

Related to Tails - Bug #16973: Drop CSS hack for uBlock Origin sidebar Rejected

Associated revisions

Revision b0702869 (diff)
Added by intrigeri 3 months ago

Refresh patch to apply on top of webext-ublock-origin 1.19.0+dfsg-2 (refs: #16858).

Revision 3abb5bbb (diff)
Added by intrigeri 3 months ago

Adjust path for webext-ublock-origin 1.19.0+dfsg-2 (refs: #16858).

Revision 9a862f18
Added by segfault 3 months ago

Merge branch 'bugfix/16858-ftbfs-ublock-1.19+force-all-tests' into devel (Fix-committed: #16858)

Revision 5c1a1ca3 (diff)
Added by intrigeri 2 months ago

Refresh patch to apply on top of webext-ublock-origin 1.19.0+dfsg-2 (refs: #16858).

Revision 309a1172 (diff)
Added by intrigeri 2 months ago

Adjust path for webext-ublock-origin 1.19.0+dfsg-2 (refs: #16858).

History

#1 Updated by intrigeri 3 months ago

  • Status changed from Confirmed to In Progress
  • Feature Branch set to bugfix/16858-ftbfs-ublock-1.19+force-all-tests

#2 Updated by intrigeri 3 months ago

  • Feature Branch changed from bugfix/16858-ftbfs-ublock-1.19+force-all-tests to bugfix/16858-ftbfs-ublock-1.19+force-all-tests, torbrowser-launcher:bugfix/16858-ftbfs-ublock-1.19

#3 Updated by intrigeri 3 months ago

Passes our manual "test suite" for uBlock:

* Test if _uBlock_ works:
  - The _uBlock_ icon must be visible.
  - Visit a website that normally displays ads, such as
    <https://www.nytimes.com/>. The ads should not be displayed and
    the uBlock icon should display a strictly positive number of
    blocked elements.

Let's see what Jenkins thinks.

#4 Updated by intrigeri 3 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to segfault

https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_bugfix-16858-ftbfs-ublock-1.19-force-all-tests/1/cucumberTestReport/ looks as good as expected, please review & merge:

  • the tails.git branch into "devel"
  • the torbrowser-launcher.git branch into "master" there

Chances are that we need to cherry-pick this commit if we ever bump APT snapshots on the stable branch, which is likely in the next 3 months.

#5 Updated by segfault 3 months ago

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

#6 Updated by segfault 3 months ago

  • % Done changed from 100 to 0

intrigeri wrote:

https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_bugfix-16858-ftbfs-ublock-1.19-force-all-tests/1/cucumberTestReport/ looks as good as expected, please review & merge:

  • the tails.git branch into "devel"
  • the torbrowser-launcher.git branch into "master" there

Done

#7 Updated by segfault 3 months ago

  • Assignee deleted (segfault)

#8 Updated by intrigeri 2 months ago

  • Status changed from Fix committed to In Progress

#9 Updated by intrigeri 2 months ago

  • Status changed from In Progress to Fix committed

#10 Updated by segfault 2 months ago

  • Related to Bug #16973: Drop CSS hack for uBlock Origin sidebar added

#11 Updated by CyrilBrulebois about 1 month ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF