Bug #16281: Update the test suite for Buster
Emergency shutdown automated tests on Buster often fail to notice that memory wipe was completed
I see lots of "FindFailed: can not find MemoryWipeCompleted.png" while the video shows that the expected message was displayed (so I have a doubt wrt. the image update in 56f58e34d2bca109dc2f7d2467d2bc1364732355).
Revert "Update MemoryWipeCompleted.png" (refs: #16817)
I see lots of "FindFailed: can not find MemoryWipeCompleted.png" while the video
shows that the expected message was displayed. And indeed, the candidates saved
by Sikuli when it does manage to find that picture look more like what we have
on our 3.x branches, which suggests that
56f58e34d2bca109dc2f7d2467d2bc1364732355 was perhaps only needed
temporarily last month, perhaps due to #16743.
This reverts commit 56f58e34d2bca109dc2f7d2467d2bc1364732355.
- Status changed from Confirmed to In Progress
- Assignee set to intrigeri
And indeed, https://jenkins.tails.boum.org/view/RM/job/test_Tails_ISO_feature-buster/212/artifact/build-artifacts/sikuli_candidates/MemoryWipeCompleted.png looks more like what we have on our 3.x branches. I'm starting to suspect that 56f58e34d2bca109dc2f7d2467d2bc1364732355 was only needed due to #16743 and now breaks stuff.
- Status changed from In Progress to Needs Validation
- Assignee deleted (
features/emergency_shutdown.featurepasses for me locally on this branch. Let's see what Jenkins thinks
That feature passed twice on https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-16817-emergency-shutdown/.
and especially, check that sikuli does not need to do fuzzy matching to find the picture.
MemoryWipeCompleted.png in https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-16817-emergency-shutdown/1/artifact/build-artifacts/sikuli_candidates/ nor https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-16817-emergency-shutdown/2/artifact/build-artifacts/sikuli_candidates/.
So I think my hypothesis above this correct and this branch is the right thing to do.