Project

General

Profile

Bug #16792

Upgrade our Chutney fork and make configuration more similar to the real Tor network

Added by intrigeri about 1 month ago. Updated 28 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
-
Start date:
Due date:
% Done:

20%

Feature Branch:
feature/16792-update-chutney+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

We haven't updated our Chutney fork since 2016. Current diffstat is: 139 files changed, 3401 insertions(+), 712 deletions(-).
Using configuration and code that was developed for a somewhat antique version of tor will likely cause trouble at some point.

I've noticed this because our suite sets deprecated options in torrc for Chutney usage:

Jun 10 19:38:59 amnesia tor[8575]: Jun 10 19:38:59.126 [warn] The configuration option 'TestingBridgeDownloadSchedule' is deprecated; use 'TestingBridgeDownloadInitialDelay' instead.
Jun 10 19:38:59 amnesia tor[8575]: Jun 10 19:38:59.126 [warn] The configuration option 'TestingClientConsensusDownloadSchedule' is deprecated; use 'TestingClientConsensusDownloadInitialDelay' instead.
Jun 10 19:38:59 amnesia tor[8575]: Jun 10 19:38:59.126 [warn] The configuration option 'TestingClientDownloadSchedule' is deprecated; use 'TestingClientDownloadInitialDelay' instead.

Upstream Chutney has removed all DownloadSchedule torrc options from these templates so in this case, it's no big deal.


Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed 03/22/2019
Blocks Tails - Bug #16471: Drop time synchronization hacks that tor 0.3.5 and 0.4.x made obsolete In Progress 02/17/2019

Associated revisions

Revision 3ef18965 (diff)
Added by anonym about 1 month ago

Chutney: update to current upstream master (Will-fix: #16792).

Revision c09577e4 (diff)
Added by anonym 28 days ago

Chutney: use normal consensus cycle interval (Will-fix: #16792).

History

#1 Updated by intrigeri about 1 month ago

#2 Updated by intrigeri about 1 month ago

  • Blocks Bug #16471: Drop time synchronization hacks that tor 0.3.5 and 0.4.x made obsolete added

#3 Updated by anonym about 1 month ago

  • Assignee set to anonym

#4 Updated by anonym about 1 month ago

  • Subject changed from Upgrade our Chutney fork to Upgrade our Chutney fork and make configuratoin more similar to the real Tor network

#5 Updated by hefee about 1 month ago

Here is another patch for chutney to be more like the current Tor network, to let tests passes that do time screws.
https://salsa.debian.org/hefee/chutney/merge_requests/1

#6 Updated by anonym about 1 month ago

  • Subject changed from Upgrade our Chutney fork and make configuratoin more similar to the real Tor network to Upgrade our Chutney fork and make configuration more similar to the real Tor network

#7 Updated by anonym about 1 month ago

  • Status changed from Confirmed to In Progress

#8 Updated by anonym about 1 month ago

  • % Done changed from 0 to 10
  • Feature Branch set to feature/16792-update-chutney+force-all-tests

The current branch updates chutney, and I've at least verified that tor bootstraps. I saw some initial failures with htpdate (restarting the services fixed it), not sure why is that or if it was a transient thing.

Any way, let's see what a full run looks like.

#9 Updated by anonym 28 days ago

  • % Done changed from 10 to 20

The full test runs look like any other +force-all-tets run, so I see no apparent regressions, yay!

Next step, make the configuration more similar to the real Tor network.

#10 Updated by anonym 28 days ago

We used to get consensuses looking like this:

valid-after 2019-06-26 10:12:00
fresh-until 2019-06-26 10:15:00
valid-until 2019-06-26 10:18:00
voting-delay 4 4

i.e. really short intervals/delays. In the real Tor network it looks like this:
valid-after 2019-06-26 09:00:00
fresh-until 2019-06-26 10:00:00
valid-until 2019-06-26 12:00:00
voting-delay 300 300

I've adjusted the *V3Auth* settings so they now have the same length intervals etc as the real Tor network:
 
valid-after 2019-06-26 11:31:00
fresh-until 2019-06-26 12:31:00
valid-until 2019-06-26 14:31:00
voting-delay 300 300

That should be all we need for #16471, but there are other discrepancies too (e.g. the real Tor network use consensus-method 28 but we get consensus-method 25 for some reason, but this is just an example -- I don't think we care about this one).

Also available in: Atom PDF