Project

General

Profile

Bug #16744

Remove useless pre-generated Pidgin accounts

Added by anonym 3 months ago. Updated 26 days ago.

Status:
Fix committed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
bugfix/16744-remove-useless-pidgin-accounts+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Instant Messaging

Description

Which I guess was missed when we removed I2P?

Related, we still pre-generate an OFTC account as well, which seems useless given we have no presence there any more.


Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed 03/22/2019

Associated revisions

Revision 6a198e7a (diff)
Added by segfault about 1 month ago

Remove pre-generated Pidgin accounts (refs: #16744)

Revision 7324a1ab
Added by intrigeri 26 days ago

Merge remote-tracking branch 'origin/bugfix/16744-remove-useless-pidgin-accounts+force-all-tests' into stable

Fix-committed: #16744

History

#1 Updated by anonym 3 months ago

#2 Updated by anonym 3 months ago

#3 Updated by anonym 3 months ago

#4 Updated by intrigeri 3 months ago

Which I guess was missed when we removed I2P?

Indeed (XXX_NICK_XXX\@127.0.0.1 did not match the grep we did back then). And even if/when we re-add I2P support, I think this pre-generated account brings little value and won't need to come back.

Related, we still pre-generate an OFTC account as well, which seems useless given we have no presence there any more.

I say let's remove it too and then we can remove quite some code that's only there due to generating these accounts.

#5 Updated by segfault about 1 month ago

  • Assignee set to segfault
  • Feature Branch set to bugfix/16744-remove-useless-pidgin-accounts

#6 Updated by segfault about 1 month ago

  • Status changed from Confirmed to In Progress

#7 Updated by segfault about 1 month ago

Removed all code I found related to the pre-generated Pidgin accounts. Let's see if the test suite passes on Jenkins.

Btw, didn't we also have pre-generated XMPP accounts once? Why don't we have those anymore?

#8 Updated by segfault about 1 month ago

  • Subject changed from Pidgin still has a pre-generated I2P account to Remove useless pre-generated Pidgin accounts

#9 Updated by intrigeri about 1 month ago

Let's see if the test suite passes on Jenkins.

Much of features/pidgin.feature is tagged fragile so I suggest you add the +force-all-tests suffix to the name of the branch.

Btw, didn't we also have pre-generated XMPP accounts once?

I don't think we've ever had that. Contrary to IRC, XMPP requires actually registering an account at a provider, which makes this harder.

Back when we switched our chans to XMPP, some folks started working on this problem, and there's surely info in some tickets here and there, but IIRC that did not go very far.

#10 Updated by segfault about 1 month ago

  • Feature Branch changed from bugfix/16744-remove-useless-pidgin-accounts to bugfix/16744-remove-useless-pidgin-accounts+force-all-tests

intrigeri wrote:

Let's see if the test suite passes on Jenkins.

Much of features/pidgin.feature is tagged fragile so I suggest you add the +force-all-tests suffix to the name of the branch.

OK.

Btw, didn't we also have pre-generated XMPP accounts once?

I don't think we've ever had that. Contrary to IRC, XMPP requires actually registering an account at a provider, which makes this harder.

Back when we switched our chans to XMPP, some folks started working on this problem, and there's surely info in some tickets here and there, but IIRC that did not go very far.

OK, then I had a wrong memory.

#11 Updated by segfault about 1 month ago

Built and booted locally, accounts are gone and Pidgin runs without errors. Waiting for test results from Jenkins.

#12 Updated by segfault about 1 month ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

#13 Updated by intrigeri 26 days ago

  • Assignee set to intrigeri

#14 Updated by intrigeri 26 days ago

  • Target version set to Tails_3.16

Code review passes, will now test.

#15 Updated by intrigeri 26 days ago

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Also available in: Atom PDF