Project

General

Profile

Bug #16716

Add submodule in puppet-tails for weblate integration tests

Added by hefee about 1 month ago. Updated 17 days ago.

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Sysadmin
Blueprint:
Starter:
Affected tool:
Translation Platform

Description

The scripts for handling git->weblate also needs to have tests. As the scripts are working with a git repository as input, we need a test repository to construct testcases. I created https://salsa.debian.org/hefee/weblate-scripts-test.git for that purpose and added this as submodule to puppet-tails to run the tests successfully.
IMO adding a submodule there is no issue, as this submodule is only needed for running the tests.
Sure it needs to move to tails infrastructure in future.
The alternative is to clone the repo for every testrun, that would slow down the tests and you are forced to have i-net connection, while running the tests. Or construct the repo everytime on the fly, that makes it harder to look at the testdata.

History

#1 Updated by intrigeri about 1 month ago

Note that puppet-tails is already used as a submodule in our Puppet setup. So what you're asking is having recursive submodules. I suspect that'll make things even harder to understand to some of us. Perhaps we could instead have Puppet clone (and pull from) a standalone test repo itself?

#2 Updated by groente about 1 month ago

  • Assignee changed from groente to hefee
  • QA Check set to Info Needed

hefee wrote:

The scripts for handling git->weblate also needs to have tests. As the scripts are working with a git repository as input, we need a test repository to construct testcases. I created https://salsa.debian.org/hefee/weblate-scripts-test.git for that purpose and added this as submodule to puppet-tails to run the tests successfully.
IMO adding a submodule there is no issue, as this submodule is only needed for running the tests.

tbh, i think this is adding a bit much to what is still primarily a puppet repo. is it perphaps time to create a completely separate repo for the python development for weblate where you can run your tests and only deploy releases in puppet-tails?

#3 Updated by hefee 25 days ago

Both ideas have pros and cons. Let's move this discussion to the sprint, where we anyways need to decide how to go on...

ATM I hold the hefee/dev/translation-server branch with tests, to not pollute the master branch with the test scripts/data.

#4 Updated by intrigeri 17 days ago

  • QA Check deleted (Info Needed)

(Preparing to drop the "QA Check" field as per "[Tails-dev] Proposal: Redmine workflow change".)

Also available in: Atom PDF