Project

General

Profile

Bug #16650

Code submission policy - unclear phrasing

Added by u 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Contributors documentation
Blueprint:
Starter:
Affected tool:

Description

In https://tails.boum.org/contribute/merge_policy/#submit
Paragraph

Assign the ticket to nobody (aka. unassign it from yourself) by default. Unless it's clear to you that nobody on the Foundations Team will be able or willing to do this specific review; in that case, you shall try to find someone else to do the review, and assign the ticket to them.

is unclear.

- This might be due to using the word nobody twice with a different meaning. Consider using "no one"?
- The beginning of the sentence "unless it's clear to you that…" is also unclear, why / how does this work?
- The second part of the paragraph is also unclear, why is it me (you) who needs to find someone else to do the review, how does this happen?

I thought I'll better open this ticket than to send one personal email to intrigeri :)

Associated revisions

Revision 1f5a8c4f (diff)
Added by intrigeri 3 months ago

Clarify how to set the Assignee field when submitting a branch.

As Ulrike pointed out:

- The previous phrasing was very unclear.
- It's hard to guess whether the FT is able and willing to handle
a given review. Better let them decide.
- It's not obvious how one can try to find a reviewer by themselves;
while regular contributors should hopefully have no trouble doing so,
new contributors would be left in doubt.

So let's make the default case "empty the Assignee field" and whoever
is handling the FT's frontdesk role at a given time (for now: yours truly;
some day: rotating role) will dispatch reviews adequately. And hopefully,
other team leads have some kind of view that helps the detect pending
reviews in their own area, without relying on the FT.

refs: #16650

History

#1 Updated by intrigeri 3 months ago

  • Subject changed from Merge policy - unclear phrasing to Code submission policy - unclear phrasing

#2 Updated by intrigeri 3 months ago

  • Status changed from Confirmed to In Progress

#3 Updated by intrigeri 3 months ago

  • Assignee set to u
  • Target version set to Tails_3.14
  • QA Check set to Ready for QA

#4 Updated by intrigeri 3 months ago

@u, I realize I've not mentioned you. Here we go then. Please review :)

#5 Updated by u 3 months ago

  • Assignee deleted (u)
  • QA Check changed from Ready for QA to Pass

@intrigeri: great, thanks!

#6 Updated by intrigeri 3 months ago

  • Status changed from In Progress to Resolved

#7 Updated by intrigeri 3 months ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#8 Updated by anonym 3 months ago

  • Target version changed from Tails_3.13.2 to Tails_3.14

#9 Updated by intrigeri 3 months ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

Also available in: Atom PDF