Project

General

Profile

Bug #16608

Bug #8309: Remove the topIcons GNOME Shell extension

Disable the topIcons GNOME Shell extension in one Tails release

Added by intrigeri 6 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
03/23/2019
Due date:
% Done:

100%

Feature Branch:
bugfix/16608-disable-topicons
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

As suggested on #8310#note-21, in order to learn how much our users rely on this extension and — transitively — on OpenPGP Applet, we should disable this extension for one Tails release. People could still enable it again with 1 command line:

gnome-shell-extension-tool --enable-extension=TopIcons@phocean.net

Besides, the OpenPGP Applet will still be available in the bottom-left semi-hidden sysAtray.

:sajolida: is watching this


Related issues

Related to Tails - Feature #16399: Write release notes for 3.14 Resolved 01/29/2019
Related to Tails - Bug #16709: Re-add the topIcons GNOME Shell extension Resolved
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed
Blocks Tails - Bug #8310: Convert OpenPGP Applet into a proper GNOME Shell extension In Progress 11/16/2016

Associated revisions

Revision 542ce133 (diff)
Added by intrigeri 6 months ago

Disable the TopIcons GNOME Shell extension (refs: #16608)

This extension causes crashes (#11188).

It does not work on Wayland (#8309, #12213) so long-term, we need to remove
it anyway.

So far we've been blocking on the WIP conversion of OpenPGP Applet into a proper
GNOME Shell extension (#8310) but it's no clear whether it's worth the effort.

In order to learn how much our users rely on this extension and — transitively —
on OpenPGP Applet, let's disable this extension for one Tails release. Users who
need it can still enable it again with 1 command line.

Revision 2ad4585d (diff)
Added by intrigeri 5 months ago

Disable the TopIcons GNOME Shell extension (refs: #16608)

This extension causes crashes (#11188).

It does not work on Wayland (#8309, #12213) so long-term, we need to remove
it anyway.

So far we've been blocking on the WIP conversion of OpenPGP Applet into a proper
GNOME Shell extension (#8310) but it's no clear whether it's worth the effort.

In order to learn how much our users rely on this extension and — transitively —
on OpenPGP Applet, let's disable this extension for one Tails release. While
TopIcons is disabled by default:

- Users can still use OpenPGP Applet via the system tray in the bottom
left corner of the desktop.
- Users who do need TopIcons for other reasons can enable it again
with 1 command line.

Revision 774b3f60
Added by segfault 5 months ago

Merge branch 'bugfix/16608-disable-topicons' into stable (Fix-committed: #16608)

History

#1 Updated by intrigeri 6 months ago

#2 Updated by intrigeri 6 months ago

  • Blocks Bug #8310: Convert OpenPGP Applet into a proper GNOME Shell extension added

#3 Updated by intrigeri 6 months ago

  • Description updated (diff)

#4 Updated by intrigeri 6 months ago

  • Feature Branch set to bugfix/16608-disable-topicons

#5 Updated by intrigeri 6 months ago

  • Status changed from Confirmed to In Progress

#6 Updated by intrigeri 6 months ago

I confirm that the command line in the ticket description is sufficient to enable topIcons and display OpenPGP Applet, on an ISO built from the topic branch.

#7 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to segfault
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

CI is happy.

@segfault, perhaps you could batch this with one or two of your other 3.14 reviews? (i.e. merge N branches into a local integration branch so you build & manually test only once)

#8 Updated by segfault 6 months ago

I can do the review, but I don't like the proposal, see #8310#note-27.

#9 Updated by intrigeri 6 months ago

I can do the review, but I don't like the proposal, see #8310#note-27.

ACK, I'll reply there.

#10 Updated by intrigeri 5 months ago

#11 Updated by intrigeri 5 months ago

  • Description updated (diff)

As per discussion on #8310, please go ahead with the review & merge :)

#12 Updated by segfault 5 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check changed from Ready for QA to Dev Needed

The commit message is not accurate:

[...] let's disable this extension for one Tails release. Users who need it can still enable it again with 1 command line.

We don't actually disable the extension, it's still accessible via the system tray in the bottom left corner. As a result, users also don't need to use the command line to enable it again. So I propose we change the commit message.

Beside that, the change LGTM and seems to work.

#13 Updated by intrigeri 5 months ago

  • Assignee changed from intrigeri to segfault
  • QA Check changed from Dev Needed to Ready for QA

We don't actually disable the extension,

Well, this branch does disable the TopIcons extension.

it's still accessible via the system tray in the bottom left corner
As a result, users also don't need to use the command line to enable it again.

These two statements are correct with "it" "OpenPGP Applet", but incorrect if "it" "the TopIcons extension".

So I propose we change the commit message.

ACK, done! (The fact we're having the above discussion makes it clear that there was some misunderstanding so indeed, it's worth updating this commit message, that predated our noticing that OpenPGP Applet was still available in the systray.)

@segfault, please review and merge :)

#14 Updated by segfault 5 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

#15 Updated by segfault 5 months ago

  • Status changed from Fix committed to In Progress
  • % Done changed from 100 to 50
  • QA Check changed from Ready for QA to Pass

intrigeri wrote:

We don't actually disable the extension,

Well, this branch does disable the TopIcons extension.

it's still accessible via the system tray in the bottom left corner
As a result, users also don't need to use the command line to enable it again.

These two statements are correct with "it" "OpenPGP Applet", but incorrect if "it" "the TopIcons extension".

Right, I misunderstood.

#16 Updated by segfault 5 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

#17 Updated by intrigeri 4 months ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#18 Updated by anonym 4 months ago

  • Status changed from Fix committed to Resolved

#19 Updated by anonym 4 months ago

  • Target version changed from Tails_3.13.2 to Tails_3.14

#20 Updated by intrigeri 4 months ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#22 Updated by goupille 4 months ago

Message-ID: <uvzkKngdj_Bz3d6SGHTKTKi5XuNpyBDg4CdcmbHCvneNnlE3gb7TvpmykZpoyimaZzmIZNA_zxGY8ahWTIdWFSj183oZ6yVCKg9ELt2x7Lg=@protonmail.com>

#23 Updated by goupille 4 months ago

Bug report: 4540eede3f658376d7a95963de18f9e0

#24 Updated by goupille 4 months ago

Bug report: f8341e300152d317e435e9a25bbc2801

#25 Updated by goupille 4 months ago

Bug report: fa3f7ffb38cbabdee53b8ed032a543dd

#26 Updated by goupille 4 months ago

Bug report: 104b6546e87e9fe5e9cf149c9da90943

#27 Updated by goupille 4 months ago

Message-ID: <evhmvgR7Hu_hHvJCO8OG8iCF6_sR3jfBFJHtLRhGxl_NGlNMRnKLAzyxsMnzy1Ll6xTVSZY9eDhvEzR9hgtYMzXLe7xfumK5Zgy9UJUAlcM=@protonmail.com>

#28 Updated by goupille 4 months ago

Message-ID: <hVTU9xTrboIeRKvq81bbwN6VFnhljwIClfAIR1CC4OB-kC7akyAJUKE6oJvopJ61PKGbpOeJLY6bmE3zgjn16os3WdfFzfgCHUi7mE0XNS0=@protonmail.com>

#29 Updated by intrigeri 4 months ago

  • Related to Bug #16709: Re-add the topIcons GNOME Shell extension added

#30 Updated by intrigeri 4 months ago

@goupille, thank you!

(Hint: use wb://$ID so it's easier to search for such data with programs :)

#31 Updated by sajolida 4 months ago

  • Description updated (diff)

#32 Updated by goupille 4 months ago

Bug report: 1f13cc0fbea0454d45f9a6dead60d51d

@intrigeri : I think I'd need a hint to understand your hint :)

#33 Updated by goupille 4 months ago

Bug report: 45131749846d7d2315170f082f86f7b3

#34 Updated by goupille 4 months ago

Bug report: 6472484b2a667461b7a3766f1df6a9a7

Message-ID: <>

Bug report: 9b6dc2d4230b69d9cce7982a985565a9

#35 Updated by goupille 4 months ago

Bug report: 80e6cadd30861f7b2e83e889ee08ff37
Message-ID: <>
Message-ID: <CAHoOqk=1=>
Bug report: 929e2ca4292f579931031ed890d75028
Message-ID: <1uEbHUwu11sPaa4dKwNcH7LFH26nH6djBD_1EtSjsuJ8fCbaZul-8lrvr687Y7tpDUC-rzowO1zL95ypF3mvuTCome7gL9ZONBXL0IaVudY=@protonmail.com>

#36 Updated by intrigeri 4 months ago

intrigeri : I think I'd need a hint to understand your hint :)

@goupille, sure: instead of writing "Bug report: 1f13cc0fbea0454d45f9a6dead60d51d" (or random other formats used by other people), let's standardize or a URI-like scheme, which in this example would be wb://1f13cc0fbea0454d45f9a6dead60d51d.

#37 Updated by goupille 4 months ago

@intrigeri: ok, I don't quite understand the why, but I can write it that way for the whisperback reports...

@sajolida: here are the last ones from my shift :

wb://84da32cd623c608004fc48ca620438f0
wb://160152478768a52c6f0f3d6d638c127d
wb://8f5d5a9a40480c5a844ef74593432f89

#38 Updated by mercedes508 4 months ago

#39 Updated by sajolida 4 months ago

"Bug report: 80e6cadd30861f7b2e83e889ee08ff37" is an email subject header while "" is a message id. My mail client ("Thunderbird") has good support for search, filter, and threads based on the subject but no built-in support for message id. So actually, the way goupille has been doing it (subject header for WhisperBack report and message-id for the rest) is the most efficient for me.

#40 Updated by mercedes508 4 months ago

sajolida wrote:

"Bug report: 80e6cadd30861f7b2e83e889ee08ff37" is an email subject header while "" is a message id. My mail client ("Thunderbird") has good support for search, filter, and threads based on the subject but no built-in support for message id. So actually, the way goupille has been doing it (subject header for WhisperBack report and message-id for the rest) is the most efficient for me.

That's exactly what I'm doing.

#41 Updated by intrigeri 4 months ago

My mail client ("Thunderbird") has […] no built-in support for message id.

I believe it does: https://superuser.com/questions/285736/quick-way-to-find-a-specific-email-in-thunderbird-inbox

#42 Updated by sajolida 4 months ago

#43 Updated by intrigeri 4 months ago

It's possible but not out-of-the-box.

I'm under the impression that there's a misunderstanding.
I've followed up with sajolida privately to try to clear it up :)

Also available in: Atom PDF