Project

General

Profile

Bug #16601

Translations don't work in Additional Software

Added by xin 8 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Start date:
03/21/2019
Due date:
% Done:

100%

Feature Branch:
bugfix/16601-fix-translations
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Additional Software Packages

Description

In Tails in French, the text is in English in the Additional Software application and in notifications about Additional Software.
All this content is tranlated in po/fr.po. This bug may be present since 3.9 release.

I also test in Spanish, same problem.

Associated revisions

Revision 8d52449d (diff)
Added by alant 8 months ago

ASP: fix tranlsation

Assigning _ to gettext.gettext in the module to make syntax checkers
happy was rendering the version provided by gettext.install
inaccessible.

Will-fix: #16601

Revision f7f7cdfc (diff)
Added by segfault 3 months ago

Fix ASP's configuration-window.ui not being translated (refs: #16601)

While using create_pot with prog=Glade does add the strings to the POT
file, the translations from the PO file are not being used.
Using intltool-merge --xml-style instead fixes this.

Revision efaa4176 (diff)
Added by segfault 3 months ago

Fix ASP's configuration-window.ui not being translated (refs: #16601)

While using create_pot with prog=Glade does add the strings to the POT
file, the translations from the PO file are not being used.
Using intltool-merge --xml-style instead fixes this.

Revision 907c65d4 (diff)
Added by segfault 3 months ago

ASP: Set gettext domain to "tails" in confguration-window.ui (refs #16601)

Revision e36156c7 (diff)
Added by segfault 3 months ago

ASP: Make window title translatable (refs: #16601)

Revision 63ef291c
Added by intrigeri 3 months ago

Merge remote-tracking branch 'origin/bugfix/16601-fix-translations' into stable (Fix-committed: #16601)

History

#1 Updated by xin 8 months ago

  • Subject changed from Translations doesn't work in Additional Software to Translations don't work in Additional Software

#2 Updated by alant 8 months ago

  • Status changed from New to In Progress
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16601-fix-translations

#3 Updated by intrigeri 6 months ago

  • Status changed from In Progress to Needs Validation

#4 Updated by segfault 3 months ago

  • Assignee changed from alant to segfault

The strings from configuration-window.ui are still not being translated, even though the translations are in the PO file. I had the same issue with unlock-veracrypt-volumes and will implement the same fix, i.e. use intltool_merge_xml on the .ui file.

#5 Updated by segfault 3 months ago

  • Status changed from Needs Validation to In Progress

#6 Updated by segfault 3 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

Code review for Alan's commit passes, my commit still has to be reviewed.

#7 Updated by segfault 3 months ago

  • Status changed from Needs Validation to In Progress

#8 Updated by segfault 3 months ago

  • Assignee set to segfault

This still doesn't work. I suspect that's because domain="tails" is missing in the configuration-window.ui. Maybe that was the issue all along and we don't have to use intltool_merge_xml. Will test that.

#9 Updated by segfault 3 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

segfault wrote:

This still doesn't work. I suspect that's because domain="tails" is missing in the configuration-window.ui. Maybe that was the issue all along and we don't have to use intltool_merge_xml. Will test that.

That was indeed the case.

#10 Updated by segfault 3 months ago

  • Status changed from Needs Validation to In Progress

#11 Updated by segfault 3 months ago

  • Status changed from In Progress to Needs Validation

#12 Updated by intrigeri 3 months ago

  • Target version set to Tails_3.16

#13 Updated by intrigeri 3 months ago

  • Assignee set to intrigeri

#14 Updated by intrigeri 3 months ago

Code review passes, will now test.

#15 Updated by intrigeri 3 months ago

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

#16 Updated by CyrilBrulebois 2 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF