Project

General

Profile

Bug #16568

Bug #10976: persistence.conf lost, recoverable by reconfiguring

Make writing persistence.conf.bak more robust

Added by intrigeri 2 months ago. Updated 16 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Persistence
Target version:
Start date:
03/17/2019
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
t-p-s:bugfix/16568-more-robust-backup, bugfix/16568-more-robust-backup
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

… as suggested on #16461#note-13:

  • I've checked and indeed, it would make sense to sync that file after copying.
  • The chattr part is not needed as long as 1. t-p-s sync's the file; 2. t-p-s is the only component that modifies that file (which is the case currently). But I guess it wouldn't hurt and who knows, something else might start modifying that file at some point. Let's do it.

Related issues

Related to Tails - Feature #14544: Spend software developer time on smallish UX improvements In Progress 08/31/2018
Related to Tails - Bug #16461: Backup persistence.conf before modifying it in t-p-s Resolved 02/12/2019
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed 03/22/2019

Associated revisions

Revision a9e9bbd1 (diff)
Added by intrigeri 27 days ago

Import tails-persistence-setup branch bugfix/16568-more-robust-backup (refs: #16568)

… at commit b111137caf01c84e15db39f82799e68a044b76f1.

Revision 1622e925 (diff)
Added by intrigeri 23 days ago

Replace t-p-s patch with the bugfix-16568-more-robust-backup APT overlay (refs: #16568).

t-p-s 2.1.1-1 includes this patch and is in that overlay.

This reverts commit a9e9bbd12c88ae6158e72e9adb3e49a4723dee49.

Revision 232e603e
Added by intrigeri 23 days ago

Merge branch 'bugfix/16568-more-robust-backup' into stable

Fix-committed: #16568

History

#1 Updated by intrigeri 2 months ago

#2 Updated by intrigeri 2 months ago

  • Related to Feature #14544: Spend software developer time on smallish UX improvements added

#3 Updated by intrigeri 2 months ago

  • Related to Bug #16461: Backup persistence.conf before modifying it in t-p-s added

#4 Updated by intrigeri 2 months ago

  • Priority changed from Elevated to Normal

#5 Updated by intrigeri 27 days ago

  • Status changed from Confirmed to In Progress
  • Feature Branch set to t-p-s:bugfix/16568-more-robust-backup, bugfix/16568-more-robust-backup

#6 Updated by intrigeri 25 days ago

  • Assignee deleted (intrigeri)
  • QA Check set to Ready for QA

Relevant test suite scenarios pass.

@anonym, @segfault, anyone up for a review? I expect it'll be a cursory one, as usual for our Perl code.

#7 Updated by segfault 25 days ago

  • Status changed from In Progress to Fix committed
  • QA Check changed from Ready for QA to Pass

LGTM. I merged the t-p-s branch. I see you created a patch on bugfix/16568-more-robust-backup. I assume you want to use that until we release a new t-p-s version? If so I would merge the branch in to stable and skip releasing a new t-p-s version.

#8 Updated by segfault 25 days ago

  • Status changed from Fix committed to In Progress
  • Assignee set to segfault
  • QA Check changed from Pass to Ready for QA

#9 Updated by intrigeri 24 days ago

  • Assignee changed from segfault to intrigeri
  • QA Check changed from Ready for QA to Dev Needed

LGTM. I merged the t-p-s branch.

@segfault, thank you.

I see you created a patch on bugfix/16568-more-robust-backup. I assume you want to use that until we release a new t-p-s version? If so I would merge the branch in to stable and skip releasing a new t-p-s version.

I'd rather not ship 3.14 with this patch in tails.git: it makes it harder to analyze what code we shipped in which Tails version. So I'll release a new t-p-s, will upload to the topic branch's APT overlay, and drop the patch. Then I'll merge into stable. Shout if this does not make sense :)

#10 Updated by intrigeri 23 days ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

#11 Updated by intrigeri 23 days ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Dev Needed to Pass

That's 2.1.1-1.

#12 Updated by intrigeri 18 days ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#13 Updated by anonym 17 days ago

  • Status changed from Fix committed to Resolved

#14 Updated by anonym 17 days ago

  • Target version changed from Tails_3.13.2 to Tails_3.14

#15 Updated by intrigeri 16 days ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

Also available in: Atom PDF