Project

General

Profile

Bug #16566

Bug #15957: Additional Software install step sometimes tries to download packages

Additional Software upgrade fails when APT lists are not uptodate at startup

Added by alant 2 months ago. Updated 3 days ago.

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
03/16/2019
Due date:
% Done:

100%

QA Check:
Dev Needed
Feature Branch:
bugfix/16566-asp-dl-failure-case-C-with-notification
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Additional Software Packages

Description

case C: a new Tails release including new apt lists is installed. Then the right version of the packages are not in the cache. If user is not connected to the Internet/Tor is not ready when the Gnome session is ready, then tails-additional-software-install.service fails. As a consequence, tails-additional-software-update.path is never run and the problem is not solved until the user starts a session when already connected to Tor (= cable + fast connection).


Related issues

Related to Tails - Bug #16567: Additional Software should upgrade packages after APT lists update Confirmed 03/16/2019

Associated revisions

Revision 15240dd6 (diff)
Added by alant 2 months ago

ASP: suggest to connect in install failure

Will-fix: #16566

Revision 04ed66e1
Added by intrigeri 2 months ago

Merge remote-tracking branch 'origin/bugfix/16566-asp-dl-failure-case-C' into stable (Fix-committed: #16566)

History

#1 Updated by intrigeri 2 months ago

  • Feature Branch changed from bugfix/15957-asp-dl-failure-case-C to bugfix/16566-asp-dl-failure-case-C

#2 Updated by intrigeri 2 months ago

Code review passes. It looks like we'll have CI results in ~1h. If I see no regression there I'll happily merge.

#3 Updated by intrigeri 2 months ago

intrigeri wrote:

It looks like we'll have CI results in ~1h.

The 1st run had a bit too many failures on non-fragile scenarios for my taste, so I triggered another one. Will come back to it tomorrow.

#4 Updated by alant 2 months ago

Also I thought that with only this fix (and not the fix for cases A and B) there are more chances that errors will be fixed by the update/upgrade when going online. So I suggest we change the installation error notifications from:

The installation of your additional software failed

to:

The installation of your additional software failed. This may be solved by connecting to Internet.

I can proposed a branch bugfix/16566-asp-dl-failure-case-C-with-notification for that but I'm worried it breaks the test suite.

#5 Updated by alant 2 months ago

  • Status changed from Confirmed to In Progress

#6 Updated by intrigeri 2 months ago

Also I thought that with only this fix (and not the fix for cases A and B) there are more chances that errors will be fixed by the update/upgrade when going online. So I suggest we change the installation error message from: […] to: […]

I think it's too late in this cycle to change strings and have them go through sajolida ⇒ please file a dedicated ticket about it if you think it's worth it (I did not think about it yet; if you want my opinion, I could do that :)

I can propose a branch for that but I'm worried it breaks the test suite.

No worries: if it does, it'll be easy to spot and to fix. I might be stating the obvious, but the test suite's job is to validate the implementation, not to force it to remain as-is.

#7 Updated by intrigeri 2 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

#8 Updated by intrigeri 2 months ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Merged! I have good hopes this will fix the most important part of #15957 in practice :)

#9 Updated by alant 2 months ago

  • Status changed from Fix committed to Confirmed
  • Target version changed from Tails_3.13 to Tails_3.14
  • QA Check changed from Pass to Ready for QA
  • Feature Branch changed from bugfix/16566-asp-dl-failure-case-C to bugfix/16566-asp-dl-failure-case-C-with-notification

I changed the branch for the one adding "This may be solved by connecting to Internet." on the install failure notification. This is ready for 3.14.

#10 Updated by intrigeri 2 months ago

  • Assignee set to alant
  • QA Check changed from Ready for QA to Info Needed

Please:

  1. Sum up for sajolida in which situation the modified string will appear and what's the proposed string change (I know all this can be found by reading the full history of this ticket + some of its parent ticket + perhaps some of the blueprint but I'm pretty sure sajolida would rather answer a simple question spelled out in one single Redmine comment :)
  2. Reassign to sajolida as "Info Needed".

Thanks in advance!

#11 Updated by alant about 2 months ago

  • Assignee changed from alant to sajolida
  1. Sum up for sajolida in which situation the modified string will appear and what's the proposed string change

When ASP install at startup fails, the string was:

"The installation of your additional software failed"

Every new Tails release, the install fails and this is solved by connecting to Internet. The proposed string is:

"The installation of your additional software failed This may be solved by connecting to Internet."

#12 Updated by sajolida about 1 month ago

  • Assignee changed from sajolida to alant
  • QA Check changed from Info Needed to Dev Needed

It's good! (except it's "*the Internet").

This one is a bit more polite and shorter:

"The installation of your additional software failed. Please try to connect to the Internet."

#13 Updated by u about 1 month ago

  • Related to Bug #16567: Additional Software should upgrade packages after APT lists update added

#14 Updated by CyrilBrulebois 3 days ago

  • Target version changed from Tails_3.14 to Tails_3.15

Also available in: Atom PDF