Project

General

Profile

Bug #16406

release_process: missing 'cd' call for signature generation

Added by CyrilBrulebois 22 days ago. Updated 7 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
01/29/2019
Due date:
% Done:

0%

QA Check:
Feature Branch:
Type of work:
Contributors documentation
Blueprint:
Starter:
Affected tool:

Description

The following is incomplete:

1. Create an armoured detached signature for each created or modified
   upgrade-description file.

        find "${RELEASE_CHECKOUT:?}/wiki/src/upgrade/" \
           -type f -name upgrades.yml | \
           while read udf; do
               if [ -n "$(git status --porcelain "${udf:?}")" ]; then
                   for x in 1 2 3; do
                       gpg -u "${TAILS_SIGNATURE_KEY:?}" --armor \
                           --detach-sign "${udf:?}" \
                       && break
                   done
                   mv --force "${udf:?}.asc" "${udf:?}.pgp" 
                   ( \
                     cd ${IUK_CHECKOUT:?} && \
                     ./bin/tails-iuk-check-upgrade-description-file "${udf:?}" \
                   ) || break
               fi
           done

The find call with an absolute path could look good, but there are some git commands being called in the loop, which needs to happen in the checkout. I suggest adding cd ${RELEASE_CHECKOUT:?} at the very beginning to avoid such issues.

Associated revisions

Revision 751bf1ac (diff)
Added by anonym 7 days ago

Release process: add missing `cd` (Fix-committed: #16406).

The `git` calls depend on that we're in the release checkout.

History

#1 Updated by anonym 7 days ago

  • Status changed from Confirmed to Resolved
  • Assignee deleted (anonym)
  • Target version set to Tails_3.12.1

Also available in: Atom PDF