Project

General

Profile

Bug #16365

Rebase our custom NetworkManager package on top of 1.6.2-3+deb9u2

Added by intrigeri 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
-
Target version:
Start date:
01/16/2019
Due date:
% Done:

100%

Feature Branch:
bugfix/16365-update-network-manager
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Tails 3.11 has 1.6.2-3+0.tails1, current devel branch has 1.6.2-3+deb9u2. Presumably we need to rebase our custom package.


Related issues

Related to Tails - Bug #11720: DHCP requests leak hostname on Stretch Resolved 08/25/2016
Related to Tails - Feature #12306: Rebase our custom NetworkManager package on 1.6.2-1 Resolved 03/08/2017
Blocks Tails - Feature #15507: Core work 2019Q1: Foundations Team Resolved 04/08/2018

Associated revisions

Revision 40809965 (diff)
Added by intrigeri 6 months ago

Test suite: really test that we don't leak "amnesia" in DHCP requests (refs: #16365)

On Tails 3.11, hostname(1) returns… "localhost.localdomain".
I assume that's been the case since #13574 and #15322.
So we were not testing whether "amnesia" leaks in DHCP requests anymore.

Let's check for both "amnesia" and whatever hostname(1) returns.

Revision ff0b71ab (diff)
Added by intrigeri 6 months ago

Enable the bugfix-16365-update-network-manager APT overlay (refs: #16365).

Revision 15b53959
Added by anonym 6 months ago

Merge remote-tracking branch 'origin/bugfix/16365-update-network-manager' into testing (Fix-committed: #16365)

History

#1 Updated by intrigeri 6 months ago

  • Subject changed from Rebase our custom NetworkManager package to Rebase our custom NetworkManager package on top of 1.6.2-3+deb9u2

#2 Updated by intrigeri 6 months ago

#3 Updated by intrigeri 6 months ago

  • Related to Bug #11720: DHCP requests leak hostname on Stretch added

#4 Updated by intrigeri 6 months ago

  • Related to Feature #12306: Rebase our custom NetworkManager package on 1.6.2-1 added

#5 Updated by intrigeri 6 months ago

  • Status changed from Confirmed to In Progress

#6 Updated by intrigeri 6 months ago

  • % Done changed from 0 to 10

OK, I'm very confused. I was expecting dhcp.feature to tell us about this as soon as our custom package was superseded by a newer one, coming from Debian, on the devel branch. Either dhcp.feature is buggy and succeeds when it should fail, or we don't need this patch anymore.

I've tracked this down to a bug in our test suite and pushed a tentative fix. This should make the test suite fail until a new NM is uploaded, which is good. Will now update our NM package.

#7 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16365-update-network-manager

Uploaded 1.6.2-3+deb9u2+0.tails1, enabled the corresponding APT overlay. I can't really spend more time on this before the freeze; mayyybe tomorrow night but don't count on it. so I've tried to do the best I could so that if everything goes fine, it's super cheap to validate and merge my work (and worst case, to follow-up on it):

So, if my theory + fix are correct:

#8 Updated by intrigeri 6 months ago

  • % Done changed from 10 to 50

intrigeri wrote:

So, if my theory + fix are correct:

Confirmed.

#9 Updated by anonym 6 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

#10 Updated by anonym 6 months ago

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Looks good! I manually tested on bare metal that various network-manager related things worked, and everything worked as usual. Merged!

#11 Updated by anonym 6 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF