Project

General

Profile

Bug #16355

Test suite: please detect and warn about “Known issues”…

Added by CyrilBrulebois 10 months ago. Updated 2 months ago.

Status:
In Progress
Priority:
Normal
Category:
Test suite
Target version:
-
Start date:
01/14/2019
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

So I've discovered the fun related to #12142 (i.e. https://bugs.debian.org/851694), after having wasted quite some time on the USB test suite development (#16004).

It has been freshly documented in master (7a6bddabe047a8ba9fb554fc3442d4fa1260e8e1 -- by the way, why not mention the binaries available in the same suite, instead of suggesting a local rebuild?), but I'd hate it to see others (maybe future me with a different setup) lose time over this again.

I'm therefore proposing an extra check, ensuring we have the known good qemu version when running on Debian stretch. This should be a no-op on the isotesters, which have this version installed already.

FWIW, this might also be the reason why I've had so many issues with snapshots while working on the test suite updates for feature/buster (#16314)… I'm currently checking this hypothesis, and will update #16314 accordingly.

Target branches: devel and feature/buster.

0001-Test-suite-check-for-known-issues-to-avoid-wasting-t.patch View (2.02 KB) CyrilBrulebois, 01/14/2019 03:03 AM


Related issues

Related to Tails - Feature #15864: Make onboarding of new developers easier In Progress 08/30/2018

Associated revisions

Revision f787d13c (diff)
Added by intrigeri 2 months ago

Test suite setup doc: move the need for a patched QEMU to the "Other requirements" section (refs: #16355).

This of course does not fully fix #16355, but at least, let's put this very much
needed piece of information to a section that anyone who goes through this setup
process must read, instead of leaving it in a "Known issues" section that can
easily be skipped.

History

#1 Updated by CyrilBrulebois 10 months ago

  • Description updated (diff)

#2 Updated by intrigeri 10 months ago

  • Status changed from New to In Progress
  • Assignee changed from intrigeri to CyrilBrulebois

by the way, why not mention the binaries available in the same suite, instead of suggesting a local rebuild?),

I was assuming that at least some developers would be reluctant to add third-party binary APT sources, i.e. to trust our infra to be root on their system. Perhaps I was overly cautious? I'm fine adding the binary APT source if you want.

but I'd hate it to see others (maybe future me with a different setup) lose time over this again.

OK!

I'm therefore proposing an extra check, ensuring we have the known good qemu version when running on Debian stretch. This should be a no-op on the isotesters, which have this version installed already.

Code looks good to me. Please push this to a branch so we confirm it's a no-op on Jenkins before we deploy it :)

#3 Updated by intrigeri 6 months ago

  • Status changed from In Progress to Needs Validation

#4 Updated by intrigeri 3 months ago

  • Status changed from Needs Validation to Confirmed

Since then, we've updated QEMU a few times, so I'm wondering if the benefits of hard-coding the exact desired version is worth its maintenance cost. After thinking about it again, I'm also not enthusiastic at the idea of having to coordinate upgrading our QEMU package on all Jenkins workers, with having the corresponding version number updated in all relevant branches in tails.git: the coupling is a bit too tight for it to be practical.

Another option, that has none of these drawbacks, would be to check that we've got a Tails QEMU custom package, i.e. version ends with .0tailsN, installed. It's of course less powerful (although we've not needed the extra power so far), but it would be sufficient to catch the typical problem experienced by folks who run the test suite for the first time on a given system, that is running QEMU from Debian.

If we agree on something here that does not require substantially more work than what you did already, I could try to submit a branch so that future contributors benefit from your feedback, that triggered this ticket+patch :)

#5 Updated by intrigeri 3 months ago

  • Related to Feature #15864: Make onboarding of new developers easier added

#6 Updated by intrigeri 2 months ago

  • Status changed from Confirmed to In Progress

Also available in: Atom PDF