Project

General

Profile

Bug #16338

Tor Launcher is not localized

Added by anonym 6 days ago. Updated about 12 hours ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
01/10/2019
Due date:
% Done:

0%

QA Check:
Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

Regression introduced when migrating to Tor Browser 8.x in Tails 3.9~rc1 (Tails 3.8 with the last Tor Browser 7.5.x release is fine).


Related issues

Blocks Tails - Feature #15507: Core work 2019Q1: Foundations Team Confirmed 04/08/2018

Associated revisions

Revision 4a32a553 (diff)
Added by anonym 6 days ago

Fix localization for Tor Launcher.

Regression introduced when migrating to Tor Browser 8.x in Tails
3.9~rc1.

Will-fix: #16338

History

#1 Updated by anonym 6 days ago

#2 Updated by anonym 6 days ago

Here's the fix:

--- a/config/chroot_local-includes/usr/local/bin/tor-launcher
+++ b/config/chroot_local-includes/usr/local/bin/tor-launcher
@@ -18,8 +18,11 @@ fi

 PROFILE="${HOME}/.tor-launcher/profile.default" 
 if [ ! -d "${PROFILE}" ]; then
-  mkdir -p "${PROFILE}" 
-  configure_best_tor_launcher_locale "${PROFILE}" 
+    mkdir -p "${PROFILE}/extensions" 
+    for ext in "${TBB_EXT}"/langpack-*.xpi; do
+        ln -s "${ext}" "${PROFILE}/extensions" 
+    done
+    configure_best_tor_launcher_locale "${PROFILE}" 
 fi

 exec_unconfined_firefox \

However, since we probably have to rework everything Tor Launcher-related (#15709) we might want to hold off on this, and possibly just reject it.

#3 Updated by intrigeri 6 days ago

However, since we probably have to rework everything Tor Launcher-related (#15709) we might want to hold off on this, and possibly just reject it.

My take on this is: batch this with the branch + build + test + QA for the Tor Browser upgrade in 3.12, so it'll come almost for free. And if that's not possible or does not work, reject.

#4 Updated by anonym 6 days ago

  • Status changed from Confirmed to In Progress

#5 Updated by anonym 6 days ago

Thanks, intri, that's a great idea!

#6 Updated by anonym about 12 hours ago

Wow, I was very confused and pushed this to the feature/16337-tor-browser-8.5+force-all-test. Dropped from that branch + force-pushed, FWIW.

Also available in: Atom PDF