Project

General

Profile

Feature #16337

Upgrade to Tor Browser 8.5

Added by anonym 3 months ago. Updated 8 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
03/15/2019
Due date:
% Done:

100%

QA Check:
Feature Branch:
feature/16337-tor-browser-8.5+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

The Tor Browser roadmap has useful bits about this: https://pad.riseup.net/p/tbb-roadmap-2018-19


Subtasks

Feature #16561: Upgrade doc to Tor Browser 8.5Resolved


Related issues

Related to Tails - Feature #15807: Define & apply clear criteria for including dictionaries, fonts and language packs In Progress 08/18/2018
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed 03/22/2019

Associated revisions

Revision 401cf0f4 (diff)
Added by anonym 29 days ago

Upgrade Tor Browser to 8.5a8 (Refs: #16337).

Using tp.o/dist instead of uploading to torbrowser-archive since we
won't release these tarballs and thus don't need to store them
forever.

History

#1 Updated by anonym 3 months ago

  • Status changed from Confirmed to In Progress
  • Assignee set to anonym
  • Feature Branch set to feature/16337-tor-browser-8.5+force-all-tests

Initial testing looks great, no problems found at all actually. But the upstream changes for #15709 and #16048 has not landed upstream yet, and they definitely will require some work on our side.

#2 Updated by anonym 3 months ago

#3 Updated by intrigeri about 2 months ago

8.5a7 is available but I don't think it has any of the big changes yet. See subtasks for the ongoing communication with upstream, which is basically the only thing we can do at the moment.

#4 Updated by intrigeri about 2 months ago

  • Target version changed from Tails_3.13 to Tails_3.14

See email from geko on tails-dev.

#5 Updated by intrigeri about 2 months ago

  • Due date set to 03/17/2019
  • Target version changed from Tails_3.14 to Tails_3.13
  • Start date deleted (07/03/2018)

After some more discussion with Georg, it appears that the big changes that were initially meant to land in TB 8.5, and that we expected would require substantial amounts of work on our side, are all postponed to TB 9.0. I've updated all our corresponding tickets accordingly. So there's a good chance that the upgrade to 8.5 does not require too much work on our side :) Now, it postpones big chunks of work to August-September (latest), which is not ideal as we'll have to deal with Firefox 68 and Buster too, but we'll cope.

And regarding the timing of this work, the conclusion is that we don't know yet when we'll need to ship Tor Browser 8.5:

  • Worst case, we might have to do that at any unscheduled time between the last week of March (Pwn2Own) and mid-May (scheduled 3.14 release) if there's an emergency release and 8.5 is ready for prime time.
  • Best case, we have to do that in Tails 3.14.

So I think we should:

  • Keep the branch up-to-date with the latest Tor Browser 8.5 pre-releases.
  • Keep an eye on test suite results.
  • At some point, I would say by mid-March, "run" the parts of the manual test suite that are affected by this upgrade.

… and then we should be ready to switch to 8.5 at any time dictated by external circumstances.

anonym, segfault: does this make sense to you? Can you handle this by yourselves or will you need help from other FT people?

#6 Updated by intrigeri about 1 month ago

@anonym, I'm working on #16177 and I'm curious about what exact problem aca28cec16287befd7dbadbfee7834c153936b04 solved for you. If that was about mksquashfs getting killed:

  • gzip compression or xz?
  • Building in RAM or not?
  • Please try to revert this commit and retry with bugfix/16177-limit-mksquashfs-memory-usage merged into your branch.

If that's really about "disk" space, then fine, forget this.

#7 Updated by anonym 29 days ago

Note to self: I already replied to the above comment on the relevant ticket.

I've updated to 8.5a8 and booted an image and done some rudimentary testing. The only change I've noticed is the new Tor Browser icon (but we don't even use it in our test suite!) which agrees with my reading of the changelogs. Tor Browser 8.5.x seems like it will be an easy bump for us.

Let's see what Jenkins thinks: https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-16337-tor-browser-8.5-force-all-tests/7

#8 Updated by anonym 26 days ago

  • % Done changed from 0 to 20

Jenkins likes 8.5a8!

(The only browser related failure is the "Watching a WebM video over HTTPS" scenario, but it is fragile and is failing on other +force-all-tests branches too.)

#9 Updated by intrigeri 15 days ago

  • Assignee changed from anonym to intrigeri

#10 Updated by intrigeri 15 days ago

  • Related to Feature #15807: Define & apply clear criteria for including dictionaries, fonts and language packs added

#11 Updated by intrigeri 15 days ago

There's nothing newer than 8.5a8 tagged in Git at the moment and the master branch of builders/tor-browser-build.git has almost only Android-related changes since tbb-8.5a8-build2.

The output of git diff tbb-8.0.6-build1.. -- projects/firefox/abicheck.cc projects/firefox/start-firefox projects/tor-browser/RelativeLink/start-tor-browser is empty.

Reverted the installation of additional dictionaries: 353dd4d3ae6aa5defb821ba2b537df999d648087 explains why.

Tested "Watching a WebM video over HTTPS" manually, works fine.

Next step (perhaps after 8.5a9 or beta or RC something is out?): "run" our manual test suite on an image built from this branch. Our automated tests coverage is rather low for Tor Browser and we've often found issues only via manual testing.

#12 Updated by intrigeri 15 days ago

intrigeri wrote:

Next step (perhaps after 8.5a9 or beta or RC something is out?): "run" our manual test suite on an image built from this branch. Our automated tests coverage is rather low for Tor Browser and we've often found issues only via manual testing.

Actually this must happen sooner rather than later due to the risk Pwn2Own decides when Tor Browser 8.5 is released as stable (#16337#note-5).

@sajolida: note that the Tor Browser icon is brand new in this release, so we'll probably need some doc update; I'm told the security slider is getting a redesign but I didn't check if this got merged yet nor whether it affects our doc. Our tech writers can start this work right now if you want, using https://nightly.tails.boum.org/build_Tails_ISO_feature-16337-tor-browser-8.5-force-all-tests/lastSuccessful/archive/build-artifacts/. Feel free to push doc updates directly to the topic branch for this ticket. Ideally this would be ready by March 23, in case we have to ship this in the last week of March due to Pwn2Own.

#13 Updated by intrigeri 15 days ago

Update after attending the Tor Browser weekly meeting: the post-Pwn2Own release won't be 8.5. There'll be some other 8.5 alphas, perhaps a last one near the end of March, and then ~1 week before the release. So we "only" need all this ready, to be on the safe side, by the end of March, so that we are ready to ship Tor Browser 8.5 in Tails 3.14 (best case) or 3.13.x (worst case; could happen that we need this any time between end of March and 3.14).

#14 Updated by intrigeri 14 days ago

  • Due date changed from 03/17/2019 to 03/31/2019
  • Priority changed from Elevated to High
  • Target version changed from Tails_3.13 to Tails_3.14

#15 Updated by intrigeri 9 days ago

Next step: upgrade to 8.5a9 and "run" our manual test suite on an image built from this branch.

#16 Updated by intrigeri 8 days ago

intrigeri wrote:

Next step: upgrade to 8.5a9

Done, let's see what Jenkins thinks.

#17 Updated by intrigeri 8 days ago

upgrade to 8.5a9 and "run" our manual test suite on an image built from this branch.

Done, manual test suite passes.

#18 Updated by intrigeri 8 days ago

intrigeri wrote:

intrigeri wrote:

Next step: upgrade to 8.5a9

Done, let's see what Jenkins thinks.

Passes the full test suite (except a few fragile tests that are unrelated to Tor Browser) locally.

So I think we're as ready as we can be at this point. Let's wait for the next upstream alpha/beta/RC.

#19 Updated by intrigeri 6 days ago

#20 Updated by intrigeri 6 days ago

Also available in: Atom PDF