Project

General

Profile

Bug #16286

zenity dialogs are too high in Buster

Added by CyrilBrulebois 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
01/05/2019
Due date:
% Done:

100%

QA Check:
Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

We have a patched zenity (3.22.0-1+tails1) in stretch-based Tails, to handle width vs. height issues with dialogs, e.g. for Unsafe Browser. It seems we would need to refresh/reapply its 0001-Fix-message-dialog-width-and-height-on-recent-Gtk.patch patch on top of the buster zenity package (3.30.0-2).

tails-zenity.png View - Starting Unsafe Browser (56.5 KB) CyrilBrulebois, 01/05/2019 11:14 AM

Associated revisions

Revision b55398e8 (diff)
Added by intrigeri 3 months ago

Pass --ellipsize to zenity (refs: #16286)

This fixes dialog width and height on Buster:
https://gitlab.gnome.org/GNOME/zenity/commit/3b64d05e8a1aae1581d2bec7288d80ac4699e1b1

Revision ca8acc1f (diff)
Added by intrigeri 3 months ago

Import iuk.git's feature/buster branch at commit 919335e (refs: #16286)

History

#1 Updated by CyrilBrulebois 3 months ago

#2 Updated by intrigeri 3 months ago

  • Status changed from New to Confirmed
  • Assignee set to intrigeri

Will take a first look.

#3 Updated by intrigeri 3 months ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

Thankfully, no need to patch anymore: https://gitlab.gnome.org/GNOME/zenity/commit/3b64d05e8a1aae1581d2bec7288d80ac4699e1b1 and https://bugzilla.gnome.org/show_bug.cgi?id=780268. I'll pass --ellipsize to zenity everywhere relevant.

#4 Updated by intrigeri 3 months ago

  • Subject changed from Patched zenity needed for buster to zenity dialogs are too high in Buster

#5 Updated by intrigeri 3 months ago

  • % Done changed from 10 to 20
  • QA Check set to Ready for QA

Done, will now test. Affected at least in some cases: Electrum, KeePassX, security check, Upgrader, Tor Browser (when started offline), Unsafe Browser.

#6 Updated by intrigeri 3 months ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 20 to 100
  • QA Check deleted (Ready for QA)

Tested the Tor Browser and Unsafe Browser bits, looks good.

#7 Updated by CyrilBrulebois 3 months ago

Yes, we've seen various zenity-based dialogs that looked good; thanks.

Also available in: Atom PDF