Project

General

Profile

Bug #16240

proofread/review test.mdwn

Added by CyrilBrulebois 4 months ago. Updated 4 months ago.

Status:
In Progress
Priority:
Normal
Category:
-
Target version:
-
Start date:
12/22/2018
Due date:
% Done:

0%

QA Check:
Ready for QA
Feature Branch:
Type of work:
Contributors documentation
Blueprint:
Starter:
Affected tool:

Description

While preparing 3.11, I noticed the “It's design” typo in wiki/src/contribute/release_process/test.mdwn so I took another look later.

Also “such is” → “such as”.

I've noticed the ifconfig | grep inet | grep -v inet6 | cut -d" " -f2 | tail -n1 instruction which can't work since we don't have net-tools in Tails, and I've checked that there's no ifconfig wrapper. I'm getting an empty string on stretch anyway…

What about this? ip a|awk '/inet / {print $2}' | tail -n1 We get an extra subnet mask though, e.g. 10.0.2.15/24 but 1. it can be sed'd out, and 2. that's still better than “ifconfig: command not found”?

Also:

  1. Then check that email's headers once received, especially the
     `Received:` one.

one→ones? (There are likely several of them.)

Also I don't really understand what is meant here: «  * Call the upgrader must be called, […] ”

Also double is here: “The goal is is to check”.

I'm attaching a partial patch for the issues that seem obvious to me.

0001-release_process-test-fix-some-typos.patch View (1.8 KB) CyrilBrulebois, 12/22/2018 11:05 PM

Associated revisions

Revision 6a5aaa6c (diff)
Added by CyrilBrulebois 4 months ago

release_process/test: fix some typos (refs: #16240)

Revision 910fc89b (diff)
Added by intrigeri 4 months ago

Manual test suite: don't let testers think they should run this command (refs: #16240).

Revision 01f1c339 (diff)
Added by intrigeri 4 months ago

Manual test suite: there are probably multiple Received headers (refs: #16240).

Revision bcbe9050 (diff)
Added by intrigeri 4 months ago

Manual test suite: fix buggy sentence (refs: #16240).

History

#1 Updated by mercedes508 4 months ago

  • Status changed from New to Confirmed

#2 Updated by CyrilBrulebois 4 months ago

  • Status changed from Confirmed to In Progress

#3 Updated by intrigeri 4 months ago

  • Assignee set to CyrilBrulebois
  • QA Check set to Ready for QA

I've noticed the ifconfig | grep inet | grep -v inet6 | cut -d" " -f2 | tail -n1 instruction

It's not a command testers must run: it's literally what the website should display. Clarified with 910fc89b7598a53ea253b1cbf0327c73debbf64b to avoid confusion.

>   1. Then check that email's headers once received, especially the
>      `Received:` one.
> 

one→ones? (There are likely several of them.)

This will probably go away with #15914 but still, fixed with 01f1c3390ab739e8af79e968ea1b64aa5fe3a8ed.

Also I don't really understand what is meant here: «  * Call the upgrader must be called, […] ”

bcbe9050d2f83ef3e1f86afc57e6492041ae804c

I'm attaching a partial patch for the issues that seem obvious to me.

Applied, thanks!

Please review my fixes, which I pushed straight to the master branch given how trivial that was.

Also available in: Atom PDF