Project

General

Profile

Bug #16206

Consider dropping CSS hack for uBlock Origin sidebar

Added by intrigeri 6 months ago. Updated 16 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
12/08/2018
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
bugfix/16206-drop-ublock-origin-css-hack
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

This:

ublock-origin (1.17.0+dfsg-1) unstable; urgency=medium

  * Add do-not-open-sidebar-on-first-start.patch and prevent that the sidebar
    in Firefox opens on first startup. This feature only works in
    Firefox >= 62. (Closes: #909493)

… should allow us to revert 3fc4fb4757222e5bf494eb41801862ba8d0b80c5 and e945d0c9dd331bf63edc576ace154df4aaff19a1, which should in turn fix #15924 (our Tor Browser exposes a different screen size than a pristine one).


Related issues

Related to Tails - Bug #15820: Ublock Log window is empty, need right-click to display logs Resolved 08/20/2018
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed 03/22/2019

Associated revisions

Revision 8c7d9c42
Added by segfault about 2 months ago

Merge branch 'bugfix/16206-drop-ublock-origin-css-hack' into stable (Fix-committed: #16206)

History

#2 Updated by intrigeri 6 months ago

#3 Updated by intrigeri 6 months ago

#5 Updated by intrigeri 6 months ago

#6 Updated by intrigeri 6 months ago

  • Target version deleted (Tails_3.13)

#7 Updated by intrigeri 3 months ago

And later on:

ublock-origin (1.18.2+dfsg-2) unstable; urgency=medium

  * Drop do-not-open-sidebar-on-first-start.patch. Fixed upstream.

#8 Updated by intrigeri 3 months ago

  • Related to Bug #15820: Ublock Log window is empty, need right-click to display logs added

#9 Updated by intrigeri 2 months ago

#10 Updated by intrigeri 2 months ago

#11 Updated by segfault about 2 months ago

I don't think that 3fc4fb4757222e5bf494eb41801862ba8d0b80c5 is related

#12 Updated by segfault about 2 months ago

  • Target version set to Tails_3.14
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16206-drop-ublock-origin-css-hack

It seems like we can safely drop e945d0c9dd331bf63edc576ace154df4aaff19a1. I tested this by removing the lines of the commit in /etc/tor-browser/profile/chrome/userChrome.css inside a Tails 3.13.1 before starting Tor Browser for the first time. It did not open the sidebar.

#13 Updated by hefee about 2 months ago

  • Assignee set to hefee

#14 Updated by hefee about 2 months ago

  • Assignee changed from hefee to segfault
  • QA Check changed from Ready for QA to Pass

Change looks fine for me. 3fc4fb4757222e5bf494eb41801862ba8d0b80c5 is not related to this. it passes the test suite and my manual test.

So ready for merge. As I don't have merge permissions, I reassign back to you.

#15 Updated by segfault about 2 months ago

  • Status changed from Confirmed to Fix committed
  • % Done changed from 0 to 100

#16 Updated by segfault about 2 months ago

  • Assignee deleted (segfault)

hefee wrote:

Change looks fine for me. 3fc4fb4757222e5bf494eb41801862ba8d0b80c5 is not related to this. it passes the test suite and my manual test.

So ready for merge. As I don't have merge permissions, I reassign back to you.

Done, thanks!

#17 Updated by intrigeri 18 days ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#18 Updated by anonym 17 days ago

  • Status changed from Fix committed to Resolved

#19 Updated by anonym 17 days ago

  • Target version changed from Tails_3.13.2 to Tails_3.14

#20 Updated by intrigeri 16 days ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

Also available in: Atom PDF