Project

General

Profile

Feature #16195

Warn about free software also when the host OS might not be free

Added by sajolida 11 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Virtualization
Target version:
Start date:
12/06/2018
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Associated revisions

Revision 7e82843e (diff)
Added by intrigeri 11 months ago

Lint (fix-committed: #16195).

History

#1 Updated by sajolida 11 months ago

Here is a patch (untested).

#2 Updated by intrigeri 11 months ago

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri
  • Target version changed from Tails_3.12 to Tails_3.11

This was pushed straight to the master branch already (2bdec3e1a7d08ffe615de61811982d2c86e97197) so unless we revert it, it'll be in 3.11. The proposed change seems simple enough so I'll review this in time for 3.11 :)

#3 Updated by intrigeri 11 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

#4 Updated by intrigeri 11 months ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Yeah, so nowadays I write Ruby and you write Perl ;)

Added a polishing commit on top, tested in libvirt/qemu, merged into stable, then merged into devel, resolved merge conflicts, pushed master + stable + devel.

#5 Updated by sajolida 11 months ago

This was pushed straight to the master branch already (2bdec3e1a7d08ffe615de61811982d2c86e97197)

Oh shiiit! I've always been afraid of doing something like this and ...
I did it without even noticing :(((

Glad you saw it!

--
sajolida

#6 Updated by intrigeri 11 months ago

This was pushed straight to the master branch already (2bdec3e1a7d08ffe615de61811982d2c86e97197)

Oh shiiit! I've always been afraid of doing something like this and ...
I did it without even noticing :(((

That's fine, shit happens, and we had the option to revert.

#7 Updated by CyrilBrulebois 11 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF