Project

General

Profile

Bug #16145

Upgrade Linux to 4.18.20

Added by intrigeri about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
11/22/2018
Due date:
% Done:

100%

Feature Branch:
feature/16145-linux-4.18.20-2 feature/16145-linux-4.18.20-2+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Related issues

Related to Tails - Bug #16073: Upgrade Linux to 4.19 Resolved 10/25/2018
Related to Tails - Bug #16224: Black screen after the boot menu with Intel GPU (i915) Resolved 12/13/2018
Blocks Tails - Feature #15506: Core work 2018Q4: Foundations Team Resolved 04/08/2018

Associated revisions

Revision 5f7db2ad (diff)
Added by anonym about 1 year ago

Upgrade Linux to 4.18.20 and aufs to 4.18.11+-20181119.

Will-fix: #16145

Revision a74fff47 (diff)
Added by anonym about 1 year ago

Enable the feature-16145-linux-4.18.20-2 APT overlay.

Will-fix: #16145

Revision 744c06e0 (diff)
Added by anonym about 1 year ago

Upgrade Linux to 4.18.20 and aufs to 4.18.11+-20181119.

Will-fix: #16145

Revision c55d08e9 (diff)
Added by anonym about 1 year ago

Freeze exception: linux 4.18.20-2

Will-fix: #16145

Revision e2642e49
Added by intrigeri about 1 year ago

Merge branch 'feature/16145-linux-4.18.20-2+force-all-tests' into stable (Fix-committed: #16145)

History

#1 Updated by intrigeri about 1 year ago

#2 Updated by intrigeri about 1 year ago

  • Related to Bug #16073: Upgrade Linux to 4.19 added

#3 Updated by intrigeri about 1 year ago

  • Assignee set to segfault

Hi segfault! For 3.11 it's not clear yet whether we'll have a 4.18.x with all the security fixes we want (and then we will need to do at least what this ticket is about) or whether we'll need to go 4.19 (#16073), hence this ticket. It'll depend on when 4.19 is uploaded sid and whether it brings security fixes we want.

#4 Updated by intrigeri about 1 year ago

Hi segfault! The timing for getting this done in time for 3.11 is starting to be a bit tight, so I wonder: do you need help with this? If you do, please say so ASAP and I'll make time for it :)

#5 Updated by anonym about 1 year ago

Worst case, I take this over tomorrow (2018-12-07) so there's some minimal amount of time for QA at least.

#6 Updated by anonym about 1 year ago

  • Assignee changed from segfault to anonym

anonym wrote:

Worst case, I take this over tomorrow (2018-12-07) so there's some minimal amount of time for QA at least.

Hah, it should have said 2018-12-08. Any way, taking this one over so it has a chance to get into Tails 3.11.

#7 Updated by anonym about 1 year ago

  • Status changed from Confirmed to In Progress

#8 Updated by anonym about 1 year ago

  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to feature/16145-linux-4.18.20-2 feature/16145-linux-4.18.20-2+force-all-tests

#9 Updated by anonym about 1 year ago

  • % Done changed from 30 to 40

First full test suite done: https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-16145-linux-4.18.20-2-force-all-tests/1/

There are six failures. I didn't bother looking at them yet as I started two more runs -- I'll triage failures later today once I have all three runs.

Cyril, I added you as a watcher so you will get a notification about this and can anticipate the imminent review'n'merge. It will be tight! Sadly I had a bit more trouble getting this branch (well, the APT suite) in order.

#10 Updated by anonym about 1 year ago

  • Assignee changed from anonym to CyrilBrulebois
  • % Done changed from 40 to 50

Look at these two runs of different branches with +force-all-tests:

They fail the exact same tests, which to me indicates that these tests are just broken. So IMHO we're good re: tests.

On XMPP intrigeri offered to take this one over to lighten our RM's burden tomorrow, just so that's clear. I'll still assign it to the RM so it cannot be forgotten!

#11 Updated by intrigeri about 1 year ago

That link is wrong, which makes me wonder if you looked at the correct test results (if not, this would invalidate your conclusions). Anyway, it's part of the reviewer's job to check test results themselves, so worries.

#12 Updated by intrigeri about 1 year ago

  • Assignee changed from CyrilBrulebois to intrigeri

#13 Updated by intrigeri about 1 year ago

https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_feature-16145-linux-4.18.20-2-force-all-tests/4/cucumberTestReport/emergency-shutdown/tails-erases-memory-and-shuts-down-on-usb-boot-medium-removal_-persistent-data/ is a bit concerning but it happened only once in 5 runs, and we'll need to check what's going on in this area soon (#16097), so I'll ignore it for now. Other than that, code review passes and Jenkins is happy enough, going to merge!

#14 Updated by intrigeri about 1 year ago

  • Status changed from In Progress to 11
  • % Done changed from 50 to 100

#15 Updated by intrigeri about 1 year ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#16 Updated by intrigeri about 1 year ago

  • Related to Bug #16224: Black screen after the boot menu with Intel GPU (i915) added

#17 Updated by CyrilBrulebois about 1 year ago

  • Status changed from 11 to Resolved

Marking as Resolved as required by the release process documentation, but we might need to revert that at some point, see #16224#note-12.

Also available in: Atom PDF