Project

General

Profile

Bug #16113

Thunderbird is still in English when using Thunderbird persistence feature with a different system language

Added by xin 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Persistence
Target version:
Start date:
11/09/2018
Due date:
% Done:

100%

Spent time:
QA Check:
Pass
Feature Branch:
bugfix/16113-thunderbird-always-guess-locale
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Email Client

Description

Since 3.9, my Thunderbird is in English (with French language).
In 3.9.1 and 3.10.1 is still in English, despite the fix of #15942.
I used the Thunderbird persistence feature with a persistence created before 3.9.
In 3.10.1 launched without persistence, Thunderbird is in French.


Related issues

Related to Tails - Bug #15942: Thunderbird is displayed in English despite different system language Resolved 09/11/2018
Blocks Tails - Feature #15506: Core work 2018Q4: Foundations Team Resolved 04/08/2018

Associated revisions

Revision 5b7fa4a1 (diff)
Added by anonym 6 months ago

Thunderbird: always set locale according to environment.

We've seen users that use a persistent Thunderbird configuration being
stuck with English even if their session is in another locale.

Will-fix: #16113

History

#1 Updated by xin 6 months ago

  • Related to Bug #15942: Thunderbird is displayed in English despite different system language added

#2 Updated by mercedes508 6 months ago

  • Status changed from New to Confirmed
  • Assignee set to intrigeri

#3 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to xin
  • QA Check set to Info Needed

Argh, I guess we've persisted a value for some locales-related pref, that does not work anymore, and somehow overrides the pref("intl.locale.requested", ""); that we set in /etc/thunderbird/pref/thunderbird.js.

So first, let's confirm that: please share the output of grep -E 'intl\.locale' ~/.thunderbird/profile.default/*.js

And then, to find out how we could fix this automatically, please save a backup of ~/.thunderbird/profile.default/*.js somewhere persistent (so I can ask you later to test the code that should fix them automatically) and in PreferencesAdvancedConfig Editor, right click on intl.locale.requested → Reset. This should set the value of that pref to the empty string. Then quit Thunderbird, start it again, and report back whether it's in French.

#4 Updated by xin 6 months ago

  • Assignee changed from xin to intrigeri

Thanks for this precise step-by-step procedure.

So first, let's confirm that: please share the output of grep -E 'intl\.locale' ~/.thunderbird/profile.default/*.js

Output:
/home/amnesia/.thunderbird/profile.default/prefs.js:user_pref("intl.locale.requested", "en-US");

And then, to find out how we could fix this automatically, please save a backup of ~/.thunderbird/profile.default/*.js somewhere persistent (so I can ask you later to test the code that should fix them automatically)

Done.

in PreferencesAdvancedConfig Editor, right click on intl.locale.requested → Reset. This should set the value of that pref to the empty string. Then quit Thunderbird, start it again, and report back whether it's in French.

It works, Thunderbird is now in French.

#5 Updated by intrigeri 6 months ago

  • Target version set to Tails_3.11
  • QA Check changed from Info Needed to Dev Needed

Thanks for this precise step-by-step procedure.

Thanks for the info! :)

So first, let's confirm that: please share the output of grep -E 'intl\.locale' ~/.thunderbird/profile.default/*.js

Output:
/home/amnesia/.thunderbird/profile.default/prefs.js:user_pref("intl.locale.requested", "en-US");

And then, to find out how we could fix this automatically, please save a backup of ~/.thunderbird/profile.default/*.js somewhere persistent (so I can ask you later to test the code that should fix them automatically)

Done.

in PreferencesAdvancedConfig Editor, right click on intl.locale.requested → Reset. This should set the value of that pref to the empty string. Then quit Thunderbird, start it again, and report back whether it's in French.

It works, Thunderbird is now in French.

OK, so let's try emptying intl.locale.requested in prefs.js in our Thunderbird wrapper script so it matches the default value we ship in /etc/thunderbird/pref/thunderbird.js.

#6 Updated by intrigeri 6 months ago

#7 Updated by intrigeri 6 months ago

  • Assignee deleted (intrigeri)

Good candidate for other FT members.

#8 Updated by hefee 6 months ago

  • Assignee set to hefee

#9 Updated by intrigeri 6 months ago

  • Assignee changed from hefee to anonym

#10 Updated by anonym 6 months ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to hefee
  • % Done changed from 0 to 50
  • QA Check changed from Dev Needed to Ready for QA
  • Feature Branch set to bugfix/16113-thunderbird-always-guess-locale (or bugfix/16186-thunderbird-disable-autocrypt)

Fixed! Note that I worked on #16186 at the same time, so if you are happy with both, merge bugfix/16186-thunderbird-disable-autocrypt!

#11 Updated by hefee 6 months ago

  • QA Check changed from Ready for QA to Pass

Looks fine for me. I have not the permission to merge.

#12 Updated by intrigeri 6 months ago

  • Assignee changed from hefee to anonym

Looks fine for me. I have not the permission to merge.

Therefore reassigning to someone who as.

#13 Updated by anonym 5 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100
  • Feature Branch changed from bugfix/16113-thunderbird-always-guess-locale (or bugfix/16186-thunderbird-disable-autocrypt) to bugfix/16113-thunderbird-always-guess-locale

#14 Updated by CyrilBrulebois 5 months ago

Thanks; it seems the merge lacked a “fix-committed: #16113” entry, but that was done on Redmine, so everything should be OK, right?

#15 Updated by anonym 5 months ago

  • Assignee deleted (anonym)

#16 Updated by intrigeri 5 months ago

Thanks; it seems the merge lacked a “fix-committed: #16113” entry, but that was done on Redmine, so everything should be OK, right?

Yep, it's unfortunate that the commit message does not record this (that's useful info) but no big deal as long as metadata is correct on Redmine in the end.

#17 Updated by CyrilBrulebois 5 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF