Project

General

Profile

Bug #16073

Upgrade Linux to 4.19

Added by intrigeri 11 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
10/25/2018
Due date:
% Done:

100%

Feature Branch:
feature/16073-linux-4.19+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Related issues

Related to Tails - Bug #16145: Upgrade Linux to 4.18.20 Resolved 11/22/2018
Blocks Tails - Bug #16072: Enable protected_fifos and protected_regular Resolved 10/25/2018
Blocks Tails - Bug #16224: Black screen after the boot menu with Intel GPU (i915) Resolved 12/13/2018
Blocks Tails - Feature #14991: Remove /usr/share/live/config/xserver-xorg/intel.ids Resolved 11/18/2017
Blocks Tails - Feature #15507: Core work 2019Q1: Foundations Team Resolved 04/08/2018
Blocked by Tails - Bug #16349: Stick to Tor 0.3.4 in Tails 3.12 Resolved 01/12/2019
Blocks Tails - Bug #16352: Fix systemd vulnerabilities: CVE-2018-16864, CVE-2018-16865 and CVE-2018-16866 Resolved 01/13/2019

Associated revisions

Revision bb76938c (diff)
Added by CyrilBrulebois 9 months ago

Upgrade Linux to 4.19 and aufs to 4.19-20181217 (refs: #15857, #16073).

Revision 25c4716d (diff)
Added by CyrilBrulebois 9 months ago

Upgrade Linux to 4.19 and aufs to 4.19-20181217 (refs: #16073).

Revision d2652e75 (diff)
Added by CyrilBrulebois 9 months ago

Bump fake package to linux-compiler-gcc-8-x86 (refs: #16073).

This is needed for the 4.19+ linux-headers packages.

History

#1 Updated by intrigeri 11 months ago

  • Blocks Bug #16072: Enable protected_fifos and protected_regular added

#2 Updated by intrigeri 11 months ago

#3 Updated by segfault 11 months ago

  • Assignee changed from intrigeri to segfault

#4 Updated by segfault 11 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check set to Info Needed

#5 Updated by intrigeri 11 months ago

  • Assignee changed from intrigeri to segfault
  • QA Check deleted (Info Needed)

#6 Updated by intrigeri 10 months ago

  • Related to Bug #16145: Upgrade Linux to 4.18.20 added

#7 Updated by intrigeri 10 months ago

  • Target version changed from Tails_3.11 to Tails_3.12

4.19 was not uploaded to sid yet so given where we're at in the Tails 3.11 cycle, let's assume we won't have to do this and instead focus on #16145.

#8 Updated by intrigeri 9 months ago

4.19 is now in sid, please proceed early enough in the 3.12 cycle so we have time to identify any regression :)

#9 Updated by intrigeri 9 months ago

  • Blocks Bug #16224: Black screen after the boot menu with Intel GPU (i915) added

#10 Updated by intrigeri 9 months ago

  • Priority changed from Normal to Elevated

(This blocks #16224.)

Can you please give an ETA here? Maybe you need help?

#11 Updated by intrigeri 9 months ago

  • Blocks Feature #14991: Remove /usr/share/live/config/xserver-xorg/intel.ids added

#12 Updated by intrigeri 9 months ago

  • Assignee changed from segfault to CyrilBrulebois

kibi has to do the first steps of this work for feature/buster so let's do it based on devel :)

#13 Updated by CyrilBrulebois 9 months ago

  • Status changed from Confirmed to In Progress

#14 Updated by CyrilBrulebois 9 months ago

I've pushed bb76938cca399e6307aa9931bf54dd8a06e03425 with feature/buster since the toolchain needed for 4.18 wasn't available in buster, and I'll prepare a separate branch based on devel to prepare the same upgrade for 3.12.

#15 Updated by CyrilBrulebois 9 months ago

  • Feature Branch set to feature/16073-linux-4.19+force-all-tests

#16 Updated by intrigeri 9 months ago

#17 Updated by intrigeri 9 months ago

#18 Updated by intrigeri 9 months ago

FTBFS:

01:40:56 The following packages have unmet dependencies:
01:40:56  linux-headers-4.19.0-1-amd64 : Depends: linux-compiler-gcc-8-x86 but it is not going to be installed
01:40:56 E: Unable to correct problems, you have held broken packages.
01:40:56 E: config/chroot_local-hooks/12-kernel-modules-build-environment failed (exit non-zero). You should check for errors.

#19 Updated by CyrilBrulebois 9 months ago

Right, this is due to https://salsa.debian.org/kernel-team/linux/commit/01900fbc7319c7a427886141b0f051154534b56a

commit 01900fbc7319c7a427886141b0f051154534b56a
Author: Ben Hutchings <ben@decadent.org.uk>
Date:   Tue Aug 28 22:31:59 2018 +0100

    Compile with gcc-8 on all architectures

    Update the compiler dependencies for x86 to the first version of gcc-8
    with retpoline support.

Will bump the “fake our gcc package” infrastructure from version 7 to 8.

#20 Updated by CyrilBrulebois 9 months ago

Confirmed to build fine, now waiting for tests results.

#21 Updated by intrigeri 9 months ago

I took a quick look at test suite jobs 1-4 on Jenkins. Apart of the memory erasure tests that fail on devel too, and a few fragile tests that failed in some runs but not others (so can be mostly safely ignored), "Using Totem ǂ Watching a WebM video over HTTPS" failed every time. Before we call this ready for QA, let's test this manually on an ISO built from this branch, to ensure it's not a regression brought by Linux 4.19.

#22 Updated by intrigeri 8 months ago

  • Assignee changed from CyrilBrulebois to intrigeri

#23 Updated by intrigeri 8 months ago

intrigeri wrote:

"Using Totem ǂ Watching a WebM video over HTTPS" failed every time. Before we call this ready for QA, let's test this manually on an ISO built from this branch, to ensure it's not a regression brought by Linux 4.19.

"Run" this Totem test case manually on this branch, works fine. And while I was at it I tested the same with Totem started from the Applications menu, which failed due to a buggy build-time hook (the torification tweak was not applied). Testing a fix.

Apart of that, pidgin.feature started failing on this branch on Jenkins. Tracked this down to the upgrade to tor 0.3.5 => let's postpone that upgrade to Tails 3.13 (#16348, #16349).

#24 Updated by intrigeri 8 months ago

  • Assignee changed from intrigeri to CyrilBrulebois
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

Tested on bare metal the branch for #16072, which is based on this one. It boots, Wi-Fi connects, Tor Browser starts, unplugging the USB stick triggers successful shutdown: HP EliteBook 840 G1, ThinkPad X200.

Regarding the Totem issue: with my fix (07e0cbed3053ab0407a982654007641fa5865702) applied, testing manually, Totem can read this WebM video over HTTPs both when started from a terminal and when started from the Applications menu. I don't know why the test fails in our test suite, but I guess there's a reason why this test case is tagged @fragile.

So I'm calling this ready for QA. kibi, can you take it?

I suggest batching this review with the one for #16072, whose branch is based on this one. It should be ready for QA in ~3h.

#25 Updated by intrigeri 8 months ago

  • Assignee deleted (CyrilBrulebois)

(Emailing the whole team to bootstrap some review coordination.)

#26 Updated by intrigeri 8 months ago

  • Blocked by Bug #16349: Stick to Tor 0.3.4 in Tails 3.12 added

#27 Updated by intrigeri 8 months ago

  • Blocks Bug #16352: Fix systemd vulnerabilities: CVE-2018-16864, CVE-2018-16865 and CVE-2018-16866 added

#28 Updated by hefee 8 months ago

  • Assignee set to hefee

#29 Updated by hefee 8 months ago

  • Assignee deleted (hefee)

looks fine code-wise - needs bar metal checks.

#30 Updated by intrigeri 8 months ago

  • Assignee set to kurono

#31 Updated by intrigeri 8 months ago

Oops, I've just merged this into devel by mistake (by merging another branch that was based on this one). Fingers crossed.

#32 Updated by kurono 8 months ago

  • Assignee changed from kurono to intrigeri

This branch with Linux to 4.19 works fine in my laptop with the Intel Corporation HD Graphics 520 hardware.

#33 Updated by intrigeri 8 months ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Thanks! All right then. anonym, if you can test with NVIDIA, this is still welcome.

#34 Updated by anonym 8 months ago

I tested on my T430 and everything worked nicely when I (via BIOS) disabled the Intel card and enabled the NVidia card. In Optimus mode Intel was preferred, FWIW.

#35 Updated by intrigeri 8 months ago

I tested on my T430 and everything worked nicely when I (via BIOS) disabled the Intel card and enabled the NVidia card. In Optimus mode Intel was preferred, FWIW.

Thanks!

#36 Updated by anonym 8 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF